From 5b7947b51ac507426e36c1f6fe33a391b97748a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Date: Sat, 12 Aug 2017 15:15:52 +0200 Subject: [PATCH] Improve QubesDaemonNoResponseError error message Include hint to look into dom0 logs QubesOS/qubes-issues#3016 --- qubesadmin/base.py | 3 ++- qubesadmin/exc.py | 2 +- qubesadmin/tests/errors.py | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/qubesadmin/base.py b/qubesadmin/base.py index cb9d64a..7ff5672 100644 --- a/qubesadmin/base.py +++ b/qubesadmin/base.py @@ -79,7 +79,8 @@ class PropertyHolder(object): if response_data == b'': raise qubesadmin.exc.QubesDaemonNoResponseError( - 'Got empty response from qubesd') + 'Got empty response from qubesd. See journalctl in dom0 for ' + 'details.') if response_data[0:2] == b'\x30\x00': return response_data[2:] diff --git a/qubesadmin/exc.py b/qubesadmin/exc.py index 54fb224..169caa7 100644 --- a/qubesadmin/exc.py +++ b/qubesadmin/exc.py @@ -126,7 +126,7 @@ class StoragePoolException(QubesException): class QubesDaemonCommunicationError(QubesException, IOError): '''Error while communicating with qubesd, may mean insufficient - permissions, as well''' + permissions as well''' class DeviceAlreadyAttached(QubesException, KeyError): diff --git a/qubesadmin/tests/errors.py b/qubesadmin/tests/errors.py index cc8959f..6b21ea3 100644 --- a/qubesadmin/tests/errors.py +++ b/qubesadmin/tests/errors.py @@ -56,4 +56,5 @@ class TC_00_Errors(qubesadmin.tests.QubesTestCase): as context: vms = list(self.app.domains) self.assertEqual(str(context.exception), - 'Got empty response from qubesd') + 'Got empty response from qubesd. ' + 'See journalctl in dom0 for details.')