Qubes/core-admin-client
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add QubesNoSuchPropertyError exception, expect it on invalid property

Browse Source 
It inherits from AttributeError, so standard handling should just work.
This commit is contained in:
Marek Marczykowski-Górecki 2017-05-23 04:31:41 +02:00
parent fa66763628
commit de2f23b9fe
No known key found for this signature in database
GPG Key ID: 063938BA42CFA724
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
qubesadmin/exc.py
View File

@ -91,6 +91,11 @@ class QubesPropertyValueError(QubesValueError):
''' '''
class QubesNoSuchPropertyError(QubesException, AttributeError):
'''Requested property does not exist
'''
class QubesNotImplementedError(QubesException, NotImplementedError): class QubesNotImplementedError(QubesException, NotImplementedError):
'''Thrown at user when some feature is not implemented''' '''Thrown at user when some feature is not implemented'''

10
qubesadmin/tests/vm/properties.py
View File

@ -105,6 +105,16 @@ class TC_00_Properties(qubesadmin.tests.vm.VMTestCase):
self.assertEqual(self.vm.property_is_default('prop1'), True) self.assertEqual(self.vm.property_is_default('prop1'), True)
self.assertAllCalled() self.assertAllCalled()
def test_012_get_invalid(self):
self.app.expected_calls[
('test-vm', 'admin.vm.property.Get', 'invalid', None)] = \
b'2\x00QubesNoSuchPropertyError\x00\x00Invalid property ' \
b'\'invalid\' on test-vm\x00'
with self.assertRaises(qubesadmin.exc.QubesNoSuchPropertyError):
self.vm.invalid
self.assertFalse(hasattr(self.vm, 'invalid'))
self.assertAllCalled()
def test_020_set_str(self): def test_020_set_str(self):
self.app.expected_calls[ self.app.expected_calls[
('test-vm', 'admin.vm.property.Set', 'prop1', b'value')] = \ ('test-vm', 'admin.vm.property.Set', 'prop1', b'value')] = \