core-admin-client/qubesadmin/tools/qvm_remove.py
Pawel Marczewski bf78aebf7c
qvm-remove: improve error message
The code assumes that QubesVMInUseError is thrown for a failed
dependency check, but there are also other reasons. We need to
handle the case when dependency list is empty, and also display
the original message.

See also QubesOS/qubes-core-admin#308 for which this was needed.
2020-01-21 15:54:18 +01:00

75 lines
2.6 KiB
Python

#
# The Qubes OS Project, http://www.qubes-os.org
#
# Copyright (C) 2017 Marek Marczykowski-Górecki
# <marmarek@invisiblethingslab.com>
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU Lesser General Public License as published by
# the Free Software Foundation; either version 2.1 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public License along
# with this program; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
#
''' Remove domains from the system '''
import sys
import qubesadmin.exc
from qubesadmin.tools import QubesArgumentParser
import qubesadmin.utils
parser = QubesArgumentParser(description=__doc__,
want_app=True,
vmname_nargs='+')
parser.add_argument("--force", "-f", action="store_true", dest="no_confirm",
default=False, help="Do not prompt for confirmation")
def main(args=None, app=None): # pylint: disable=missing-docstring
args = parser.parse_args(args, app=app)
go_ahead = ""
if not args.no_confirm:
print("This will completely remove the selected VM(s)...")
for vm in args.domains:
print(" ", vm.name)
go_ahead = input("Are you sure? [y/N] ").upper()
if args.no_confirm or go_ahead == "Y":
for vm in args.domains:
try:
del args.app.domains[vm.name]
except qubesadmin.exc.QubesVMInUseError as e:
dependencies = qubesadmin.utils.vm_dependencies(vm.app, vm)
if dependencies:
print("VM {} cannot be removed. It is in use as:".format(
vm.name))
for (holder, prop) in dependencies:
if holder:
print(" - {} for {}".format(prop, holder.name))
else:
print(" - global property {}".format(prop))
# Display the original message as well
parser.error_runtime(e)
except qubesadmin.exc.QubesException as e:
parser.error_runtime(e)
retcode = 0
else:
print("Remove cancelled.")
retcode = 1
return retcode
if __name__ == '__main__':
sys.exit(main())