From 0cd25b53500d3ffcf69bbe88a93d3e6c05eaff2d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Date: Sun, 6 Aug 2017 12:49:19 +0200 Subject: [PATCH] firewall: fix Firewall.clone() New rule require action to be defined, even if will be overwritten a moment later. --- qubes/firewall.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qubes/firewall.py b/qubes/firewall.py index 86397802..8fb0259f 100644 --- a/qubes/firewall.py +++ b/qubes/firewall.py @@ -479,7 +479,9 @@ class Firewall(object): ''' rules = [] for rule in other.rules: - new_rule = Rule() + # Rule constructor require some action, will be overwritten by + # clone_properties below + new_rule = Rule(action='drop') new_rule.clone_properties(rule) rules.append(new_rule) self.rules = rules