Qubes/core-admin
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update lvm.py

Browse Source 
Break the ioctl calls from blkdiscard into max 1GB worth of blocks per call. This ensures that the amount of pending discards (both for the virtual lvm thin volume as well as any lower level device recipients) do not dominate the IO streams to the devices. Before this change, IO blocking was leading to both UI and processing freezes in Qubes while very large LVM volumes were being removed. The change will allow other device IOs to be interleaved between the internal ioctl calls from blkdiscard.
This commit is contained in:
Brendan Hoar 2021-05-12 16:37:08 -04:00 committed by Brednan Hoar
parent f9bfcd8732
commit 16d069289c
No known key found for this signature in database
GPG Key ID: 48711906EDFC9A3A
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qubes/storage/lvm.py
View File

@ -818,7 +818,7 @@ def qubes_lvm_coro(cmd, log=logging.getLogger('qubes.storage.lvm')):
environ = os.environ.copy() environ = os.environ.copy()
environ['LC_ALL'] = 'C.utf8' environ['LC_ALL'] = 'C.utf8'
if cmd[0] == "remove": if cmd[0] == "remove":
pre_cmd = ['blkdiscard', '/dev/'+cmd[1]] pre_cmd = ['blkdiscard', '-p', '1G', '/dev/'+cmd[1]]
p = yield from asyncio.create_subprocess_exec(*pre_cmd, p = yield from asyncio.create_subprocess_exec(*pre_cmd,
stdout=subprocess.DEVNULL, stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL, stderr=subprocess.DEVNULL,