From 2e42a408e5528e3a53efc9fa06ca67bcff08bbe2 Mon Sep 17 00:00:00 2001
From: Wojtek Porczyk <woju@invisiblethingslab.com>
Date: Wed, 14 Oct 2015 22:27:36 +0200
Subject: [PATCH] core3: Add documentation to qubes.exc

part of QubesOS/qubes-issues#1279
---
 doc/conf.py         |  1 +
 doc/index.rst       |  1 +
 doc/qubes-exc.rst   | 63 +++++++++++++++++++++++++++++++++++++++++++++
 qubes/vm/adminvm.py |  2 +-
 4 files changed, 66 insertions(+), 1 deletion(-)
 create mode 100644 doc/qubes-exc.rst

diff --git a/doc/conf.py b/doc/conf.py
index 41a8ab74..f560ae0b 100644
--- a/doc/conf.py
+++ b/doc/conf.py
@@ -34,6 +34,7 @@ extensions = [
     'sphinx.ext.coverage',
     'sphinx.ext.doctest',
     'sphinx.ext.graphviz',
+    'sphinx.ext.inheritance_diagram',
     'sphinx.ext.intersphinx',
     'sphinx.ext.todo',
     'sphinx.ext.viewcode',
diff --git a/doc/index.rst b/doc/index.rst
index f04ef7a3..0509c8e8 100644
--- a/doc/index.rst
+++ b/doc/index.rst
@@ -16,6 +16,7 @@ manpages and API documentation. For primary user documentation, see
    qubes
    qubes-vm/index
    qubes-events
+   qubes-exc
    qubes-plugins
    qubes-ext
    qubes-log
diff --git a/doc/qubes-exc.rst b/doc/qubes-exc.rst
new file mode 100644
index 00000000..f3a644b1
--- /dev/null
+++ b/doc/qubes-exc.rst
@@ -0,0 +1,63 @@
+:py:mod:`qubes.exc` -- Exceptions
+=================================
+
+As most of the modern programming languages, Python has exceptions, which can be
+thrown (``raise``\ d) when something goes bad. What exactly means "bad" depends
+on several circumstances.
+
+One of those circumstances is who exactly is to blame: programmer or user? Some
+errors are commited by programmer and will most probably result it program
+failure. But most errors are caused by the user, notably by specifying invalid
+commands or data input. Those errors *should not* result in failure, but fault
+and be handled gracefuly. One more time, what "gracefuly" means depends on
+specific program and its interface (for example GUI programs should most likely
+display some admonition, but will not crash).
+
+In Qubes we have special exception class, :py:class:`qubes.exc.QubesException`,
+which is dedicated to handling user-caused problems. Programmer errors should
+not result in raising QubesException, but it should instead result in one of the
+standard Python exception. QubesExceptions should have a nice message that can
+be shown to the user. On the other hand, some children classes of QubesException
+also inherit from children of :py:class:`StandardException` to allow uniform
+``except`` clauses.
+
+Often the error relates to some domain, because we expect it to be in certain
+state, but it is not. For example to start a machine, it should be halted. For
+that we have the children of the :py:class:`qubes.exc.QubesVMError` class. They
+all take the domain in question as their first argument and an (optional)
+message as the second. If not specified, there is stock message which is
+generally informative enough.
+
+
+On writing error messages
+-------------------------
+
+As a general rule, error messages should be short but precise. They should not
+blame user for error, but the user should know, what had been done wrong and
+what to do next.
+
+If possible, write the message that is stating the fact, for example "Domain is
+not running" instead of "You forgot to start the domain" (you fool!). Avoid
+commanding user, like "Start the domain first" (user is not a function you can
+call for effect). Instead consider writing in negative form, implying expected
+state: "Domain is not running" instead of "Domain is paused" (yeah, what's wrong
+with that?).
+
+Also avoid implying the personhood of the computer, including adressing user in
+second person. For example, write "Sending message failed" instead of "I failed
+to send the message".
+
+
+Inheritance diagram
+-------------------
+
+.. inheritance-diagram:: qubes.exc
+
+Module contents
+---------------
+
+.. automodule:: qubes.exc
+   :members:
+   :show-inheritance:
+
+.. vim: ts=3 sw=3 et tw=80
diff --git a/qubes/vm/adminvm.py b/qubes/vm/adminvm.py
index c419bd38..a429df2c 100644
--- a/qubes/vm/adminvm.py
+++ b/qubes/vm/adminvm.py
@@ -151,7 +151,7 @@ class AdminVM(qubes.vm.qubesvm.QubesVM):
         .. seealso:
            :py:meth:`qubes.vm.qubesvm.QubesVM.start`
         ''' # pylint: disable=unused-argument
-        raise qubes.exc.QubesVMError('Cannot start Dom0 fake domain!')
+        raise qubes.exc.QubesVMError(self, 'Cannot start Dom0 fake domain!')
 
 
     def suspend(self):