Browse Source

use shuf rather than od because it is more readable

Thanks to @marmarek for the suggestion!

https://github.com/QubesOS/qubes-core-admin/pull/23/files#r55930643
Patrick Schleizer 8 years ago
parent
commit
524888d2fd
1 changed files with 2 additions and 5 deletions
  1. 2 5
      qubes-rpc/qubes.GetRandomizedTime

+ 2 - 5
qubes-rpc/qubes.GetRandomizedTime

@@ -25,13 +25,10 @@ set -e
 
 ## Get a random 0 or 1.
 ## Will use this to decide to use plus or minus.
-##
-## Thanks to
-## http://linux.byexamples.com/archives/128/generating-random-numbers/
-ZERO_OR_ONE="$(( 0+($(od -An -N2 -i /dev/random) )%(0+2) ))"
+ZERO_OR_ONE="$(shuf -i0-1 -n1 --random-source=/dev/random)"
 
 ## Create a random number between 0 and 180.
-DELAY="$(( $(od -An -N2 -i /dev/random)%(180-0+1) ))"
+DELAY="$(shuf -i0-180 -n1 --random-source=/dev/random)"
 
 ## Create a random number between 0 and 999999999.
 ##