Selaa lähdekoodia

vm: drop 'internal' property

It isn't used anywhere in the code right now. And when it will be
needed, it should be a "feature" not "property".
Marek Marczykowski-Górecki 7 vuotta sitten
vanhempi
commit
9d99232515
2 muutettua tiedostoa jossa 1 lisäystä ja 10 poistoa
  1. 0 4
      qubes/tests/vm/qubesvm.py
  2. 1 6
      qubes/vm/qubesvm.py

+ 0 - 4
qubes/tests/vm/qubesvm.py

@@ -310,10 +310,6 @@ class TC_90_QubesVM(QubesVMTestsMixin,qubes.tests.QubesTestCase):
         # TODO: lower than memory
         # TODO: human readable setter (500M, 4G)?
 
-    def test_180_internal(self):
-        vm = self.get_vm(label='red')
-        self._test_generic_bool_property(vm, 'internal', False)
-
     def test_190_vcpus(self):
         vm = self.get_vm()
         self.assertPropertyDefaultValue(vm, 'vcpus', self.app.host.no_cpus)

+ 1 - 6
qubes/vm/qubesvm.py

@@ -430,11 +430,6 @@ class QubesVM(qubes.vm.mix.net.NetVMMixin, qubes.vm.BaseVM):
         default=None,
         doc='Memory ammount allocated for the stubdom')
 
-    internal = qubes.property('internal', default=False,
-        type=bool, setter=qubes.property.bool,
-        doc='''Internal VM (not shown in qubes-manager, don't create appmenus
-            entries.''')
-
     vcpus = qubes.property('vcpus',
         type=int,
         setter=_setter_positive_int,
@@ -492,7 +487,7 @@ class QubesVM(qubes.vm.mix.net.NetVMMixin, qubes.vm.BaseVM):
             dom0 boot.''')
 
     include_in_backups = qubes.property('include_in_backups',
-        default=(lambda self: not self.internal),
+        default=True,
         type=bool, setter=qubes.property.bool,
         doc='If this domain is to be included in default backup.')