Qubes/core-admin
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

vm: drop 'internal' property

Browse Source 
It isn't used anywhere in the code right now. And when it will be
needed, it should be a "feature" not "property".
This commit is contained in:
Marek Marczykowski-Górecki 2017-06-12 09:54:24 +02:00
parent 206b7c02d5
commit 9d99232515
No known key found for this signature in database
GPG Key ID: 063938BA42CFA724
2 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qubes/tests/vm/qubesvm.py
View File

@ -310,10 +310,6 @@ class TC_90_QubesVM(QubesVMTestsMixin,qubes.tests.QubesTestCase):
# TODO: lower than memory # TODO: lower than memory
# TODO: human readable setter (500M, 4G)? # TODO: human readable setter (500M, 4G)?
def test_180_internal(self):
vm = self.get_vm(label='red')
self._test_generic_bool_property(vm, 'internal', False)
def test_190_vcpus(self): def test_190_vcpus(self):
vm = self.get_vm() vm = self.get_vm()
self.assertPropertyDefaultValue(vm, 'vcpus', self.app.host.no_cpus) self.assertPropertyDefaultValue(vm, 'vcpus', self.app.host.no_cpus)

7
qubes/vm/qubesvm.py
View File

@ -430,11 +430,6 @@ class QubesVM(qubes.vm.mix.net.NetVMMixin, qubes.vm.BaseVM):
default=None, default=None,
doc='Memory ammount allocated for the stubdom') doc='Memory ammount allocated for the stubdom')
internal = qubes.property('internal', default=False,
type=bool, setter=qubes.property.bool,
doc='''Internal VM (not shown in qubes-manager, don't create appmenus
entries.''')
vcpus = qubes.property('vcpus', vcpus = qubes.property('vcpus',
type=int, type=int,
setter=_setter_positive_int, setter=_setter_positive_int,
@ -492,7 +487,7 @@ class QubesVM(qubes.vm.mix.net.NetVMMixin, qubes.vm.BaseVM):
dom0 boot.''') dom0 boot.''')
include_in_backups = qubes.property('include_in_backups', include_in_backups = qubes.property('include_in_backups',
default=(lambda self: not self.internal), default=True,
type=bool, setter=qubes.property.bool, type=bool, setter=qubes.property.bool,
doc='If this domain is to be included in default backup.') doc='If this domain is to be included in default backup.')