Qubes/core-admin
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

qubes-lvm: drop sudo from lvm calls

Browse Source 
The script is already running as root

QubesOS/qubes-issues#2256
This commit is contained in:
Marek Marczykowski-Górecki 2016-08-18 11:46:26 +02:00
parent 6bdc82b3a6
commit a5e575618c
No known key found for this signature in database
GPG Key ID: 063938BA42CFA724
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
qubes/tools/qubes_lvm.py
View File

@ -75,7 +75,7 @@ def remove_volume(args):
tries = 1 tries = 1
successful = False successful = False
cmd = ['sudo', 'lvremove', '-f', img] cmd = ['lvremove', '-f', img]
while tries <= 3 and not successful: while tries <= 3 and not successful:
log.info("Trying to remove LVM %s", img) log.info("Trying to remove LVM %s", img)
@ -100,7 +100,7 @@ def clone_volume(args):
""" Calls lvcreate and creates new snapshot. """ """ Calls lvcreate and creates new snapshot. """
old = args.source old = args.source
new_name = args.destination new_name = args.destination
cmd = ["sudo", "lvcreate", "-kn", "-ay", "-s", old, "-n", new_name] cmd = ["lvcreate", "-kn", "-ay", "-s", old, "-n", new_name]
return subprocess.call(cmd) return subprocess.call(cmd)
@ -112,7 +112,7 @@ def new_volume(args):
size = args.size size = args.size
log.info('Creating new Thin LVM %s in %s VG %s bytes', name, thin_pool, log.info('Creating new Thin LVM %s in %s VG %s bytes', name, thin_pool,
size) size)
cmd = ['sudo', 'lvcreate', '-T', thin_pool, '-kn', '-ay', '-n', name, '-V', cmd = ['lvcreate', '-T', thin_pool, '-kn', '-ay', '-n', name, '-V',
str(size) + 'B'] str(size) + 'B']
return subprocess.call(cmd) return subprocess.call(cmd)
@ -121,7 +121,7 @@ def new_volume(args):
def rename_volume(old_name, new_name): def rename_volume(old_name, new_name):
''' Rename volume ''' ''' Rename volume '''
log.debug("Renaming LVM %s to %s ", old_name, new_name) log.debug("Renaming LVM %s to %s ", old_name, new_name)
retcode = subprocess.call(["sudo", "lvrename", old_name, new_name]) retcode = subprocess.call(["lvrename", old_name, new_name])
if retcode != 0: if retcode != 0:
raise IOError("Error renaming LVM %s to %s " % (old_name, new_name)) raise IOError("Error renaming LVM %s to %s " % (old_name, new_name))
return new_name return new_name