Qubes/core-admin
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

storage/reflink: trivial style tweaks

Browse Source 
Avoid early return for short and not deeply nested functions.
This commit is contained in:
Rusty Bird 2020-02-05 17:26:44 +00:00
parent 21971d6d0a
commit ada27ee431
No known key found for this signature in database
GPG Key ID: 469D78F47AAF2ADF
1 changed files with 18 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
qubes/storage/reflink.py
View File

@ -207,8 +207,7 @@ class ReflinkVolume(qubes.storage.Volume):
@_locked @_locked
def start(self): def start(self):
self._remove_incomplete_images() self._remove_incomplete_images()
if self.is_dirty(): if not self.is_dirty():
return self
if self.snap_on_start: if self.snap_on_start:
# pylint: disable=protected-access # pylint: disable=protected-access
_copy_file(self.source._path_clean, self._path_clean) _copy_file(self.source._path_clean, self._path_clean)
@ -309,8 +308,7 @@ class ReflinkVolume(qubes.storage.Volume):
@_coroutinized @_coroutinized
@_locked @_locked
def import_volume(self, src_volume): def import_volume(self, src_volume):
if not self.save_on_stop: if self.save_on_stop:
return self
try: try:
success = False success = False
_copy_file(src_volume.export(), self._path_import) _copy_file(src_volume.export(), self._path_import)