From b563cf290ef5fc6a251fd368d08513475145a673 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Date: Mon, 30 Mar 2015 22:33:08 +0200 Subject: [PATCH] tests: fix firewall test - use the IP, not the ping command... --- tests/network.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/network.py b/tests/network.py index f4f65d40..0b8d147c 100644 --- a/tests/network.py +++ b/tests/network.py @@ -193,7 +193,7 @@ class VmNetworkingMixin(qubes.tests.SystemTestsMixin): "Ping by name from ProxyVM failed") self.assertNotEqual(self.run_cmd(self.testvm1, self.ping_ip), 0, "Ping by IP should be blocked") - nc_cmd = "nc -w 1 --recv-only 192.168.123.45 1234" + nc_cmd = "nc -w 1 --recv-only {} 1234".format(self.test_ip) self.assertNotEqual(self.run_cmd(self.testvm1, nc_cmd), 0, "TCP connection should be blocked") @@ -233,7 +233,7 @@ class VmNetworkingMixin(qubes.tests.SystemTestsMixin): 'allow': False, 'allowDns': True, 'allowIcmp': True, - 'rules': [{'address': self.ping_ip, + 'rules': [{'address': self.test_ip, 'netmask': 32, 'proto': 'tcp', 'portBegin': 1234 @@ -250,7 +250,7 @@ class VmNetworkingMixin(qubes.tests.SystemTestsMixin): 'allow': True, 'allowDns': True, 'allowIcmp': True, - 'rules': [{'address': self.ping_ip, + 'rules': [{'address': self.test_ip, 'netmask': 32, 'proto': 'tcp', 'portBegin': 1234