From cee8201989f3c42bdb004c77198b650a681da433 Mon Sep 17 00:00:00 2001
From: Demi Marie Obenour <athena@invisiblethingslab.com>
Date: Fri, 20 Nov 2020 16:48:28 -0500
Subject: [PATCH] Always snapshot in the FILE pool
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

We must snapshot a VM’s disk before exporting it.  Otherwise, we will
likely corrupt the VM’s filesystem.

Fixes https://github.com/QubesOS/qubes-issues/issues/4324
---
 qubes/storage/file.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/qubes/storage/file.py b/qubes/storage/file.py
index 2c5e9e22..93128bb2 100644
--- a/qubes/storage/file.py
+++ b/qubes/storage/file.py
@@ -265,9 +265,7 @@ class FileVolume(qubes.storage.Volume):
         return self
 
     def export(self):
-        # FIXME: this should rather return snapshot(self.path, self.path_cow)
-        #  if domain is running
-        return self.path
+        return snapshot(self.path, self.path_cow)
 
     @asyncio.coroutine
     def import_volume(self, src_volume):