From fe77b0ec85e8b9b78814392e5b6bd0cb2303d25d Mon Sep 17 00:00:00 2001 From: Rusty Bird Date: Sat, 20 Jan 2018 23:20:23 +0000 Subject: [PATCH] Make 'qvm-volume revert' really use the latest revision admin.vm.volume.ListSnapshots returned volume revisions in undefined order, but 'qvm-volume revert' assumes the list to be in chronological order. Make that assumption true. --- qubes/api/admin.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qubes/api/admin.py b/qubes/api/admin.py index 234c7fb9..2951ab4e 100644 --- a/qubes/api/admin.py +++ b/qubes/api/admin.py @@ -347,7 +347,8 @@ class QubesAdminAPI(qubes.api.AbstractQubesAPI): assert self.arg in self.dest.volumes.keys() volume = self.dest.volumes[self.arg] - revisions = [revision for revision in volume.revisions] + id_to_timestamp = volume.revisions + revisions = sorted(id_to_timestamp, key=id_to_timestamp.__getitem__) revisions = self.fire_event_for_filter(revisions) return ''.join('{}\n'.format(revision) for revision in revisions)