Qubes/core-agent-linux
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge remote-tracking branch 'origin/pr/192'

Browse Source 
* origin/pr/192:
  vm-file-editor: drop old wait-for-session mechanism
  qubes.WaitForSession: refactor by waiting for qrexec-fork-server socket
This commit is contained in:
Marek Marczykowski-Górecki 2019-11-13 05:43:55 +01:00
commit 01aa61521b
No known key found for this signature in database
GPG Key ID: 063938BA42CFA724
2 changed files with 7 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
qubes-rpc/qubes.WaitForSession
View File

@ -1,16 +1,8 @@
#!/bin/sh #!/bin/sh
# old API - get the user from caller USERNAME="$(qubesdb-read /default-user || echo 'user')"
#read -r IGNORE_USERNAME
# use default user provided in QubesDB, or hardcoded 'user' - this must be the while ! [ -e "/var/run/qubes/qrexec-server.$USERNAME.sock" ]
# same as the X session owner do
USERNAME=$(qubesdb-read /default-user || echo 'user') sleep 0.1
cmd='echo $$ >> /tmp/qubes-session-waiter; [ ! -f /tmp/qubes-session-env ] && exec sleep inf' done
if [ "$(id -un)" = "$USERNAME" ]; then
sh -c "$cmd" 2>/dev/null
else
su -s /bin/sh -c "$cmd" - "$USERNAME" 2> /dev/null
fi
# the above line is _expected_ to be terminated by a signal, don't treat this as a failure
exit 0

35
qubes-rpc/vm-file-editor.c
View File

@ -147,11 +147,10 @@ void send_file_back(const char * filename)
int int
main() main()
{ {
struct stat stat_pre, stat_post, session_stat; struct stat stat_pre, stat_post;
int view_only = 0; int view_only = 0;
char *filename = get_filename(&view_only); char *filename = get_filename(&view_only);
int child, status, log_fd, null_fd; int child, status, log_fd, null_fd;
FILE *waiter_pidfile;
copy_file_by_name(filename); copy_file_by_name(filename);
if (view_only) { if (view_only) {
@ -162,37 +161,7 @@ main()
perror("stat pre"); perror("stat pre");
exit(1); exit(1);
} }
#ifdef DEBUG
fprintf(stderr, "time=%s, waiting for qubes-session\n", gettime());
#endif
// wait for X server to starts (especially in DispVM)
if (stat("/tmp/qubes-session-env", &session_stat)) {
switch (child = fork()) {
case -1:
perror("fork");
exit(1);
case 0:
waiter_pidfile = fopen("/tmp/qubes-session-waiter", "a");
if (waiter_pidfile == NULL) {
perror("fopen waiter_pidfile");
exit(1);
}
fprintf(waiter_pidfile, "%d\n", getpid());
fclose(waiter_pidfile);
// check the second time, to prevent race
if (stat("/tmp/qubes-session-env", &session_stat)) {
// wait for qubes-session notify
pause();
}
exit(0);
default:
waitpid(child, &status, 0);
if (WIFEXITED(status) && WEXITSTATUS(status) != 0) {
//propagate exit code from child
exit(WEXITSTATUS(status));
}
}
}
#ifdef DEBUG #ifdef DEBUG
fprintf(stderr, "time=%s, starting editor\n", gettime()); fprintf(stderr, "time=%s, starting editor\n", gettime());
#endif #endif