qubes.ShowInTerminal: simply exit if mktemp generate " character

2019-05-11 11:54:24 +02:00 · 2019-05-11 11:54:24 +02:00 · 0c3421cfa8
commit 0c3421cfa8
parent 2b2752f936
1 changed files with 7 additions and 1 deletions
--- a/qubes-rpc/qubes.ShowInTerminal
+++ b/qubes-rpc/qubes.ShowInTerminal
@ -2,7 +2,13 @@

 set -eu
 tmpdir="$(mktemp -d)"
-sock="${tmpdir//\"/\"\\\"\"/}/terminal.sock"
+
+if [[ $tmpdir =~ \" ]]; then
+    echo 'Error: non admissible character detected in sock path.'
+    exit 1
+fi
+
+sock="$tmpdir/terminal.sock"

 xterm -geometry 80x24 -e /bin/sh -c "
 until [ -S $sock ]; do sleep 0.1; done || true