瀏覽代碼

qubes-rpc: fix broken temporary file deletion in qubes.GetImageRGBA

qubesuser 8 年之前
父節點
當前提交
20dd5d2d1a
共有 1 個文件被更改,包括 4 次插入4 次删除
  1. 4 4
      qubes-rpc/qubes.GetImageRGBA

+ 4 - 4
qubes-rpc/qubes.GetImageRGBA

@@ -21,10 +21,10 @@ elif [ "${filename}" = "-" ] || [ "${filename##*:}" = "-" ]; then
     tmpfile="$(mktemp /tmp/qimg-XXXXXXXX)"
     cat > "${tmpfile}"
     if [ "${filename##*:}" = "-" ]; then
-        tmpfile="${filename%:*}:${tmpfile}"
+        filename="${filename%:*}:${tmpfile}"
+    else
+        filename="${tmpfile}"
     fi
-    filename="${tmpfile}"
-
 elif ! [ -r "${filename}" ]; then
     exit 1
 fi
@@ -34,6 +34,6 @@ fi
 identify -format '%w %h\n' "$filename" | sed -e '/^$/d'
 convert -depth 8 "$filename" rgba:-
 
-[ -n "${tmpfile}" ] && rm -f ${tmpfile} || true
+[ -n "${tmpfile}" ] && rm -f "${tmpfile}" || true
 
 # vim: ft=sh ts=4 sw=4 et