Qubes/core-agent-linux
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

misc/qubes-run-terminal: which -> type

Browse Source 
'which' is an external tool, 'type' is a shell builtin. Using the latter
shaves off a bit of latency.

Also use the already open stderr file descriptor for redirection.
This commit is contained in:
Rusty Bird 2018-08-28 01:25:12 +00:00
parent b2fccfef86
commit 5ad945b674
No known key found for this signature in database
GPG Key ID: 469D78F47AAF2ADF
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
misc/qubes-run-terminal
View File

@ -2,10 +2,11 @@
# Try to find a terminal emulator that's installed and run it.
for terminal in x-terminal-emulator gnome-terminal xfce4-terminal konsole urxvt rxvt termit terminator Eterm aterm roxterm termite lxterminal mate-terminal terminology st xterm; do
if which $terminal >/dev/null 2>&1 ; then
# bogus warning from ShellCheck < 0.5.0
# shellcheck disable=SC2039
if type "$terminal" >/dev/null 2>&1 ; then
exec "$terminal"
fi
done
echo "ERROR: No suitable terminal found." > /dev/stderr
echo "ERROR: No suitable terminal found." >&2