From 97dd21bcff175f14e6e33c466615627ff57f72fa Mon Sep 17 00:00:00 2001 From: HW42 Date: Thu, 5 Feb 2015 04:22:48 +0100 Subject: [PATCH] debian: preinst: cleanup user creation Generate user-groups via -U instead of explicit via groupadd. This also fix the problem that the tinyproxy group were not gererated as "system"-group. Also suppress unneeded output of the existence test. --- debian/qubes-core-agent.preinst | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/debian/qubes-core-agent.preinst b/debian/qubes-core-agent.preinst index 8a253d8..2779846 100755 --- a/debian/qubes-core-agent.preinst +++ b/debian/qubes-core-agent.preinst @@ -49,13 +49,11 @@ if [ "$1" = "install" ] ; then # -------------------------------------------------------------------------- # User add / modifications # -------------------------------------------------------------------------- - id -u 'user' || { - groupadd -f user - useradd -g user -G dialout,cdrom,floppy,sudo,audio,dip,video,plugdev -m -s /bin/bash user + id -u 'user' >/dev/null 2>&1 || { + useradd -U -G dialout,cdrom,floppy,sudo,audio,dip,video,plugdev -m -s /bin/bash user } - id -u 'tinyproxy' || { - groupadd -f tinyproxy - useradd -g tinyproxy -r -M --home /run/tinyproxy --shell /bin/false tinyproxy + id -u 'tinyproxy' >/dev/null 2>&1 || { + useradd -U -r -M --home /run/tinyproxy --shell /bin/false tinyproxy } usermod -p '' root usermod -L user