From b02dd6a76804f6a8dbf7f67905b7a641362b3a41 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Date: Mon, 16 Mar 2020 02:10:14 +0100 Subject: [PATCH] dom0-updates: output diagnostics messages to stderr Do not interfere with yum/dnf output, which can be parserd by salt in dom0. This is especially the case for listing available updates. --- package-managers/qubes-download-dom0-updates.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package-managers/qubes-download-dom0-updates.sh b/package-managers/qubes-download-dom0-updates.sh index 8e7d4db..a85b28f 100755 --- a/package-managers/qubes-download-dom0-updates.sh +++ b/package-managers/qubes-download-dom0-updates.sh @@ -139,7 +139,7 @@ if ! $YUM --help | grep -q downloadonly; then mapfile -t PKGLIST < <(echo "$UPDATES_FULL" | grep -v "^Obsoleting\|Could not" | cut -f 1 -d ' ') if [ "$check_update_retcode" -eq 0 ]; then # exit code 0 means no updates available - regardless of stdout messages - echo "No new updates available" + echo "No new updates available" >&2 exit 0 fi YUM_COMMAND="yumdownloader --destdir=$DOM0_UPDATES_DIR/packages --resolve" @@ -194,7 +194,7 @@ if ls "$DOM0_UPDATES_DIR"/packages/*.rpm > /dev/null 2>&1; then rpmkeys_error=1 rm "$pkg" else - echo "Successfully verified $pkg" + echo "Successfully verified $pkg" >&2 fi done if [ ! "$rpmkeys_error" = "0" ]; then @@ -211,5 +211,5 @@ if ls "$DOM0_UPDATES_DIR"/packages/*.rpm > /dev/null 2>&1; then exit "$qrexec_exit_code" fi else - echo "No packages downloaded" + echo "No packages downloaded" >&2 fi