Qubes/core-agent-linux
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add -Wextra -Werror to all C code

Browse Source
This commit is contained in:
Marek Marczykowski-Górecki 2014-02-16 11:34:22 +01:00
parent d931ba237e
commit c632f0d067
5 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
misc/Makefile
View File

@ -1,5 +1,5 @@
CC=gcc CC=gcc
CFLAGS=-Wall -g -O3 CFLAGS=-Wall -Wextra -Werror -g -O3
all: xenstore-watch python all: xenstore-watch python
xenstore-watch: xenstore-watch.o xenstore-watch: xenstore-watch.o
$(CC) -o xenstore-watch xenstore-watch.o -lxenstore $(CC) -o xenstore-watch xenstore-watch.o -lxenstore

2
qrexec/Makefile
View File

@ -1,5 +1,5 @@
CC=gcc CC=gcc
CFLAGS+=-I. -g -Wall -pie -fPIC CFLAGS+=-I. -g -Wall -Wextra -Werror -pie -fPIC
XENLIBS=-lvchan -lxenstore -lxenctrl XENLIBS=-lvchan -lxenstore -lxenctrl
LIBS=$(XENLIBS) -lqrexec-utils LIBS=$(XENLIBS) -lqrexec-utils

10
qrexec/qrexec-agent.c
View File

@ -149,7 +149,7 @@ void do_exec(const char *cmd)
exit(1); exit(1);
} }
void handle_just_exec(int client_id, int len) void handle_just_exec(int len)
{ {
char buf[len]; char buf[len];
int fdn, pid; int fdn, pid;
@ -362,7 +362,7 @@ void handle_server_data()
break; break;
case MSG_SERVER_TO_AGENT_JUST_EXEC: case MSG_SERVER_TO_AGENT_JUST_EXEC:
wake_meminfo_writer(); wake_meminfo_writer();
handle_just_exec(s_hdr.client_id, s_hdr.len); handle_just_exec(s_hdr.len);
break; break;
case MSG_SERVER_TO_AGENT_INPUT: case MSG_SERVER_TO_AGENT_INPUT:
handle_input(s_hdr.client_id, s_hdr.len); handle_input(s_hdr.client_id, s_hdr.len);
@ -385,7 +385,7 @@ void handle_process_data(int fd)
int len; int len;
len = buffer_space_vchan_ext(); len = buffer_space_vchan_ext();
if (len <= sizeof s_hdr) if (len <= (int)sizeof s_hdr)
return; return;
ret = read(fd, buf, len - sizeof s_hdr); ret = read(fd, buf, len - sizeof s_hdr);
@ -425,7 +425,7 @@ void handle_process_data(int fd)
volatile int child_exited; volatile int child_exited;
void sigchld_handler(int x) void sigchld_handler(int x __attribute__((__unused__)))
{ {
child_exited = 1; child_exited = 1;
signal(SIGCHLD, sigchld_handler); signal(SIGCHLD, sigchld_handler);
@ -580,7 +580,7 @@ int main()
reap_children(); reap_children();
max = fill_fds_for_select(&rdset, &wrset); max = fill_fds_for_select(&rdset, &wrset);
if (buffer_space_vchan_ext() <= if (buffer_space_vchan_ext() <=
sizeof(struct server_header)) (int)sizeof(struct server_header))
FD_ZERO(&rdset); FD_ZERO(&rdset);
wait_for_vchan_or_argfd(max, &rdset, &wrset); wait_for_vchan_or_argfd(max, &rdset, &wrset);

2
qubes-rpc/Makefile
View File

@ -1,5 +1,5 @@
CC=gcc CC=gcc
CFLAGS=-g -Wall -I. -fPIC -pie CFLAGS=-g -Wall -Wextra -Werror -I. -fPIC -pie
all: vm-file-editor qopen-in-vm qfile-agent qfile-unpacker tar2qfile all: vm-file-editor qopen-in-vm qfile-agent qfile-unpacker tar2qfile
vm-file-editor: vm-file-editor.o vm-file-editor: vm-file-editor.o
$(CC) -pie -g -o $@ $^ -lqubes-rpc-filecopy $(CC) -pie -g -o $@ $^ -lqubes-rpc-filecopy

2
qubes-rpc/qfile-unpacker.c
View File

@ -31,7 +31,7 @@ int prepare_creds_return_uid(const char *username)
return pwd->pw_uid; return pwd->pw_uid;
} }
int main(int argc, char ** argv) int main(int argc __attribute((__unused__)), char ** argv __attribute__((__unused__)))
{ {
char *incoming_dir; char *incoming_dir;
int uid; int uid;