From ca57a67fd0465673eae0f25e8df4e2c5415221bb Mon Sep 17 00:00:00 2001 From: Alexandre Bezroutchko Date: Tue, 9 Oct 2012 23:33:17 +0200 Subject: [PATCH] dom0+vm/qvm-usb: cosmetic: removed debugging code, adjusted fixmes --- misc/usb_add_change | 2 +- misc/xl-qvm-usb-attach.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/misc/usb_add_change b/misc/usb_add_change index 56cde28..a265900 100755 --- a/misc/usb_add_change +++ b/misc/usb_add_change @@ -8,7 +8,7 @@ ## running in dom0. ## -# FIXME: Ignore USB hubs and other wierd devices. +# FIXME: Ignore USB hubs and other wierd devices (see also in usb_remove). [ "$DEVNUM" = "001" ] && exit 0 [ "$DEVTYPE" != "usb_device" ] && exit 0 diff --git a/misc/xl-qvm-usb-attach.py b/misc/xl-qvm-usb-attach.py index 3f58713..dfa29a6 100755 --- a/misc/xl-qvm-usb-attach.py +++ b/misc/xl-qvm-usb-attach.py @@ -18,8 +18,9 @@ if len(frontend)!=2: backend=sys.argv[4] -# FIXME command injection +# FIXME: command injection os.system("xenstore-write /local/domain/%s/backend/vusb/%s/%s/port/%s %s" % (backend, domain, controller, port, device)) +# FIXME: should this happen in the backend domain? vusb_util.bind_usb_device(device)