Browse Source

Fix iterating and removing over list

Return after removing and raise exception if removable item not found
donoban 5 years ago
parent
commit
22a9823871
2 changed files with 6 additions and 0 deletions
  1. 3 0
      qubesmanager/qube_manager.py
  2. 3 0
      qubesmanager/settings.py

+ 3 - 0
qubesmanager/qube_manager.py

@@ -494,6 +494,9 @@ class VmManagerWindow(ui_qubemanager.Ui_VmManagerWindow, QtGui.QMainWindow):
                         self.tr(msg))
 
                 self.threads_list.remove(thread)
+                return
+
+        raise RuntimeError('No finished thread found')
 
     def closeEvent(self, event):
         # pylint: disable=invalid-name

+ 3 - 0
qubesmanager/settings.py

@@ -240,10 +240,13 @@ class VMSettingsWindow(ui_settingsdlg.Ui_SettingsDialog, QtGui.QDialog):
                         self.tr(msg))
 
                 self.threads_list.remove(thread)
+                return
 
                 if self.thread_closes:
                     self.done(0)
 
+        raise RuntimeError('No finished thread found')
+
     def keyPressEvent(self, event):  # pylint: disable=invalid-name
         if event.key() == QtCore.Qt.Key_Enter \
                 or event.key() == QtCore.Qt.Key_Return: