Qubes/manager
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix iterating and removing over list

Browse Source 
Return after removing and raise exception if removable item not found
This commit is contained in:
donoban 2018-11-25 18:37:34 +01:00
parent 0ce73df57d
commit 22a9823871
No known key found for this signature in database
GPG Key ID: 141310D8E3ED08A5
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
qubesmanager/qube_manager.py
View File

@ -494,6 +494,9 @@ class VmManagerWindow(ui_qubemanager.Ui_VmManagerWindow, QtGui.QMainWindow):
self.tr(msg)) self.tr(msg))
self.threads_list.remove(thread) self.threads_list.remove(thread)
return
raise RuntimeError('No finished thread found')
def closeEvent(self, event): def closeEvent(self, event):
# pylint: disable=invalid-name # pylint: disable=invalid-name

3
qubesmanager/settings.py
View File

@ -240,10 +240,13 @@ class VMSettingsWindow(ui_settingsdlg.Ui_SettingsDialog, QtGui.QDialog):
self.tr(msg)) self.tr(msg))
self.threads_list.remove(thread) self.threads_list.remove(thread)
return
if self.thread_closes: if self.thread_closes:
self.done(0) self.done(0)
raise RuntimeError('No finished thread found')
def keyPressEvent(self, event): # pylint: disable=invalid-name def keyPressEvent(self, event): # pylint: disable=invalid-name
if event.key() == QtCore.Qt.Key_Enter \ if event.key() == QtCore.Qt.Key_Enter \
or event.key() == QtCore.Qt.Key_Return: or event.key() == QtCore.Qt.Key_Return: