Qubes/manager
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Qube Manager conservative updating

Browse Source 
Only update the widget changed, if possible; look at the event
that caused the update and update whatever was actually changed not
the whole VM row.
This commit is contained in:
Marta Marczykowska-Górecka 2019-01-11 15:15:08 +01:00
parent a9c8d524c7
commit 3cf9ff3ee2
No known key found for this signature in database
GPG Key ID: 9A752C30B26FD04B
1 changed files with 20 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
qubesmanager/qube_manager.py
View File

@ -135,22 +135,31 @@ class VmRowInTable:
self.table = table self.table = table
def update(self, update_size_on_disk=False): def update(self, update_size_on_disk=False, event=None):
""" """
Update info in a single VM row Update info in a single VM row
:param update_size_on_disk: should disk utilization be updated? the :param update_size_on_disk: should disk utilization be updated? the
widget will extract the data from VM object widget will extract the data from VM object
:param event: name of the event that caused the update, to avoid
updating unnecessary properties; if event is none, update everything
:return: None :return: None
""" """
try: try:
self.label_widget.update()
self.info_widget.update_vm_state() self.info_widget.update_vm_state()
self.template_widget.update() if not event or event.endswith(':label'):
self.netvm_widget.update() self.label_widget.update()
self.internal_widget.update() if not event or event.endswith(':template'):
self.ip_widget.update() self.template_widget.update()
self.include_in_backups_widget.update() if not event or event.endswith(':netvm'):
self.last_backup_widget.update() self.netvm_widget.update()
if not event or event.endswith(':internal'):
self.internal_widget.update()
if not event or event.endswith(':ip'):
self.ip_widget.update()
if not event or event.endswith(':include_in_backups'):
self.include_in_backups_widget.update()
if not event or event.endswith(':backup_timestamp'):
self.last_backup_widget.update()
if update_size_on_disk: if update_size_on_disk:
self.size_widget.update() self.size_widget.update()
except exc.QubesPropertyAccessError: except exc.QubesPropertyAccessError:
@ -509,7 +518,7 @@ class VmManagerWindow(ui_qubemanager.Ui_VmManagerWindow, QtGui.QMainWindow):
for vm in self.qubes_app.domains: for vm in self.qubes_app.domains:
if vm.klass in {'TemplateVM', 'StandaloneVM'}: if vm.klass in {'TemplateVM', 'StandaloneVM'}:
try: try:
self.vms_in_table[vm.qid].update() self.vms_in_table[vm.qid].info_widget.update_vm_state()
except (exc.QubesException, KeyError): except (exc.QubesException, KeyError):
# the VM might have vanished in the meantime or # the VM might have vanished in the meantime or
# the signal might have been handled in the wrong order # the signal might have been handled in the wrong order
@ -557,11 +566,11 @@ class VmManagerWindow(ui_qubemanager.Ui_VmManagerWindow, QtGui.QMainWindow):
if getattr(row.vm, 'template', None) == vm: if getattr(row.vm, 'template', None) == vm:
row.info_widget.update_vm_state() row.info_widget.update_vm_state()
def on_domain_changed(self, vm, _event, **_kwargs): def on_domain_changed(self, vm, event, **_kwargs):
if not vm: # change of global properties occured if not vm: # change of global properties occured
return return
try: try:
self.vms_in_table[vm.qid].update() self.vms_in_table[vm.qid].update(event=event)
except exc.QubesPropertyAccessError: except exc.QubesPropertyAccessError:
return # the VM was deleted before its status could be updated return # the VM was deleted before its status could be updated