From 3f7f5a9da3799b0343c102b66b7fb6271eb21bec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marta=20Marczykowska-G=C3=B3recka?=
 <marta.maria.gorecka@gmail.com>
Date: Thu, 9 Nov 2017 16:11:03 +0100
Subject: [PATCH] Firewall GUI fix

Fixed error when service would be left empty, but the settings window
would nonetheless emit an error.
---
 qubesmanager/firewall.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qubesmanager/firewall.py b/qubesmanager/firewall.py
index 6992afa..d7b411a 100644
--- a/qubesmanager/firewall.py
+++ b/qubesmanager/firewall.py
@@ -386,7 +386,7 @@ class QubesFirewallRulesModel(QtCore.QAbstractItemModel):
                         self.tr("Invalid port or service"),
                         self.tr("Port number or service '{0}' is invalid.")
                                         .format(service))
-            elif service is not None:
+            elif service is not None and service != "":
                 try:
                     rule.dstports = service
                 except (TypeError, ValueError) as ex: