Qubes/manager
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix for bug in VM Settings

Browse Source 
Adding a nonexisting service will no longer add "any" service.
This commit is contained in:
Marta Marczykowska-Górecka 2018-05-17 19:56:28 +02:00
parent 031ad02ff6
commit 455fea7d37
No known key found for this signature in database
GPG Key ID: 9A752C30B26FD04B
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
qubesmanager/firewall.py
View File

@ -373,6 +373,7 @@ class QubesFirewallRulesModel(QtCore.QAbstractItemModel):
except ValueError:
QtGui.QMessageBox.warning(None, self.tr("Invalid address"),
self.tr("Address '{0}' is invalid.").format(address))
return
if dialog.tcp_radio.isChecked():
rule.proto = 'tcp'
@ -388,6 +389,7 @@ class QubesFirewallRulesModel(QtCore.QAbstractItemModel):
self.tr("Invalid port or service"),
self.tr("Port number or service '{0}' is invalid.")
.format(service))
return
elif service:
try:
rule.dstports = service
@ -399,6 +401,7 @@ class QubesFirewallRulesModel(QtCore.QAbstractItemModel):
self.tr("Invalid port or service"),
self.tr("Port number or service '{0}' is invalid.")
.format(service))
return
if row is not None:
self.set_child(row, rule)