Qubes/manager
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed unused variables

Browse Source 
When possible removed, otherwise renamed to start with an underscore.
This commit is contained in:
Marta Marczykowska-Górecka 2017-11-09 16:26:05 +01:00
parent 3f7f5a9da3
commit 695303f16a
No known key found for this signature in database
GPG Key ID: 9A752C30B26FD04B
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qubesmanager/appmenu_select.py
View File

@ -33,7 +33,7 @@ class AppListWidgetItem(PyQt4.QtGui.QListWidgetItem):
@classmethod @classmethod
def from_line(cls, line): def from_line(cls, line):
ident, icon_name, name = line.strip().split(maxsplit=2) ident, _icon_name, name = line.strip().split(maxsplit=2)
return cls(name=name, ident=ident) return cls(name=name, ident=ident)

2
qubesmanager/firewall.py
View File

@ -389,7 +389,7 @@ class QubesFirewallRulesModel(QtCore.QAbstractItemModel):
elif service is not None and service != "": elif service is not None and service != "":
try: try:
rule.dstports = service rule.dstports = service
except (TypeError, ValueError) as ex: except (TypeError, ValueError):
if self.get_service_port(service) is not None: if self.get_service_port(service) is not None:
rule.dstports = self.get_service_port(service) rule.dstports = self.get_service_port(service)
else: else:

2
qubesmanager/settings.py
View File

@ -106,7 +106,7 @@ class VMSettingsWindow(ui_settingsdlg.Ui_SettingsDialog, QtGui.QDialog):
model.set_vm(vm) model.set_vm(vm)
self.set_fw_model(model) self.set_fw_model(model)
self.firewall_modified_outside_label.setVisible(False) self.firewall_modified_outside_label.setVisible(False)
except firewall.FirewallModifiedOutsideError as ex: except firewall.FirewallModifiedOutsideError:
self.disable_all_fw_conf() self.disable_all_fw_conf()
self.new_rule_button.clicked.connect(self.new_rule_button_pressed) self.new_rule_button.clicked.connect(self.new_rule_button_pressed)

2
qubesmanager/utils.py
View File

@ -150,7 +150,7 @@ def get_path_from_vm(vm, service_name):
if not vm: if not vm:
return None return None
stdout, stderr = vm.run_service_for_stdio(service_name) stdout, _stderr = vm.run_service_for_stdio(service_name)
untrusted_path = stdout.decode(encoding='ascii')[:path_max_len] untrusted_path = stdout.decode(encoding='ascii')[:path_max_len]