Qubes/manager
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix race condition in get_selected_vm

Browse Source 
Reported-by: Hakisho Nukama <nukama@gmail.com>
This commit is contained in:
Marek Marczykowski 2013-02-06 14:57:09 +01:00
parent d5b3cd67ef
commit 950fe9253c
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
qubesmanager/main.py
View File

@ -1171,7 +1171,11 @@ class VmManagerWindow(Ui_VmManagerWindow, QMainWindow):
#vm selection relies on the VmInfo widget's value used for sorting by VM name #vm selection relies on the VmInfo widget's value used for sorting by VM name
row_index = self.table.currentRow() row_index = self.table.currentRow()
if row_index != -1: if row_index != -1:
qid = self.table.item(row_index, self.columns_indices["Name"]).qid vm_item = self.table.item(row_index, self.columns_indices["Name"])
# here is possible race with update_table timer so check if really got the item
if vm_item is None:
return None
qid = vm_item.qid
assert self.vms_in_table[qid] is not None assert self.vms_in_table[qid] is not None
vm = self.vms_in_table[qid].vm vm = self.vms_in_table[qid].vm
return vm return vm