From 9aeacce9c5fe8d4aba2e1cf6a45c384c582b6c71 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marta=20Marczykowska-G=C3=B3recka?= Date: Thu, 19 Sep 2019 01:27:34 +0200 Subject: [PATCH 1/2] Qube Manager now reacts to changing some global properties Properties checked are: default_netvm and default_dispvm. Qube Manager will now properly update displayed values. fixes QubesOS/qubes-issues#5328 --- qubesmanager/qube_manager.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/qubesmanager/qube_manager.py b/qubesmanager/qube_manager.py index cf146ea..a972778 100644 --- a/qubesmanager/qube_manager.py +++ b/qubesmanager/qube_manager.py @@ -617,7 +617,14 @@ class VmManagerWindow(ui_qubemanager.Ui_VmManagerWindow, QtWidgets.QMainWindow): def on_domain_changed(self, vm, event, **_kwargs): if not vm: # change of global properties occured + if event.endswith(':default_netvm'): + for vm_row in self.vms_in_table.values(): + vm_row.update(event='property-set:netvm') + if event.endswith(':default_dispvm'): + for vm_row in self.vms_in_table.values(): + vm_row.update(event='property-set:default_dispvm') return + try: self.vms_in_table[vm.qid].update(event=event) except exc.QubesPropertyAccessError: From 2d644c371f07808462b8ef970b8758da293de8ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marta=20Marczykowska-G=C3=B3recka?= Date: Thu, 19 Sep 2019 01:29:14 +0200 Subject: [PATCH 2/2] Improved display of default disposable VM in Qube Manager Now 'default' value will be correctly shown as default (vm name). --- qubesmanager/qube_manager.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qubesmanager/qube_manager.py b/qubesmanager/qube_manager.py index a972778..eec3b5d 100644 --- a/qubesmanager/qube_manager.py +++ b/qubesmanager/qube_manager.py @@ -133,7 +133,7 @@ class VmRowInTable: 'Last backup'], self.last_backup_widget) self.dvm_template_widget = table_widgets.VMPropertyItem( - vm, "default_dispvm") + vm, "default_dispvm", check_default=True) table.setItem(row_no, VmManagerWindow.columns_indices['Default DispVM'], self.dvm_template_widget)