Qubes/manager
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed no-self-use error

Browse Source 
Turned methods into static methods when possible.
This commit is contained in:
Marta Marczykowska-Górecka 2017-11-09 16:34:09 +01:00
parent 695303f16a
commit b7060e76b2
No known key found for this signature in database
GPG Key ID: 9A752C30B26FD04B
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
qubesmanager/firewall.py
View File

@ -35,6 +35,7 @@ class QIPAddressValidator(QtGui.QValidator):
super(QIPAddressValidator, self).__init__(parent) super(QIPAddressValidator, self).__init__(parent)
def validate(self, input, pos): def validate(self, input, pos):
# pylint: disable=too-many-return-statements,no-self-use
hostname = str(input) hostname = str(input)
if len(hostname) > 255 or len(hostname) == 0: if len(hostname) > 255 or len(hostname) == 0:
@ -212,7 +213,8 @@ class QubesFirewallRulesModel(QtCore.QAbstractItemModel):
return str(rule.proto) return str(rule.proto)
return "unknown" return "unknown"
def get_firewall_conf(self, vm): @staticmethod
def get_firewall_conf(vm):
conf = { conf = {
'allow': None, 'allow': None,
'expire': 0, 'expire': 0,
@ -276,7 +278,8 @@ class QubesFirewallRulesModel(QtCore.QAbstractItemModel):
return conf return conf
def write_firewall_conf(self, vm, conf): @staticmethod
def write_firewall_conf(vm, conf):
rules = [] rules = []
for rule in conf['rules']: for rule in conf['rules']:
@ -409,7 +412,7 @@ class QubesFirewallRulesModel(QtCore.QAbstractItemModel):
return self.createIndex(row, column, self.children[row]) return self.createIndex(row, column, self.children[row])
def parent(self, child): # pylint: disable=unused-argument def parent(self, child): # pylint: disable=unused-argument,no-self-use
return QtCore.QModelIndex() return QtCore.QModelIndex()
# pylint: disable=invalid-name,unused-argument # pylint: disable=invalid-name,unused-argument
@ -420,7 +423,7 @@ class QubesFirewallRulesModel(QtCore.QAbstractItemModel):
def columnCount(self, parent=QtCore.QModelIndex()): def columnCount(self, parent=QtCore.QModelIndex()):
return len(self.__column_names) return len(self.__column_names)
# pylint: disable=invalid-name # pylint: disable=invalid-name,no-self-use
def hasChildren(self, index=QtCore.QModelIndex()): def hasChildren(self, index=QtCore.QModelIndex()):
parent_item = index.internalPointer() parent_item = index.internalPointer()
if parent_item is not None: if parent_item is not None: