Sfoglia il codice sorgente

Fix error on reverting Qube Manager to an older version

In rare case (when the Qube Manager was reverted to an older version
that does not have a column on which it was last sorted) downgrading
Qube Manager could result in a crash on start.
Marta Marczykowska-Górecka 5 anni fa
parent
commit
d2ad60edd2
1 ha cambiato i file con 10 aggiunte e 2 eliminazioni
  1. 10 2
      qubesmanager/qube_manager.py

+ 10 - 2
qubesmanager/qube_manager.py

@@ -608,8 +608,16 @@ class VmManagerWindow(ui_qubemanager.Ui_VmManagerWindow, QtGui.QMainWindow):
         self.sort_order = QtCore.Qt.SortOrder(
             self.manager_settings.value("view/sort_order",
                                         defaultValue=self.sort_order))
-        self.table.sortItems(self.columns_indices[self.sort_by_column],
-                             self.sort_order)
+
+        try:
+            self.table.sortItems(self.columns_indices[self.sort_by_column],
+                                 self.sort_order)
+        except KeyError:
+            # the manager was sorted on a column that does not exist in the
+            # current version; possible only with downgrades
+            self.table.sortItems(self.columns_indices["Name"],
+                                 self.sort_order)
+
         if not self.manager_settings.value("view/menubar_visible",
                                            defaultValue=True):
             self.action_menubar.setChecked(False)