Qubes/manager
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix pylint warnings and errors

Browse Source
This commit is contained in:
donoban 2018-10-21 22:38:41 +02:00
parent a7537a323a
commit df15c4e3ae
No known key found for this signature in database
GPG Key ID: 141310D8E3ED08A5
1 changed files with 18 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
qubesmanager/settings.py
View File

@ -122,12 +122,12 @@ class RefreshAppsVMThread(QtCore.QThread):
# pylint: disable=too-many-instance-attributes # pylint: disable=too-many-instance-attributes
class VMSettingsWindow(ui_settingsdlg.Ui_SettingsDialog, QtGui.QDialog): class VMSettingsWindow(ui_settingsdlg.Ui_SettingsDialog, QtGui.QDialog):
tabs_indices = collections.OrderedDict(( tabs_indices = collections.OrderedDict((
('basic', 0), ('basic', 0),
('advanced', 1), ('advanced', 1),
('firewall', 2), ('firewall', 2),
('devices', 3), ('devices', 3),
('applications', 4), ('applications', 4),
('services', 5), ('services', 5),
)) ))
def __init__(self, vm, qapp, init_page="basic", parent=None): def __init__(self, vm, qapp, init_page="basic", parent=None):
@ -261,8 +261,8 @@ class VMSettingsWindow(ui_settingsdlg.Ui_SettingsDialog, QtGui.QDialog):
if error: if error:
QtGui.QMessageBox.warning( QtGui.QMessageBox.warning(
self, self,
self.tr("Error while changing settings for {0}!" self.tr("Error while changing settings for {0}!"\
).format(self.vm.name), ).format(self.vm.name),\
self.tr("ERROR: {0}").format('\n'.join(error))) self.tr("ERROR: {0}").format('\n'.join(error)))
def apply(self): def apply(self):
@ -331,18 +331,17 @@ class VMSettingsWindow(ui_settingsdlg.Ui_SettingsDialog, QtGui.QDialog):
'please enable networking.') 'please enable networking.')
) )
if netvm is not None and \ if netvm is not None and \
not netvm.features.check_with_template( not netvm.features.check_with_template(\
'qubes-firewall', 'qubes-firewall', False):
False):
QtGui.QMessageBox.warning( QtGui.QMessageBox.warning(
self, self,
self.tr("Qube configuration problem!"), self.tr("Qube configuration problem!"),
self.tr("The '{vm}' qube is network connected to " self.tr("The '{vm}' qube is network connected to "\
"'{netvm}', which does not support firewall!<br/>" "'{netvm}', which does not support firewall!<br/>"\
"You may edit the '{vm}' qube firewall rules, but " "You may edit the '{vm}' qube firewall rules, but "\
"these will not take any effect until you connect it " "these will not take any effect until you connect it "\
"to a working Firewall qube.").format( "to a working Firewall qube.").format(\
vm=self.vm.name, netvm=netvm.name)) vm=self.vm.name, netvm=netvm.name))
def current_tab_changed(self, idx): def current_tab_changed(self, idx):
if idx == self.tabs_indices["firewall"]: if idx == self.tabs_indices["firewall"]:
@ -766,8 +765,8 @@ class VMSettingsWindow(ui_settingsdlg.Ui_SettingsDialog, QtGui.QDialog):
self.virt_mode.clear() self.virt_mode.clear()
# pylint: disable=attribute-defined-outside-init # pylint: disable=attribute-defined-outside-init
self.virt_mode_list, self.virt_mode_idx = utils.prepare_choice( self.virt_mode_list, self.virt_mode_idx = utils.prepare_choice(\
self.virt_mode, self.vm, 'virt_mode', choices, None, self.virt_mode, self.vm, 'virt_mode', choices, None,\
allow_default=True, transform=(lambda x: str(x).upper())) allow_default=True, transform=(lambda x: str(x).upper()))
if old_mode is not None: if old_mode is not None: