From eeac042662e477d96f8025a5c18bd0a11fe4d172 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marta=20Marczykowska-G=C3=B3recka?=
 <marta.maria.gorecka@gmail.com>
Date: Fri, 17 Nov 2017 19:12:06 +0100
Subject: [PATCH] Fixed bug with firewall GUI settings

Fixed bug that led to correct firewall configuration not being
recognized by GUI VM Settings.

fixes QubesOS/qubes-issues#3289
---
 qubesmanager/firewall.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qubesmanager/firewall.py b/qubesmanager/firewall.py
index d8a3d1c..14b69dc 100644
--- a/qubesmanager/firewall.py
+++ b/qubesmanager/firewall.py
@@ -244,7 +244,7 @@ class QubesFirewallRulesModel(QtCore.QAbstractItemModel):
                 allow_dns = True
                 continue
 
-            if rule.proto == icmp_rule:
+            if rule == icmp_rule:
                 allow_icmp = True
                 continue