Qubes/manager
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1,686 Commits 1 Branch 0 Tags 4.4 MiB
master
Commit Graph

1247 Commits

Author SHA1 Message Date
donoban
bb1995af2e
Migration to View/Model design (#195) 
Squashed commit of the following:

commit 7929b8f0f6ec21ae0fb90203205e4224ce5bc1b7
Author: donoban <donoban@riseup.net>
Date:   Tue Jul 28 17:21:11 2020 +0200

    Try to fix sort

commit 5e4598e1d6aba0e2208e7bca761be83931457a26
Author: donoban <donoban@riseup.net>
Date:   Mon Jul 27 04:06:37 2020 +0200

    Fix import

commit 60f53e7ef0e35fde9143835b18015db570739544
Author: donoban <donoban@riseup.net>
Date:   Mon Jul 27 04:03:17 2020 +0200

    Fix 218 test

commit e430e394774bba4ca306f2fb0b8d55e10f9e2bc2
Author: donoban <donoban@riseup.net>
Date:   Mon Jul 27 04:01:56 2020 +0200

    Avoid error if dvm is None

commit 679880ff4f3d7117784e90d6cb53538b7fba4f0d
Author: donoban <donoban@riseup.net>
Date:   Mon Jul 27 03:58:59 2020 +0200

    Fix sorting again

commit f84edcdc02bf311de9d60274ae7fba90566a460e
Author: donoban <donoban@riseup.net>
Date:   Sun Jul 26 03:30:14 2020 +0200

    Yes, it's needed

commit 5d00c91db45f99c78d7f15f77dd65a51b286fc77
Author: donoban <donoban@riseup.net>
Date:   Sat Jul 25 23:08:38 2020 +0200

    Fix pylint error

commit 88a54dc3d2927a04c44e8d4c9548e123852b3e39
Author: donoban <donoban@riseup.net>
Date:   Sat Jul 25 18:56:40 2020 +0200

    Style change

commit 42ae96c45b37e03823e782c67b0995f588c7e0bd
Author: donoban <donoban@riseup.net>
Date:   Sat Jul 25 18:56:00 2020 +0200

    Fix sorting errores

commit daa872297b2082237860a66bb01e2c71fda3e55d
Author: donoban <donoban@riseup.net>
Date:   Sat Jul 25 18:54:21 2020 +0200

    Fixed sort test errors

commit 73ad25ed9e77d25bfc6a4159b8ef9a6f24e3294a
Author: donoban <donoban@riseup.net>
Date:   Sat Jul 25 00:25:37 2020 +0200

    Var rename

commit 825d8ad6f7d3a9a7bb11252ebe5a5402851d56a9
Author: donoban <donoban@riseup.net>
Date:   Fri Jul 24 23:37:04 2020 +0200

    Restored Cleanup

commit 09f183946d23fb4a92e428395834ef3ad4473ffb
Author: donoban <donoban@riseup.net>
Date:   Fri Jul 24 23:35:20 2020 +0200

    Removed workaround, now works properly without clear reason

commit 2f5bde0484e3eb0a3128e8b98f61a5311e0f529e
Author: donoban <donoban@riseup.net>
Date:   Fri Jul 24 23:29:20 2020 +0200

    Multiple tests fixes

commit e21f9ab7416e728d1ef0409fb9ca880e23d9240c
Author: donoban <donoban@riseup.net>
Date:   Fri Jul 24 23:28:32 2020 +0200

    Save dvm name instead VM object

commit 46e2fe1cf68708fa41df59661d11691ddb331984
Author: donoban <donoban@riseup.net>
Date:   Fri Jul 24 01:11:15 2020 +0200

    Deleted wrong mapToSource()

commit b155e051beb4ffcf0c1d48c5c9e24576c7db2e94
Author: donoban <donoban@riseup.net>
Date:   Fri Jul 24 01:10:43 2020 +0200

    Fix get 'Is DVM Template' widget

commit 61d7a6dc05f39055cbfd473c2a5cd638194aa132
Author: donoban <donoban@riseup.net>
Date:   Wed Jul 22 12:17:10 2020 +0200

    fix set_keyboar_layout test fail

commit 1dba52eb14b1d9c190d3a8c7bedf026ba242ac7d
Author: donoban <donoban@riseup.net>
Date:   Sun Jul 19 00:05:53 2020 +0200

    More test fixes

commit 665a1453eca121a3c60975fe4c9e08b05e4831fe
Author: donoban <donoban@riseup.net>
Date:   Sun Jul 12 23:39:07 2020 +0200

    Fixed power state checking

commit 6733fb1cd80cbc0917a5d1e42680d5424364649d
Author: donoban <donoban@riseup.net>
Date:   Sun Jul 12 17:44:01 2020 +0200

    Return vm object instead name on select_vm functions

commit 80f3b3f7498c8c98517ae77053861861aaecfba7
Author: donoban <donoban@riseup.net>
Date:   Sun Jul 12 17:43:27 2020 +0200

    Removed wrong calls to text()

commit 32bbb864bf96ad3e37b6aaddc25817a5ad38a0cc
Author: donoban <donoban@riseup.net>
Date:   Sun Jul 12 17:42:45 2020 +0200

    Removed implicity calls to sortItems()

commit bc288b616b80a5fabe179954eb18953ee59c18bc
Author: donoban <donoban@riseup.net>
Date:   Sun Jul 12 17:03:22 2020 +0200

    setCurrentItem() -> setCurrentIndex()

commit 10bac8d300aa5d428080a0dc6a689e88230d93d2
Author: donoban <donoban@riseup.net>
Date:   Sun Jul 12 16:43:41 2020 +0200

    get_table_vminfo renamed to get_table_vm

commit cee7b0af871183e4917fdb535bbcc83facd64446
Author: donoban <donoban@riseup.net>
Date:   Sat Jul 11 23:46:41 2020 +0200

    First version fixing tests

commit 42d566f032941679608669d1ccc28a4523715b8a
Author: donoban <donoban@riseup.net>
Date:   Sat Jul 11 23:38:33 2020 +0200

    Fixing tests

commit ccd7c162ef2a3f882c7d683d5b9c97db11829ac6
Merge: 24e5d58 8a74e43
Author: donoban <donoban@riseup.net>
Date:   Mon Jun 8 22:16:34 2020 +0200

    Merge branch 'master' of https://github.com/QubesOS/qubes-manager

    # Conflicts:
    #	qubesmanager/qube_manager.py

commit 24e5d58c98981b3635b3c6dfa9202cac3e3455d8
Author: donoban <donoban@riseup.net>
Date:   Sun Jun 7 19:03:09 2020 +0200

    Added workaround for dom0 sorting

commit db2781a6392ff32c2d26053999819e08cb0e0ca0
Author: donoban <donoban@riseup.net>
Date:   Sun Jun 7 18:57:28 2020 +0200

    Fixed Sorting Case Insensivity

commit 93330ea6a45598a212811251843d32682a20016a
Author: donoban <donoban@riseup.net>
Date:   Sun Jun 7 18:51:39 2020 +0200

    Added "default" to netvm and default dispvm

commit a40156c4f4b08a201fb877fc92f547c5138a7e32
Author: donoban <donoban@riseup.net>
Date:   Sun Jun 7 18:18:03 2020 +0200

    Fixed QSettings saving

commit a1d96e78778c84fe077b62196c8ed561978de9bc
Author: donoban <donoban@riseup.net>
Date:   Wed Jun 3 00:23:50 2020 +0200

    Added 'defaultValue' on settings load

commit a0a7ee812298e6361a2ee585049c96303d1bbda7
Author: donoban <donoban@riseup.net>
Date:   Wed Jun 3 00:10:31 2020 +0200

    Init view menu out of load_manager_settings

commit 6f9a60004282e85c32727baa4b49c0a4d080f74e
Author: donoban <donoban@riseup.net>
Date:   Tue Jun 2 23:19:09 2020 +0200

    "Size" renamed to "Disk Usage"

commit 5fbda06b370de790e31a9a983891a69ab8d031de
Author: donoban <donoban@riseup.net>
Date:   Tue Jun 2 01:34:56 2020 +0200

    Replaced unneded elif's with if's

commit 5516bca8616d2e1ab99d4c40b11ff7b69cdbea48
Author: donoban <donoban@riseup.net>
Date:   Tue Jun 2 01:30:46 2020 +0200

    Use "Yes"/"" for bool properties

commit 1e5429e7ef9240570a5f31eae3a49a8380f97ee4
Author: donoban <donoban@riseup.net>
Date:   Tue Jun 2 01:12:46 2020 +0200

    Restored exactly old icon size

commit 270c82547365fbecddab1a21afef637da3eb2aa6
Author: donoban <donoban@riseup.net>
Date:   Sun May 31 12:52:03 2020 +0200

    AdminVM and DispVM icon workaround

commit cfb8a87b6dbdfda6f1652a6a4c82299e60b8c158
Author: donoban <donoban@riseup.net>
Date:   Sun May 31 12:51:44 2020 +0200

    Icon size adjusted to 128/4

commit 173dc9413c6ae81e851026538beb101e385e5974
Author: donoban <donoban@riseup.net>
Date:   Sat May 30 00:56:40 2020 +0200

    Add italic and gray color for differentiate templates and standalone/dom0

commit 2062f9308833241994b3ba87964f4f871b115e2a
Author: donoban <donoban@riseup.net>
Date:   Thu May 28 00:21:58 2020 +0200

    Fixig Marek comments

commit 348485e960d18c5d7fd1746448251374480d270b
Author: donoban <donoban@riseup.net>
Date:   Thu May 28 00:03:44 2020 +0200

    More readable

commit dc823a3923ab6c110fa8c51d4d66e501bc3e9f97
Author: donoban <donoban@riseup.net>
Date:   Thu May 28 00:01:02 2020 +0200

    Needed for pylint proplerly import PyQt5 modules on fedora 32

commit 4478b284ce6f4521d1bddd5f6dc3d564c6c02408
Author: donoban <donoban@riseup.net>
Date:   Tue May 19 01:11:05 2020 +0200

    Removed unused unued vars

commit 450f0e32525792d48f121edfb890f0f24e6f6c36
Author: donoban <donoban@riseup.net>
Date:   Fri May 8 00:26:59 2020 +0200

    Fix wrong var names

commit c1bd9577e21e79a708870bbd22ff557ec0f48547
Author: donoban <donoban@riseup.net>
Date:   Fri May 8 00:24:31 2020 +0200

    Fixed params order to VmSettingsWindow()

commit 6d50d033d5866aa9cd0913822189bf235c8c7bdd
Author: donoban <donoban@riseup.net>
Date:   Fri May 8 00:20:06 2020 +0200

    Modeless settings windows

commit ef3ac6a962b09e34602a624b3e8fdbdaf4cf8a42
Author: donoban <donoban@riseup.net>
Date:   Thu May 7 23:51:30 2020 +0200

    Fix some vm/vm_info confusion

commit 09392f99dc1ecd2e96e756884dd75c22090aa127
Author: donoban <donoban@riseup.net>
Date:   Wed Apr 29 10:26:58 2020 +0200

    removed trailing whitespace

commit 9e35ddf882053b25e2ab1d6cce6393cb77b95e79
Author: donoban <donoban@riseup.net>
Date:   Wed Apr 29 00:50:27 2020 +0200

    columns_indices redudancy fixed and menu_view auto generation

commit 8d96ef46d7f1eb0f26cf8d92203a22890c6165c0
Author: donoban <donoban@riseup.net>
Date:   Sat Apr 25 00:29:53 2020 +0200

    Use col_name instead col number, improves readiblity

commit 1cae3cab93d31592819941eee16ed239805d9cc8
Author: donoban <donoban@riseup.net>
Date:   Fri Apr 24 00:52:12 2020 +0200

    Add QubesNoSuchProperyError

commit aed771d4eb3b6b16652ec1ae27abb0761ebe2fa9
Author: donoban <donoban@riseup.net>
Date:   Fri Apr 24 00:45:59 2020 +0200

    Added missing virt_mode

commit 580749b83376204880da7be93d6325c6cdc0c239
Merge: 70878dc b058db4
Author: donoban <donoban@riseup.net>
Date:   Fri Apr 24 00:16:48 2020 +0200

    Merge branch 'master' of https://github.com/QubesOS/qubes-manager

commit 70878dc647cf34f716cfe0f4753f41cd1487a45e
Author: donoban <donoban@riseup.net>
Date:   Fri Apr 24 00:16:31 2020 +0200

    Let's try travis

commit 5f65477abdb304413c3d3800d6e109c51275e13a
Author: donoban <donoban@riseup.net>
Date:   Fri Apr 24 00:11:37 2020 +0200

    Fix ProgressDialog not being properly drawn

commit b577cb91d908e065ba43e68c613ff0eca449bbd7
Author: donoban <donoban@riseup.net>
Date:   Sun Apr 12 23:44:27 2020 +0200

    pylint fixes and wrong 'outdated'

commit 2a55c5d65b0cb3f7bb9d4adb10f5e41f662a85fe
Author: donoban <donoban@riseup.net>
Date:   Sun Apr 12 23:35:47 2020 +0200

    Restored menubar and toolbar context menu

commit ac7086011328f1ef8f94a838425f8fe872b4fd20
Author: donoban <donoban@riseup.net>
Date:   Sun Apr 12 23:28:02 2020 +0200

    restored logs

commit a0b2b7be3cb6bf2693644289a9ae0452ce330cb5
Author: donoban <donoban@riseup.net>
Date:   Sun Apr 12 23:16:03 2020 +0200

    Removed unused attributes

commit cb514949f55e50925e1eabb19c8303e914c20d17
Author: donoban <donoban@riseup.net>
Date:   Sun Apr 12 23:08:00 2020 +0200

    Part of last commit...

commit 7f0c42fb9a9622d33f5281f8134c7f669a1ae7a4
Author: donoban <donoban@riseup.net>
Date:   Sun Apr 12 23:07:20 2020 +0200

    Save sort settings on closeEvent

commit 8dcfc3c9a9467e512b6c58e8b0a53c727bce7e89
Author: donoban <donoban@riseup.net>
Date:   Sun Apr 12 13:02:37 2020 +0200

    Pylint fixes

commit 8e5f9ff1d4e33d1a8d97842a696ba45ec40c7103
Author: donoban <donoban@riseup.net>
Date:   Mon Apr 6 23:35:15 2020 +0200

    State converted to dict making pylint happier

commit 233ec124736d09f0a64f65ce2d7e19383942e73a
Author: donoban <donoban@riseup.net>
Date:   Mon Apr 6 00:25:34 2020 +0200

    Pylint fixes

commit 37790f01e3755dccbb6da24b3170320fcf2b2fe9
Author: donoban <donoban@riseup.net>
Date:   Sun Apr 5 23:47:17 2020 +0200

    pylint

commit 7dbe393047a00e4d5914368f8dad3c23d5a69586
Author: donoban <donoban@riseup.net>
Date:   Sun Apr 5 23:41:12 2020 +0200

    pylint fixes

commit f79f096ce3307167256308ce44ef8d3cf5f9a824
Author: donoban <donoban@riseup.net>
Date:   Sun Apr 5 23:37:03 2020 +0200

    fixed wrong info_by_id refrences

commit dbf17bde761a6efc03ff29b87e65623a214a44d2
Author: donoban <donoban@riseup.net>
Date:   Sun Apr 5 17:46:31 2020 +0200

    Added QubesCache

    QubesTableModel and main app should operate directly to the cache

commit 42d124520f7910f2ba0e77531fa6f469dd1932e5
Author: donoban <donoban@riseup.net>
Date:   Sun Apr 5 13:50:00 2020 +0200

    Fixing multiple pylint warnings

commit c708b4293035d8d296680b8a7513a066eb475f2b
Author: donoban <donoban@riseup.net>
Date:   Sun Apr 5 12:59:43 2020 +0200

    Added action_open_console setEnabled

commit de1499464d47f145d10250619f83f8dfec2861b5
Author: donoban <donoban@riseup.net>
Date:   Fri Apr 3 00:25:07 2020 +0200

    Forgot context_menu.actions()

commit d24903b2462e416c5148036ed1184b90b02bd8b0
Author: donoban <donoban@riseup.net>
Date:   Fri Apr 3 00:03:16 2020 +0200

    Elegant alternative for _enable_all()

commit a0603870a3bbb78128d4cb23e259d3d00449b94c
Author: donoban <donoban@riseup.net>
Date:   Thu Apr 2 00:22:46 2020 +0200

    Fixed outdate

commit 36e4b310080738bd9d8f9c92a16ad012735eb01a
Author: donoban <donoban@riseup.net>
Date:   Wed Apr 1 11:36:28 2020 +0200

    Removed table_widgets.py dependency

commit 72e679e2d17e663b64213c23530e14cd6f6f843c
Author: donoban <donoban@riseup.net>
Date:   Wed Apr 1 00:55:10 2020 +0200

    Fixed pylint warnings

commit 8e118be165d0ec77d9415cb90ef32c8b73c57612
Author: donoban <donoban@riseup.net>
Date:   Wed Apr 1 00:26:14 2020 +0200

    Added get_selected_vms() and UserRole + 1

commit fd12a95280c5296a92a04bf3dbdb8487c8190729
Author: donoban <donoban@riseup.net>
Date:   Tue Mar 31 01:10:51 2020 +0200

    fix some pylint warnings

commit 09dfe83d89a14ba4a3745ec86ee59ad89ac153ae
Author: donoban <donoban@riseup.net>
Date:   Tue Mar 31 00:34:51 2020 +0200

    Removed unneded margins

commit f0c81bf5a93f51c95b6afb01744f14a387dd4610
Merge: 00876bc f1ad829
Author: donoban <donoban@riseup.net>
Date:   Tue Mar 31 00:33:53 2020 +0200

    Merge branch 'master' of https://github.com/QubesOS/qubes-manager

commit 00876bcbfc7b70cd51848938ceb9f8f969848698
Author: donoban <donoban@riseup.net>
Date:   Mon Mar 30 23:31:18 2020 +0200

    Alternative pyqt imports

    After reading official pyqt doc this seems the standard way
    (Continue previous commit)

commit 6cf09d319021ab7b6491347c579f2911fbcb4e05
Author: donoban <donoban@riseup.net>
Date:   Mon Mar 30 23:29:21 2020 +0200

    Alternative pyqt imports

    After reading official pyqt doc this seems the standard way

commit 410dbaefca27fe3be85fc306db6afc04292f8f6f
Author: donoban <donoban@riseup.net>
Date:   Mon Mar 30 00:12:09 2020 +0200

    Restored sorting and filtering using QSortFilterProxyModel()

commit 0b7fd6e7301009ebab702933b1114254ee5b6a93
Author: donoban <donoban@riseup.net>
Date:   Tue Mar 24 12:46:18 2020 +0100

    Added QSortFilterProyModel

    indexes need proxy.mapToSource(index)

    model.layoutChanged.emit(), replaced by proxy.invalidate()

commit 97440e8a616b84e49e446dc11576a987dae33da2
Author: donoban <donoban@riseup.net>
Date:   Tue Mar 24 12:34:35 2020 +0100

    Removed unneded calls to setContentsMargins

commit 1ad2aaac2cdfa4c7fc4323a3cf82220340de462f
Author: donoban <donoban@riseup.net>
Date:   Sun Mar 22 22:56:33 2020 +0100

    fix removevm with multiselection

commit 19be1da69f3f43b1a9a4d9c5c561d4a6c9004d0c
Author: donoban <donoban@riseup.net>
Date:   Sun Mar 22 22:34:52 2020 +0100

    Restored context menu

commit f43394a446ecb23b36fda029f62f2a0633ee01b6
Author: donoban <donoban@riseup.net>
Date:   Sun Mar 22 00:08:43 2020 +0100

    Deleted unedeed updates after change of settings

commit c98ba627579871b302563f42678ac412e9ccdd48
Merge: 103c572 cf3f102
Author: donoban <donoban@riseup.net>
Date:   Sat Mar 21 23:45:46 2020 +0100

    Merge branch 'master' of https://github.com/QubesOS/qubes-manager

commit 103c5721d3f9f9c1ef6e922aeba053a2eb69b332
Merge: 2756864 da2826d
Author: donoban <donoban@riseup.net>
Date:   Sat Feb 29 16:40:22 2020 +0100

    Merge branch 'master' of https://github.com/QubesOS/qubes-manager

commit 2756864bd04b1b16cf819fb4e726fff40189c8f3
Merge: 2e2a14b 8902727
Author: donoban <donoban@riseup.net>
Date:   Thu Jan 23 23:43:32 2020 +0100

    Merge branch 'master' of https://github.com/QubesOS/qubes-manager

commit 2e2a14bdcaf8f6e7ce2f8fcec944109f18aad27f
Author: donoban <donoban@riseup.net>
Date:   Wed Jan 8 16:41:30 2020 +0100

    Removed fill_table :)

commit 9f3f61a5d0c6c11e9eca81bbedcfe7affa187148
Author: donoban <donoban@riseup.net>
Date:   Tue Dec 31 17:29:39 2019 +0100

    When Template changes status, all AppVMs should update too

commit b970a703ab5bb559b6627c637466558651403f74
Author: donoban <donoban@riseup.net>
Date:   Fri Dec 27 17:59:05 2019 +0100

    Improved multi row system

commit 2f3fc988707252c2079998343de3c508ac4d9a74
Merge: 1f21da6 cca5d7d
Author: donoban <donoban@riseup.net>
Date:   Fri Dec 27 17:25:15 2019 +0100

    Merge remote-tracking branch 'upstream/master'

commit 1f21da6d48d1bdddfc75c3ab47d28e92ed221a6d
Author: donoban <donoban@riseup.net>
Date:   Mon Sep 23 21:41:39 2019 +0200

    Restored 'selection changed' with multiple row support

    It reacts to selection changes but it is missing real functionally yet.

commit bdf16015cd2a4ba894ae1d5c2c495403bb78be0d
Author: donoban <donoban@riseup.net>
Date:   Wed Sep 18 07:27:47 2019 +0200

    Restored add/remove/change events handling

commit 2f9b21f07241b43655fb579dd4130a9c72d3db42
Author: donoban <donoban@riseup.net>
Date:   Wed Sep 18 07:00:49 2019 +0200

    Added StateIconDelegate and StateInfo

    Used for paint different icons on same cell with custom tooltips.

commit ccfa5453b2fe1ca5948406126a0f32a2caf4bde0
Author: donoban <donoban@riseup.net>
Date:   Wed Sep 18 06:35:12 2019 +0200

    Removed Default and Minium horizonal header section size

    It affects resizeColumnsToContents()

commit 628073e9522af5bff83224491645addbdcfb7418
Author: donoban <donoban@riseup.net>
Date:   Sun Sep 15 10:45:36 2019 +0200

    Uncompatible with TableView

commit 52ddd56bf293ca704205824f9c3b0f25f2c8d4c4
Merge: 0a87cf9 1ced452
Author: donoban <donoban@riseup.net>
Date:   Sun Sep 15 10:43:13 2019 +0200

    Merge branch 'master' of https://github.com/QubesOS/qubes-manager

commit 0a87cf963388bc9a33d241146e642a8ce9518ddb
Author: donoban <donoban@riseup.net>
Date:   Mon Sep 2 21:55:21 2019 +0200

    Restored precises updates
    https://github.com/QubesOS/qubes-manager/pull/195#issuecomment-525795486

commit 030bf13fab31cd57c5891d6ff692faf57c500f0a
Author: donoban <donoban@riseup.net>
Date:   Sun Aug 25 18:33:11 2019 +0200

    New and dirty first Model/View version

commit 981ee9c1c3ccd6af4fe8b2745b7b5ddb29ecc0c4
Author: donoban <donoban@riseup.net>
Date:   Sun Aug 25 18:32:28 2019 +0200

    QtableWidget > QTableView

commit 41beaed24b69e7e9dc9223fa100605b0fd5bb40e
Author: donoban <donoban@riseup.net>
Date:   Sun Aug 25 18:31:59 2019 +0200

    Removed table_widgets
 2020-07-30 02:42:12 +02:00
Marta Marczykowska-Górecka
29ce349be0
Fix incorrect Settings invocation in Qube Manager 
fixes QubesOS/qubes-issues#5963
 2020-07-28 19:22:08 +02:00
William Dizon
a1896ac389
fixed misspelling in dialog box of success 2020-07-21 13:49:30 -07:00
Marek Marczykowski-Górecki
db0e81a975
Merge remote-tracking branch 'origin/pr/248' 
* origin/pr/248:
  Added more description to applications in VM Settings
 2020-07-15 18:34:42 +02:00
Marek Marczykowski-Górecki
5322cfd1e3
Merge remote-tracking branch 'origin/pr/247' 
* origin/pr/247:
  Fixed overzealous firewall hostname checking
 2020-07-15 18:34:21 +02:00
Marta Marczykowska-Górecka
61d15dd783
Fixed some minor defaults errors in VM settings 2020-07-14 22:53:16 +02:00
Marta Marczykowska-Górecka
03c04cc93b
Fixed deprecated implicit conversion to int 2020-07-14 22:20:54 +02:00
Marta Marczykowska-Górecka
77b42e7c5a
Final improvements and cleanup to list widgets handling in manager 
Also removed old opaque prepare_choice functions and added
extensive docstrings.
 2020-07-14 22:19:43 +02:00
Marta Marczykowska-Górecka
fabd601f49
Added more description to applications in VM Settings 
Sometimes only the .desktop filename distinguishes between applications,
so now the tooltip will list that filename
 2020-07-14 21:22:41 +02:00
Marta Marczykowska-Górecka
f8c19ca984
Fixed overzealous firewall hostname checking 
Checking is now done only on the core-admin-client side; there's
no reason to reject rules that would be valid from core-admin-client side.

fixes QubesOS/qubes-issues#5943
 2020-07-14 19:57:34 +02:00
Marta Marczykowska-Górecka
2ae92dffc0
Refactored Create New VM for more readability 2020-07-09 21:38:23 +02:00
Marta Marczykowska-Górecka
f0a8241e0d
Refactored VM Settings for less ugliness 2020-07-09 19:26:31 +02:00
Marta Marczykowska-Górecka
ab5e3dcfea
Improved Global Settings with more readable widget handling 2020-07-08 22:31:50 +02:00
Marta Marczykowska-Górecka
31eb6f9df7
Added GUI daemon options to global settings 
fixes QubesOS/qubes-issues#2304
 2020-07-07 21:56:37 +02:00
Marta Marczykowska-Górecka
a41908f92f
Added gui daemon options to VM settings 
Added allow-fullscreen and allow-utf8-titles as options to VM settings

references QubesOS/qubes-issues#2304
 2020-07-07 21:47:13 +02:00
Marek Marczykowski-Górecki
a6a7560bab
Merge remote-tracking branch 'origin/pr/241' 
* origin/pr/241:
  Fixed max volume size in VM settings
 2020-06-28 05:23:40 +02:00
MSathieu
e18e9ee998
Don't reset template when changing type during qube creation 2020-06-23 12:33:04 +02:00
Marta Marczykowska-Górecka
37271db3d8
Fixed max volume size in VM settings 
Now it can be anything up to pool size.

fixes QubesOS/qubes-issues#5890
 2020-06-11 22:18:05 +02:00
Marek Marczykowski-Górecki
8a74e43dc3
Merge remote-tracking branch 'origin/pr/238' 
* origin/pr/238:
  Fixed VM settings test
 2020-06-07 04:40:28 +02:00
Marta Marczykowska-Górecka
310d583b2a
Fixed VM settings test 
Incorrect maxmem value caused error.

fixes QubesOS/qubes-issues#5857
 2020-05-28 19:31:25 +02:00
Marek Marczykowski-Górecki
2b69bf5599
Merge remote-tracking branch 'origin/pr/236' 
* origin/pr/236:
  Better error handling for opening VM settings in Qube Manager
 2020-05-27 04:20:09 +02:00
Marta Marczykowska-Górecka
683d75db31
Better error handling for opening VM settings in Qube Manager 
No more silent errors - the user will get an error message.

fixes QubesOS/qubes-issues#5810
 2020-05-26 22:22:11 +02:00
Marta Marczykowska-Górecka
deb9b323f2
Applications tab in VM settings now reacts to template change and handles missing entries 
On template change, qvm-appmenus is queried for changes in available apps.
If something is whitelisted and does not appear in the template, it is shown
in the list as "Application missing".

requires https://github.com/QubesOS/qubes-desktop-linux-common/pull/22
fixes QubesOS/qubes-issues5796
 2020-05-11 17:36:53 +02:00
Marta Marczykowska-Górecka
b058db4ccf
Fixed incorrect memory checking in VM Settings 
When a VM is not included in memory balancing, there is no point
(and it can be actively harmful via deception) in showing warnings
about init_mem and maxmem mismatch.

fixes QubesOS/qubes-issues#5306
 2020-04-06 15:31:00 +02:00
Marek Marczykowski-Górecki
f1ad829d71
Merge remote-tracking branch 'origin/pr/233' 
* origin/pr/233:
  Template should not be enabled for running VMs in VM Settings
  Show correct template for DispVMs VM Settings
 2020-03-28 04:21:58 +01:00
Marta Marczykowska-Górecka
96e75b350a
Template should not be enabled for running VMs in VM Settings 2020-03-26 16:51:41 +01:00
Marta Marczykowska-Górecka
08d1435eea
Show correct template for DispVMs VM Settings 
DispVMs should have a template listed from among vms with 'template_from_dispvm'
property, not from the normal available templates.

fixes QubesOS/qubes-issues#5746
 2020-03-26 16:50:25 +01:00
Marta Marczykowska-Górecka
5c82ad5a29
Added "Open console" action to Qube Manager 
The action uses qvm-console-dispvm.

fixes QubesOS/qubes-issues#4544
 2020-03-24 17:34:14 +01:00
Marek Marczykowski-Górecki
29df599968
Merge remote-tracking branch 'origin/pr/231' 
* origin/pr/231:
  Fixed tests for new debug mode location in VM settings
  Fixed bug in tests that leads to occassional timeouts on slow machines
 2020-03-15 13:03:52 +01:00
Marta Marczykowska-Górecka
cf601fbc66
Fixed tests for new debug mode location in VM settings 2020-02-28 18:58:20 +01:00
Marta Marczykowska-Górecka
92465f71e7
Fixed bug in tests that leads to occassional timeouts on slow machines 
fixes QubesOS/qubes-issues#5694
 2020-02-27 17:28:37 +01:00
Marek Marczykowski-Górecki
84ff5ffa09
Merge remote-tracking branch 'origin/pr/230' 
* origin/pr/230:
  Removed unnecessary 'needs restarting' icons for DisposableVMs in Qube Manager
 2020-02-17 04:04:40 +01:00
Marek Marczykowski-Górecki
2520952d76
Merge remote-tracking branch 'origin/pr/227' 
* origin/pr/227:
  Changed display of image sizes in VM settings to GB when sensible
 2020-02-17 04:02:04 +01:00
Marta Marczykowska-Górecka
9acb22fb1f
Removed unnecessary 'needs restarting' icons for DisposableVMs in Qube Manager 
fixes QubesOS/qubes-issues#5661
 2020-02-16 22:38:44 +01:00
Marta Marczykowska-Górecka
bd8fc05725
Changed display of image sizes in VM settings to GB when sensible 
For sizes above 1 GB, the sizes of private image and root image will be displayed
as %.1f GB; smaller sizes will be displayed as %d MB.

fixes QubesOS/qubes-issues#5592
 2020-02-09 17:17:48 +01:00
Marta Marczykowska-Górecka
0534ec6d15
Fixed init memory warning being shown twice 
Also fixed the init memory warning to only be shown for Linux qubes (it is
not necessary for other qubes)

fixes QubesOS/qubes-issues#5612
 2020-01-30 21:46:18 +01:00
Marek Marczykowski-Górecki
20da3a5854
Merge remote-tracking branch 'origin/pr/224' 
* origin/pr/224:
  Handle deleting in VM Settings without silent fails
 2020-01-16 04:41:37 +01:00
Marek Marczykowski-Górecki
848277ae4b
Merge remote-tracking branch 'origin/pr/223' 
* origin/pr/223:
  Fixed Apply behavior for VM Settings
 2020-01-16 04:39:39 +01:00
Marek Marczykowski-Górecki
acfdca3851
Merge remote-tracking branch 'origin/pr/221' 
* origin/pr/221:
  Fixed tab order
  Moved debug mode checkbox to advanced settings
  Added handling for supported services to VM settings
 2020-01-16 04:38:08 +01:00
Marta Marczykowska-Górecka
e17332d84c
Handle deleting in VM Settings without silent fails 
Deleting qube will now show a Delete in Progress dialog box and
not exit QApplication before QThread finishes.

fixes QubesOS/qubes-issues#5515
 2020-01-08 22:04:36 +01:00
Marta Marczykowska-Górecka
f4f76110f0
Fixed Apply behavior for VM Settings 
VM Setting will now update (current) markers correctly after Apply.

fixes QubesOS/qubes-issues#5531
 2020-01-08 21:20:27 +01:00
Marta Marczykowska-Górecka
4298de6564
Moved debug mode checkbox to advanced settings 
It really had no place in Basic settings, and will free up space for future
settings.
 2019-12-14 15:39:09 +01:00
Marta Marczykowska-Górecka
5f86660305
Added handling for supported services to VM settings 
Slight change to layout of services tab, made it hopefully
less confusing. Dropdown will now list services supported by this
VM and its template, not just an assortment of hardcoded services.
 2019-12-14 15:39:09 +01:00
Marek Marczykowski-Górecki
cca5d7d785
Merge remote-tracking branch 'origin/pr/219' 
* origin/pr/219:
  Fixed transifex integration
 2019-12-09 19:29:02 +01:00
Marta Marczykowska-Górecka
0329383453
Fixed transifex integration 
Corrected .tx/config file and added instructions on pulling/pushing translations
to transifex.

references QubesOS/qubes-issues#5410
references QubesOS/qubes-issues#3548
 2019-12-09 19:19:29 +01:00
Marek Marczykowski-Górecki
52727c898d
Merge remote-tracking branch 'origin/pr/220' 
* origin/pr/220:
  Use events instead of pulling for updates-available status
  settings: wrap direct network access warning
  tests: fix startup timeout and looking for logs
 2019-12-07 05:02:28 +01:00
Marek Marczykowski-Górecki
041adcfc1e
Use events instead of pulling for updates-available status 2019-12-05 22:59:24 +01:00
Marek Marczykowski-Górecki
ffcfb4e7cf
tests: fix startup timeout and looking for logs 
On OpenQA 20 isn't enough to start a VM. Also make sure previous
shutdown has finished by using qvm-shutdown --wait.

VM needs to be started at least once to have active "logs" submenu. For
this reason, choose a running VM.
 2019-12-04 21:05:45 +01:00
Marta Marczykowska-Górecka
0a1f12fb27
Fixed bug with Global Settings 
Incorrectly named variable caused crash on start.
 2019-11-30 13:37:33 +01:00
Marta Marczykowska-Górecka
2a73bfbb4c
Fixed bug in VM Settings 
Wrong variable name caused a crash on start
 2019-11-28 15:44:54 +01:00
Marek Marczykowski-Górecki
6886585d17
Merge remote-tracking branch 'origin/pr/216' 
* origin/pr/216:
  Add handling for backup in progress
 2019-11-16 15:42:38 +01:00
Frédéric Pierret (fepitre)
4c39d7bfc2
global_settings: copy env instead of global assignment 2019-11-12 22:49:09 +01:00
Marta Marczykowska-Górecka
b27c10f1d4
Add handling for backup in progress 
Shows a better error message when a given backup is already running.

fixes QubesOS/qubes-issues#5432
requires https://github.com/QubesOS/qubes-core-admin/pull/292
 2019-11-11 17:44:53 +01:00
Frédéric Pierret (fepitre)
51acbde8d5
_run_qrexec_repo: default C local in subprocess call 2019-11-11 17:08:19 +01:00
Frédéric Pierret (fepitre)
0bacf37994
global_settings: make PEP8 happy 2019-11-11 17:05:02 +01:00
Frédéric Pierret (fepitre)
2c132d9b83
utils: make PEP8 happy 2019-11-10 10:16:47 +01:00
Frédéric Pierret (fepitre)
044d91d73e
utils: get linux-kernels from storage API 2019-11-10 10:16:08 +01:00
Marek Marczykowski-Górecki
283ed2540c
Merge remote-tracking branch 'origin/pr/210' 
* origin/pr/210:
  Fixed translation for application names
  Added translation support to all untranslated qubesmanager files
  Re-enabled translation support for Qt5
 2019-11-09 15:32:18 +01:00
Marta Marczykowska-Górecka
b4cb9303bc
Fixed translation for application names 2019-11-09 00:50:44 +01:00
Malte Leip
5ba012b7d3
Fix KernelVersion comparisons 
In the __lt__ function for the class KernelVersions, if
self.groups != other.groups, but self.groups == other.groups[0:n] or
self.groups[0:n] == other.groups for some n, then at some point, one of
the two pieces to be compared will be None, which resulted in an
Exception when calling isdigit.

Hence check whether one of the pieces to be compared is None and handle
this as a special case.

(cherry picked from commit b901203390b4994a8169021d7dc47928561dad24)
 2019-11-07 04:18:37 +01:00
Marek Marczykowski-Górecki
fe56b3e0e7
Merge remote-tracking branch 'origin/pr/211' 
* origin/pr/211:
  Fixed VM settings warning labels
 2019-10-29 13:36:31 +01:00
Marta Marczykowska-Górecka
46952ebad2
Added translation support to all untranslated qubesmanager files 
references QubesOS/qubes-issues#5410
 2019-10-29 12:28:22 +01:00
Marta Marczykowska-Górecka
520cefa010
Fixed VM settings warning labels 
No netvm warning will now show differently for VMs that don't provide
network and those that do.
 2019-10-29 11:53:44 +01:00
Marta Marczykowska-Górecka
245534d886
Re-enabled translation support for Qt5 
Fixed obsolete source files, regenerated translation sources,
re-enabled translation loading in the programs themselves.
Also removed the completely obsolete block.py file. (It was not used anywhere)

references QubesOS/qubes-issues#5410
 2019-10-29 00:49:22 +01:00
Marta Marczykowska-Górecka
afad888343
Fixed error in selecting backup directory in GUI backup 
Also removed unused settings.

fixes QubesOS/qubes-issues#5430
 2019-10-29 00:30:09 +01:00
hexagonrecursion
42affe0da6
Remove redundant popups 2019-10-27 10:22:41 +00:00
Marek Marczykowski-Górecki
7bdcb23fb8
Fix erroneous usage of 'qubes' module 
On the client side it should use only 'qubesadmin'. In practice, those
few are trivial to replace:
 - get_disk_usage() is also available in shutil (as disk_usage())
 - BackupCancelledError should be used from qubesadmin.exc anyway (there
   was also a typo)

Remove also test-packages/qubes to let pylint detect such issues in the
future.

QubesOS/qubes-issues#5403
 2019-10-24 05:47:26 +02:00
Marek Marczykowski-Górecki
1dabce0f54
Merge remote-tracking branch 'origin/pr/205' 
* origin/pr/205:
  Added better exception handling on Backup Cancel
  Tests fixed for new features and bugfixes
  Removed not needed workaround for check-updates on dom0
  Fixed default install_system state for Create New VM
  Fixed manager tests to use Qt5
 2019-10-24 03:20:28 +02:00
Marta Marczykowska-Górecka
0d2d9970b7
Added better exception handling on Backup Cancel 
Qt segfaults when the reject method throws an unhandled
exception; fixed that.
 2019-10-24 00:29:04 +02:00
Marta Marczykowska-Górecka
4c2adbca00
Tests fixed for new features and bugfixes 
After switching to Qt5, a bunch of fixes and changes were introduced.
This fixes tests to take them into account.
 2019-10-17 22:33:08 +02:00
Marta Marczykowska-Górecka
74eba3bb7f
Removed not needed workaround for check-updates on dom0 
And fixed test referring to it.
 2019-10-17 00:29:10 +02:00
Marta Marczykowska-Górecka
6f73ef2163
Fixed manager tests to use Qt5 
Also due to old workarounds not working around anymore,
switched over to "single QApplication object" model.
 2019-10-15 01:28:04 +02:00
Marta Marczykowska-Górecka
0c10723205
Fixed incorrect QApplication start that led to missing icons 
Using QIcon object before initializing QApplication leads to
missing theme icons.

fixes QubesOS/qubes-issues#5354
 2019-10-06 21:55:11 +02:00
Marek Marczykowski-Górecki
12481fd561
Merge remote-tracking branch 'origin/pr/202' 
* origin/pr/202:
  Fixed change in QFileDialog behavior in PyQt5
 2019-09-30 03:51:46 +02:00
Marek Marczykowski-Górecki
fcec3d7464
Merge remote-tracking branch 'origin/pr/200' 
* origin/pr/200:
  Pylint fixes
  Code deduplication and cleanup
  Removed unused line in GUI Backup
 2019-09-30 03:51:44 +02:00
Marta Marczykowska-Górecka
442066d96c
Fixed change in QFileDialog behavior in PyQt5 
Return type of QFileDialog changed between PyQt4 and PyQt5.

fixes QubesOS/qubes-issues#5353
 2019-09-28 22:06:29 +02:00
Saswat Padhi
4ee3c556c4
Show the previous VM name while renaming 
Currently while renaming VMs, the default text is empty "". This change modifies this default text to the original name of the VM.
 2019-09-26 18:29:31 -07:00
Marta Marczykowska-Górecka
5d88e5f851
Pylint fixes 
Several minor fixes for updated pylint checker.
 2019-09-26 22:44:05 +02:00
Marta Marczykowska-Górecka
32078242c9
Code deduplication and cleanup 
Moved loop handling, exception handling and program
running methods of the gui tools to the utils file.

fixes QubesOS/qubes-issues#5342
 2019-09-26 22:31:39 +02:00
Marta Marczykowska-Górecka
8a3653723d
Removed unused line in GUI Backup 
File selection dialog in GUI backup was using an obsolete
(and possibly never working as intented) setReadOnly method.
Removed it, because it neither works nor is needed.

fixes QubesOS/qubes-issues#5348
 2019-09-26 21:37:32 +02:00
Marek Marczykowski-Górecki
bdf0951c52
Merge remote-tracking branch 'origin/pr/198' 
* origin/pr/198:
  Fixed new firewall rule window
 2019-09-23 03:48:09 +02:00
Marek Marczykowski-Górecki
0dc73fd618
Merge remote-tracking branch 'origin/pr/196' 
* origin/pr/196:
  Added an Advanced tab to Create New Qube dialog
 2019-09-23 03:48:07 +02:00
Marta Marczykowska-Górecka
d85940c5a5
Added an Advanced tab to Create New Qube dialog 
Tab contains a warning, provides_network checkbox,
install_system_after_creation checkbox, storage pool settings
and initial RAM.

references QubesOS/qubes-issues#5127
fixes QubeSOS/qubes-issues#5198
 2019-09-20 17:59:23 +02:00
Marta Marczykowska-Górecka
2e152b8dfb
Fixed new firewall rule window 
Now, an error will not close the window, enabling
the user to correct any mistakes.

fixes QubesOS/qubes-issues#bugfix5234
 2019-09-20 17:50:31 +02:00
Marek Marczykowski-Górecki
b0d5263d5e
Merge remote-tracking branch 'origin/pr/199' 
* origin/pr/199:
  Improved display of default disposable VM in Qube Manager
  Qube Manager now reacts to changing some global properties
 2019-09-20 02:10:15 +02:00
Marta Marczykowska-Górecka
2d644c371f
Improved display of default disposable VM in Qube Manager 
Now 'default' value will be correctly shown as default (vm name).
 2019-09-19 01:45:32 +02:00
Marta Marczykowska-Górecka
9aeacce9c5
Qube Manager now reacts to changing some global properties 
Properties checked are: default_netvm and default_dispvm. Qube Manager
will now properly update displayed values.

fixes QubesOS/qubes-issues#5328
 2019-09-19 01:45:32 +02:00
Marta Marczykowska-Górecka
df9576a0f1
Fixed UI error 
Qube Manager columns did not resize correctly in Qt5.

fixes QubesOS/qubes-issues#5278
 2019-09-06 16:31:27 +02:00
Marek Marczykowski-Górecki
c32d63df58
Merge remote-tracking branch 'origin/pr/181' 
* origin/pr/181:
  Add tooltip to application list in VM settings
 2019-08-28 16:50:23 +02:00
Marek Marczykowski-Górecki
1edf363efe
Merge remote-tracking branch 'origin/pr/172' 
* origin/pr/172:
  Say which repository caused the error in warnings
  Only make qrexec calls when necessary
  Squash more PyLint warnings
  Decode stderr in repo qrexec calls
  Fix error handling
  Fix `self` being undefined when showing warnings
  Only apply repo preferences when "OK" is clicked
  Don't use asserts for error handling
  Check that repo management succeeded
  Remove unnecessary assert
  Squash some PyLint warnings
  Add UI for managing Qubes update repositories
  Fix typo

Fixes QubesOS/qubes-issues#4550
 2019-08-28 16:42:01 +02:00
Marek Marczykowski-Górecki
1e3c0bfcd8
Merge remote-tracking branch 'origin/pr/194' 
* origin/pr/194:
  Fix arithmetic in init/max mem ratio correction
 2019-08-28 15:52:22 +02:00
Marek Marczykowski-Górecki
6107a1fcbf
Merge remote-tracking branch 'origin/pr/192' 
* origin/pr/192:
  Added virt mode column to Qube Manager
 2019-08-28 15:50:29 +02:00
Marek Marczykowski-Górecki
b4b3588bf1
Minor fix qt4 -> qt5 
Pylint detected one more missing QtGui->QtWidgets change.
 2019-08-28 15:48:29 +02:00
Marek Marczykowski-Górecki
990e4abbbf
Merge remote-tracking branch 'origin/pr/178' 
* origin/pr/178:
  Update Qt version used in qubesmanager to Qt5
 2019-08-28 15:19:26 +02:00
Aras Ergus
bbe14f524d
Fix arithmetic in init/max mem ratio correction 
Qubes Manager seems to try to guarantee that 10*init_mem is at
least max_mem by automatically adjusting init_mem to max_mem/10 if
inappropriate values are set. However, this may not guarantee that
10*init_mem >= max_mem due to rounding errors. This change fixes
these edge cases by basically rounding up the result of division
by 10.
 2019-08-17 15:42:36 +02:00
Marek Marczykowski-Górecki
3c9d7d3da4
firewall: service name can contain digits too 2019-08-10 03:54:35 +02:00
Marta Marczykowska-Górecka
dedde71d7a
Fixed bug with port numbers and services in VM settings 
Opening an existing FW rule resulted in an invalid port number.
 2019-08-09 14:16:30 +02:00
Marta Marczykowska-Górecka
1cd95fceb2
Added virt mode column to Qube Manager 
Just another column that shows the
contents of virt_mode property.

fixes QubesOS/qubes-issues#4702
 2019-08-08 17:30:15 +02:00
Marek Marczykowski-Górecki
d5a4ddb7ef
Merge remote-tracking branch 'origin/pr/191' 
* origin/pr/191:
  Fixed parsing port ranges in VM settings
  Better handling of port/service names for VM settings
 2019-08-02 20:03:35 +02:00
Marta Marczykowska-Górecka
1d7d51eafd
Fixed parsing port ranges in VM settings 
Now service names with dash ('-') in them will be parsed
correctly and not result in an error.

fixes QubesOS/qubes-issues#4766
 2019-08-02 16:58:30 +02:00
Marta Marczykowska-Górecka
6cd02b47b3
Better handling of port/service names for VM settings 
Now port will be displayed as port_number [(service name)]
, and not just service name. Also added a tooltip with explanation
of what can be put in the 'port/service' field, renamed
the field to 'Port/service' and added some examples of pure port
numbers to the drop down.

fixes QubesOS/qubes-issues#5211
 2019-08-02 16:39:51 +02:00
Marta Marczykowska-Górecka
31e3f72ae0
Kernel sorting fix 
Fixed bug with kernel versions ending with a letter,
hopefully now the sorting is even more robust and sensible.

fixes QubesOS/qubes-issues#5208
 2019-07-31 23:00:00 +02:00
Marek Marczykowski-Górecki
1dadca8ed8
Merge remote-tracking branch 'origin/pr/189' 
* origin/pr/189:
  Better settings for a newly created VM
  Changed checking for VM name in use
 2019-07-31 17:29:00 +02:00
Marek Marczykowski-Górecki
1a147121f0
Merge remote-tracking branch 'origin/pr/188' 
* origin/pr/188:
  Fixed silent fail in Boot from File window
 2019-07-31 17:28:10 +02:00
Marta Marczykowska-Górecka
4e9ed5e261
Better settings for a newly created VM 
Now a standalone VM not cloned from a template
will not have a kernel and have HVM virt mode.

fixes QubesOS/qubes-issues#5203
 2019-07-29 21:53:44 +02:00
Marta Marczykowska-Górecka
b19d9e1373
Changed checking for VM name in use 
In near future the old way will stop working, so
this is a pre-emptive fix.
 2019-07-29 21:52:40 +02:00
Marta Marczykowska-Górecka
349fb693be
Fixed silent fail in Boot from File window 
Now, when selecting a file fails for some reason
(lack of installed file manager, VM crashed on start,
anything), the user will get an error message.

references QubesOS/qubes-issues#5202
 2019-07-29 19:23:42 +02:00
xaki23
61cb9acf3b
make else/default branch of version-detection non-fatal since any new-and-coming debian variants at this point probably are 4371 fixed to begin with 2019-07-09 23:37:26 +02:00
AJ Jordan
7245603628
Say which repository caused the error in warnings 2019-07-03 01:48:55 -07:00
AJ Jordan
352c0d0386
Only make qrexec calls when necessary 
This helps in situations where the qrexec calls are forbidden; it also
prevents settings from being unintentionally changed and gives a
noticeable performance boost when the "OK" button is clicked.
 2019-07-03 01:46:39 -07:00
AJ Jordan
e0919beec1
Squash more PyLint warnings 
This definitely worked before, and I haven't touched this code recently
so I have no idea why these errors are just now popping up... but
whatever.
 2019-07-02 16:04:04 -07:00
AJ Jordan
6a5823b74a
Decode stderr in repo qrexec calls 
Before this change, "foobar\n" on stderr would be rendered (in the
warning dialog) as "b'foobar\n'", which is ugly. Now it'll be rendered
just as "foobar", followed by an actual newline character.
 2019-07-02 13:45:21 -07:00
AJ Jordan
4931bf9401
Fix error handling 
Apparently Python exceptions don't take **kwargs, so we just pass a
dictionary as the second (regular) argument. While we're at it, we
pretty-print said dictionary when displaying error messages.
 2019-07-02 13:37:29 -07:00
AJ Jordan
33ef478626
Fix self being undefined when showing warnings 2019-07-02 13:07:06 -07:00
AJ Jordan
026a844a91
Only apply repo preferences when "OK" is clicked 2019-07-02 12:36:29 -07:00
AJ Jordan
f3305b8288
Don't use asserts for error handling 2019-07-02 12:36:22 -07:00
AJ Jordan
8f9989a61d
Check that repo management succeeded 2019-07-01 17:23:49 -07:00
AJ Jordan
047cfbc407
Remove unnecessary assert 
First of all, the method that was being called has asserts of its own,
so it's guaranteed to either succeed or crash the program with
AssertionError. Second, asserts are optimized out by the interpreter
when -O is passed. Therefore, this code is buggy because it sometimes
wouldn't be run, but we need the side effects.
 2019-07-01 17:23:48 -07:00
AJ Jordan
df48c749c4
Squash some PyLint warnings 2019-07-01 17:23:46 -07:00
AJ Jordan
fdd06d32a5
Add UI for managing Qubes update repositories 
Depends on QubesOS/qubes-core-admin-linux#48

Fixes QubesOS/qubes-issues#4550
 2019-07-01 17:23:40 -07:00
AJ Jordan
a8df324b2d
Fix typo 2019-07-01 17:23:31 -07:00
Marta Marczykowska-Górecka
d0b99ef438
Cleaned up QThreads usage in VM Settings 
fixes QubesOS/qubes-issues#4949
 2019-06-14 21:13:56 +02:00
Marta Marczykowska-Górecka
4567707207
Add tooltip to application list in VM settings 
The 'Comment' field will now be displayed as a tooltip in VM settings.
Requires https://github.com/QubesOS/qubes-desktop-linux-common/pull/12

references QubesOS/qubes-issues#5076
 2019-06-10 16:01:44 +02:00
Marek Marczykowski-Górecki
ccdddc6a7e
Merge remote-tracking branch 'origin/pr/183' 
* origin/pr/183:
  Sorted kernels in VM settings
 2019-06-10 03:49:13 +02:00
Marek Marczykowski-Górecki
b2e6c1556a
Merge remote-tracking branch 'origin/pr/182' 
* origin/pr/182:
  Added 'provides network' checkbox to VM settings
 2019-06-10 03:48:13 +02:00
Marta Marczykowska-Górecka
65d07eca0d
Sorted kernels in VM settings 
Kernels are sorted with a rough algorithm, comparing groups of numbers
numerically, and names consisting of strings alphabetically.

fixes QubesOS/qubes-issues#5084
 2019-06-10 00:37:32 +02:00
Marta Marczykowska-Górecka
1f9b462bd3
Added 'provides network' checkbox to VM settings 
A simple checkbox in the 'Advanced' tab. Does not allow disabling
'provides_network' if the VM is in use as NetVM; instead, a tooltip
informs the user which VMs use it.

fixes QubesOS/qubes-issues#5079
 2019-06-07 20:13:24 +02:00
Marek Marczykowski-Górecki
09178bc00c
Merge remote-tracking branch 'origin/pr/180' 
* origin/pr/180:
  More safeguards for a VM that started in a weird way
 2019-06-06 04:15:28 +02:00
Marta Marczykowska-Górecka
8c1a9e5120
More safeguards for a VM that started in a weird way 
If for any reason adding a VM failed, Qube Manager will attempt to add it on the next state event it receives.

references QubesOS/qubes-issues#5066
 2019-06-03 21:21:48 +02:00
Marta Marczykowska-Górecka
e79724f9db
Update Qt version used in qubesmanager to Qt5 
Fixed dependencies, places where obsolete functions stopped working,
code fragments that started throwing warnings and an .ui file that
stopped being readable after the update.
 2019-05-30 21:33:49 +02:00
Marta Marczykowska-Górecka
7e17d23003
Added Virtual DNS display to VM settings 
fixes QubesOS/qubes-issues#5050
 2019-05-29 22:24:24 +02:00
Marek Marczykowski-Górecki
43cf50858f
Fix handling buster in dsa-4371-update script 
Fixes QubesOS/qubes-issues#5057
 2019-05-29 18:23:52 +02:00
Marek Marczykowski-Górecki
6550070135
Merge remote-tracking branch 'qubesos/pr/175' 
* qubesos/pr/175:
  More fixes to force tests to work
  Tests for Create New VM
  Tests for VM settings
  Fixed spec
  Tests for backup_utils file
  Tests for Qubes Backup
  Test changes related to fixes in https://github.com/QubesOS/qubes-manager/pull/176
  Tests for qube manager
  Tests for global settings
 2019-05-24 12:18:26 +02:00
Marta Marczykowska-Górecka
5d3c870c1b
More fixes to force tests to work 
Fixed yet another odd QT behavior when tests
were run all together.
 2019-05-20 23:23:03 +02:00
Marta Marczykowska-Górecka
d92c782ec9
Tests for Create New VM 2019-05-12 20:50:21 +02:00
Marta Marczykowska-Górecka
d4965c5b27
Tests for VM settings 2019-05-12 20:50:20 +02:00
Marta Marczykowska-Górecka
526799022d
Fixed spec 2019-05-12 19:47:13 +02:00
Marta Marczykowska-Górecka
9764479aff
Tests for backup_utils file 2019-05-12 19:47:13 +02:00
Marta Marczykowska-Górecka
9252dad222
Tests for Qubes Backup 2019-05-12 19:47:12 +02:00
Marta Marczykowska-Górecka
893764a50c
Test changes related to fixes in https://github.com/QubesOS/qubes-manager/pull/176 2019-05-12 19:47:12 +02:00
Marta Marczykowska-Górecka
702ef75d1c
Tests for qube manager 2019-05-12 19:47:12 +02:00
Marta Marczykowska-Górecka
4fb9672d66
Tests for global settings 2019-05-12 19:47:12 +02:00
Marek Marczykowski-Górecki
af555fa9b1
Merge remote-tracking branch 'origin/pr/176' 
* origin/pr/176:
  Fixed logs display in Qube Manager
  Protected loading manager settings from malformed config files
  Fixed bug with hiding last visible column
  Added additional check for cloning a VM
  Fixed unnecessary property set in Global Settings
  Fixed bug in Global Settings
 2019-05-07 00:09:01 +02:00
Marek Marczykowski-Górecki
e997b4708d
Merge remote-tracking branch 'origin/pr/173' 
* origin/pr/173:
  Changed wording in Create New Qube and fixed minor bug
  Made terminology in Create New VM GUI clearer
 2019-05-07 00:06:33 +02:00
Marta Marczykowska-Górecka
768bfac019
Changed wording in Create New Qube and fixed minor bug 
references QubesOS/qubes-issues#4723
 2019-05-06 17:39:14 +02:00
Marta Marczykowska-Górecka
2634b3b229
Made terminology in Create New VM GUI clearer 
Changed the terms used in Create New VM Gui to the following:
-Qube based on a template (AppVM)
-Standalone qube
-Standalone qube copied from a template

references QubesOS/qubes-issues#4723
 2019-05-06 17:39:14 +02:00
Marta Marczykowska-Górecka
cb70b9bd65
Fixed logs display in Qube Manager 
Logs menu was not updated correctly on all occassions.
 2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
f5586e770b
Protected loading manager settings from malformed config files 
Malformed config files will no longer prevent Qube Manager from
starting.
 2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
0bb92311ba
Fixed bug with hiding last visible column 
Removed old buggy code, replaced it with disabling hiding the 'name'
column (because manager is useless without VM name).
 2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
ddb70fe8ea
Added additional check for cloning a VM 
An attempt to clone a VM to a name that is already in use will
fail more gracefully and with an explicit warning message.
 2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
733f00ddf2
Fixed unnecessary property set in Global Settings 2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
b9316bcd62
Fixed bug in Global Settings 
Incorrect handling of Check dom0 updates being set to false.

fixes QubesOS/qubes-issues#4988
 2019-05-03 14:41:00 +02:00
xaki23
f063aa5eea
treat kali-* as a variant of buster/sid 2019-04-11 01:06:01 +02:00
Marek Marczykowski-Górecki
baeabc2e8c
Merge remote-tracking branch 'qubesos/pr/171' 
* qubesos/pr/171:
  Fixed error in VM settings
 2019-04-05 22:10:24 +02:00
Marta Marczykowska-Górecka
6b6621abfc
Fixed error in VM settings 
fixes QubesOS/qubes-issues#4951
 2019-04-05 21:35:46 +02:00
Marek Marczykowski-Górecki
6585ab4f29
Merge remote-tracking branch 'origin/pr/166' 
* origin/pr/166:
  Refactored QThread classes for more clarity and less code duplication
  Fixed inconsisted icon in Qube Manager messages
 2019-04-05 00:53:32 +02:00
Marta Marczykowska-Górecka
6e10daa309
Refactored QThread classes for more clarity and less code duplication 2019-04-04 22:58:10 +02:00
Marek Marczykowski-Górecki
f4d0417e1a
Merge remote-tracking branch 'origin/pr/170' 
* origin/pr/170:
  Fix error on reverting Qube Manager to an older version
 2019-04-04 01:28:35 +02:00
Marek Marczykowski-Górecki
0cdbda5df9
Merge remote-tracking branch 'origin/pr/168' 
* origin/pr/168:
  Fixed device handling in VM settings widget
 2019-04-04 01:27:08 +02:00
Marek Marczykowski-Górecki
278a72d461
Merge remote-tracking branch 'origin/pr/167' 
* origin/pr/167:
  More documentation and added another column for default_dispvm to Qube Manager
  Added DVM Template column to Qube Manager
  Rewritten Qube Manager widgets
 2019-04-04 01:26:03 +02:00
Marta Marczykowska-Górecka
d2ad60edd2
Fix error on reverting Qube Manager to an older version 
In rare case (when the Qube Manager was reverted to an older version
that does not have a column on which it was last sorted) downgrading
Qube Manager could result in a crash on start.
 2019-04-03 20:49:33 +02:00
Marta Marczykowska-Górecka
077bcb3a8e
Fixed device handling in VM settings widget 
PCI devices are now handled as DeviceInfo objects, not (string,name) tuples;
furthermore, a device that no longer exists in the system can be
correctly removed via VM settings window (it is displayed as Unknown
device).

fixes QubesOS/qubes-issues#2789
 2019-04-03 20:47:09 +02:00
Marta Marczykowska-Górecka
c2e7010b25
More documentation and added another column for default_dispvm to Qube Manager 
Including also a minor visual fix - the headers in Qube Manager
will now be multi-line when it looks needed.

fixes QubesOS/qubes-issues#4912
 2019-04-03 19:21:25 +02:00
Marek Marczykowski-Górecki
8318db9b4e
Merge remote-tracking branch 'origin/pr/169' 
* origin/pr/169:
  Fixed device list behavior for a running VM in VM settings
 2019-04-03 16:43:37 +02:00
Marek Marczykowski-Górecki
1d65d692ad
Merge remote-tracking branch 'origin/pr/154' 
* origin/pr/154:
  Fix too long lines
  Moved busy_cursor() inside save_changes()
  Removed unneded calls to Override/Restore cursor
  Removed duplicated call to save_changes()
  Removed unneeded Cursor override/restore
  Added busy_cursor()
  Added BusyCursor for notify manager is working
  Revert "Added progress bar to __save_changes__"
  Revert "Increase progress wait time to 2s"
  Increase progress wait time to 2s
  Added progress bar to __save_changes__
  Remove unneeded slot connections and reject overwrite
 2019-04-03 16:19:10 +02:00
Marta Marczykowska-Górecka
6cf0e83b1d
Fixed device list behavior for a running VM in VM settings 
PCI devices will now correctly be unmodifiable if the VM is running.

fixes QubesOS/qubes-issues#4933
 2019-04-02 22:16:55 +02:00
donoban
b7228e8419
Fix too long lines 2019-04-01 11:48:11 +02:00
Marek Marczykowski-Górecki
57376456a7
Merge remote-tracking branch 'origin/pr/165' 
* origin/pr/165:
  Set the window title when cloning a qube
 2019-03-31 23:00:25 +02:00
Marek Marczykowski-Górecki
1d68a70356
Merge remote-tracking branch 'origin/pr/164' 
* origin/pr/164:
  Fixed minor error in Qubes Backup
 2019-03-31 23:00:07 +02:00
donoban
34adc75752
Moved busy_cursor() inside save_changes() 2019-03-31 20:04:04 +02:00
donoban
c85d6e4e8b
Removed unneded calls to Override/Restore cursor 2019-03-31 20:01:38 +02:00
donoban
16f2997222
Removed duplicated call to save_changes() 2019-03-31 19:59:55 +02:00
donoban
1fbf6c9a59
Removed unneeded Cursor override/restore 2019-03-31 19:58:52 +02:00
donoban
8e383e3022
Added busy_cursor() 
fix https://github.com/QubesOS/qubes-issues/issues/4744
 2019-03-31 19:56:01 +02:00
donoban
9750d990a7
Merge remote-tracking branch 'upstream/master' 2019-03-30 15:06:07 +01:00
Marta Marczykowska-Górecka
cf1dd0d355
Added DVM Template column to Qube Manager 
It is labelled "Template for DispVMs" and behaves like every
other column.

fixes QubesOS/qubes-issues#4912
 2019-03-29 19:04:45 +01:00
Marta Marczykowska-Górecka
2ce6e8b1cc
Rewritten Qube Manager widgets 
Less duplicate code and more extendability - now most
widgets are based on a single class.
 2019-03-29 18:33:51 +01:00
Marta Marczykowska-Górecka
fe810c5ad0
Fixed inconsisted icon in Qube Manager messages 
Now success will not be accompanied by a 'warning'
icon.

fixes QubesOS/qubes-issues#4922
 2019-03-29 17:01:15 +01:00
AJ Jordan
868632555b
Set the window title when cloning a qube 2019-03-27 21:37:27 -04:00
Marta Marczykowska-Górecka
8fbf3fd2a6
Fixed minor error in Qubes Backup 
Possibly due to changes in how services work,
the run_service_for_stdio was returning path with trailing
whitespace.

fixes QubesOS/qubes-issues#4921
 2019-03-27 18:31:26 +01:00
Marek Marczykowski-Górecki
26462a32ab
Merge remote-tracking branch 'origin/pr/163' 
* origin/pr/163:
  fix incorrect behavior after backup error
 2019-03-23 03:25:20 +01:00
Marta Marczykowska-Górecka
00ccce4816
Fixed minor errors found when debugging feature settings 
the check-updates default was being incorrectly set
 2019-03-21 14:47:03 +01:00
Marta Marczykowska-Górecka
597a3e728f
fix incorrect behavior after backup error 
the Backup Qubes tool failed to allow user to exit correctly
after backup errored out in any way.

fixes QubesOS/qubes-issues#4885
 2019-03-20 23:34:19 +01:00
donoban
8816a764ee
Merge remote-tracking branch 'upstream/master' 2019-03-17 17:09:13 +01:00
Marta Marczykowska-Górecka
1c06d241f0
Fix bug with fixed bug in VM Settings 
fixes QubesOS/qubes-issues#4866
 2019-03-11 22:02:32 +01:00
Marta Marczykowska-Górecka
e556c8f848
Fix bug with VM Settings 
Bug related to previous fixes to 'apply'; part of the code still
incorrectly assumed some attributes may not exist

fixes QubesOS/qubes-issues#4866
 2019-03-09 16:45:22 +01:00
Marek Marczykowski-Górecki
f6c8103f46
Fix boot CD image path validation 
re.match checks only beginning of the path. There should be
re.fullmatch.

Fixes QubesOS/qubes-issues#4860
 2019-03-07 02:54:10 +01:00
donoban
6469dd8341
Merge remote-tracking branch 'upstream/master' 2019-03-06 21:59:56 +01:00
Marek Marczykowski-Górecki
7874aa73fe
Merge remote-tracking branch 'origin/pr/158' 
* origin/pr/158:
  Fixed error in displaying error on VM Rename
 2019-02-26 23:12:35 +01:00
Marta Marczykowska-Górecka
26779a4826
Fixed error in displaying error on VM Rename 
VM rename was incorrectly trying to display an error by itself and not
use QThreads embedded mechanism.

fixes QubesOS/qubes-issues#4843
fixes QubesOS/qubes-issues#4767
 2019-02-26 21:10:22 +01:00
Marek Marczykowski-Górecki
94cefc9d09 Merge remote-tracking branch 'qubesos/pr/157' 
* qubesos/pr/157:
  Fixed error in detecting dvm-template having different NetVM
 2019-02-26 19:50:21 +01:00
Marek Marczykowski-Górecki
74987f6554 Merge remote-tracking branch 'qubesos/pr/156' 
* qubesos/pr/156:
  Fixed incorrect behavior after 'Apply' in Settings
 2019-02-26 19:49:04 +01:00
Marta Marczykowska-Górecka
b31a154e32
Fixed error in detecting dvm-template having different NetVM 
when the currect VM is the same as the dvm_template, there should be no
warning

fixes QubesOS/qubes-issues#4844
 2019-02-26 19:31:41 +01:00
Marta Marczykowska-Górecka
d23dafed28
Fixed incorrect behavior after 'Apply' in Settings 
Changes in some fields (to be precise, drop-downs) were discarded
in VM Settings when changed after an 'Apply' and before an 'OK'.

fixes QubesOS/qubes-issues#4833
 2019-02-26 18:02:36 +01:00
Marek Marczykowski-Górecki
9afa6faca0
Merge remote-tracking branch 'origin/pr/151' 
* origin/pr/151:
  Added "set as dvm template" to VM settings
 2019-02-23 18:40:07 +01:00
Marta Marczykowska-Górecka
ef6288f1ff
Added "set as dvm template" to VM settings 
Added an 'Advanced' settings checkbox that allows the user to set a given
VM as template fo dispvms. It sets both the template_for_dispvms property
and the appmenus-dispvm feature - instead of delving into particulars
of how and which should be set, the user can just turn off the
whole setting if they want to make some changes in the vm and then turn
it on again.

fixes QubesOS/qubes-issues#4004
 2019-02-23 18:27:22 +01:00
Marta Marczykowska-Górecka
faae2d0026
Added warning when setting NetVM 
When NetVM is set to something else than default_dispvm has set, a warning
icon appears.
 2019-02-19 22:27:28 +01:00
donoban
17fdb3c263
Added BusyCursor for notify manager is working 
https://github.com/QubesOS/qubes-issues/issues/4744
 2019-02-19 21:58:33 +01:00
donoban
56cc6c79e5
Revert "Added progress bar to __save_changes__" 
This reverts commit bb7b8c79ae.
 2019-02-19 21:46:38 +01:00
donoban
dda98610d5
Revert "Increase progress wait time to 2s" 
This reverts commit 0e9f8d4c45.
 2019-02-19 21:46:17 +01:00