Whenever Enter was pressed, the Settings window
closed and applied changes, which was very unintuitive
especially in case of Services tab.
references QubesOS/qubes-issues#3891
When all firewall rules are removed, qubes-vm-settings crashed
trying to check if the last rule accepts or drops all packages.
It is now verifies that there is a last rule.
Also, it is now properly verified that the last rule accept
or drops all packages.
Associated stack trace:
----
line: last_rule = reversed_rules.pop(0)
func: get_firewall_conf
line no.: 227
file: /usr/lib/python3.5/site-packages/qubesmanager/firewall.py
----
line: conf = self.get_firewall_conf(vm)
func: set_vm
line no.: 308
file: /usr/lib/python3.5/site-packages/qubesmanager/firewall.py
----
line: model.set_vm(vm)
func: __init__
line no.: 111
file: /usr/lib/python3.5/site-packages/qubesmanager/settings.py
----
line: settings_window = VMSettingsWindow(vm, qapp, args.tab)
func: main
line no.: 1133
file: /usr/lib/python3.5/site-packages/qubesmanager/settings.py
----
line: load_entry_point('qubesmanager==4.0.17', 'console_scripts', 'qubes-vm-settings')()
func: <module>
line no.: 9
file: /usr/bin/qubes-vm-settings
Fixes problems showing 'outdated' instead 'to-be-outdated' when template is running
Fixes the removal of the icon calling setVisible(False) before removeWidget()
- Removed table.setEnabled/Disabled tweak since I dont see any improvement, maybe because
fill_table() is only called without the window shown
- Removed unneeded update_table() calls, dbus events will handle them
Makes clear that check_updates_vm is just the default for new VMs and
replaces some more instances of VM with qube. (Note: the size change
is deliberate)
fixesQubesOS/qubes-issues#3732
* qubesos/pr/80:
changes as requested by @marmarek
Minor textual update for Global Settings
While resolving conflict, reverted global settings window size to sane
value.
The window should first display itself, and then get gradually filled with VMs
(more user friendly, less annoying than waiting for something, anything
to appear).
Also fixed a dumb bug with double refreshing and a useless variable.
fixesQubesOS/qubes-issues#3719
In lieu of bigger overhaul/processing policy files in
VM Settings, a bit of explanation for updateVM in Global
Settings and a change of name from UpdateVM to Dom0 Update VM
there. This is quick fix solution, pending a better
one when (hopefully) we get some better API for
interacting with policies.
references QubesOS/qubes-issues#3412
