Commit Graph

724 Commits

Author SHA1 Message Date
Marta Marczykowska-Górecka
84d7e8bf9c
Allow setting default NetVM to None in Global Settings
Replaced old, manual vm list with a nicer, less disgusting
utils.prepare_vm_choice approach.
2018-02-22 22:21:39 +01:00
Marta Marczykowska-Górecka
29a56d9c88
Fixed error in setting Clockvm to None in Global Settings
Replaced old, manual vm list with a nicer, less disgusting
utils.prepare_vm_choice approach.
2018-02-22 22:21:39 +01:00
Marta Marczykowska-Górecka
c1e9074cb9
Fixed error in setting Updatevm to None in Global Settings
Replaced old, manual vm list with a nicer, less disgusting
utils.prepare_vm_choice approach.
2018-02-22 22:21:39 +01:00
Marek Marczykowski-Górecki
fb4870a16b
Merge remote-tracking branch 'qubesos/pr/72'
* qubesos/pr/72:
  Added 'Apply' button to VM Settings
2018-02-22 18:15:23 +01:00
Marek Marczykowski-Górecki
fb8b19af81
Merge remote-tracking branch 'qubesos/pr/71'
* qubesos/pr/71:
  Fixed bug 3594
2018-02-22 18:14:28 +01:00
Marek Marczykowski-Górecki
a141e40e9c
Merge remote-tracking branch 'qubesos/pr/70'
* qubesos/pr/70:
  Allow restarting auto_cleanup=False DispVMs
2018-02-22 18:13:32 +01:00
Marta Marczykowska-Górecka
8218f5fde1
Added 'Apply' button to VM Settings
Simple "Apply" button.

fixes QubesOS/qubes-issues#3321
2018-02-20 20:32:00 +01:00
Marta Marczykowska-Górecka
dc0f8c0a9e
Fixed bug 3594
Incorrect targetVM display - dom0 was not included, and the code
erroneously assumed that not only it is included, but also it's always
the first in the dropdown. No more assumptions.

fixes QubesOS/qubes-issues#3594
2018-02-20 19:22:57 +01:00
Rusty Bird
07866cbfc4
Allow restarting auto_cleanup=False DispVMs 2018-02-20 08:25:22 +00:00
Marta Marczykowska-Górecka
e95be8a8ed
Is this bug finally dead
Yet another attempt at stomp this zombie monstrosity.

fixes QubesOS/qubes-issues#3570
2018-02-13 20:26:55 +01:00
Marek Marczykowski-Górecki
b3699d27d5
Merge remote-tracking branch 'qubesos/pr/67'
* qubesos/pr/67:
  Boot from device window fix
2018-02-13 05:06:06 +01:00
Marek Marczykowski-Górecki
09805396bb
Merge remote-tracking branch 'qubesos/pr/65'
* qubesos/pr/65:
  Changes according to @marmarek's request
  Shutting down vm from qube manager bug
  Refreshing vm list in qube manager fixed
  Qube manager updates more sensibly
2018-02-13 05:05:24 +01:00
Marta Marczykowska-Górecka
8640fa7ace
Boot from device window fix
The window wasn't closing properly.
2018-02-11 00:20:14 +01:00
Marta Marczykowska-Górecka
45959aef71
Changes according to @marmarek's request 2018-02-10 23:41:36 +01:00
Marek Marczykowski-Górecki
ec7c65de34
Merge remote-tracking branch 'qubesos/pr/64'
* qubesos/pr/64:
  Bugfixed
  Fixed error in creating new VMs from GUI
2018-02-10 23:41:10 +01:00
Marek Marczykowski-Górecki
83936ba93e
Merge remote-tracking branch 'qubesos/pr/66'
* qubesos/pr/66:
  Fixed incorrect default dispvm settings
2018-02-10 23:35:12 +01:00
Marta Marczykowska-Górecka
c1bb8ba2ad
Bugfixed
According to @marmarek's request
2018-02-10 23:34:59 +01:00
Marek Marczykowski-Górecki
712e95617a
Merge remote-tracking branch 'qubesos/pr/63'
* qubesos/pr/63:
  Fixed bug with template selection
  Fixed errors with virt mode choice
2018-02-10 23:28:39 +01:00
Marek Marczykowski-Górecki
1fe280538e
Merge remote-tracking branch 'qubesos/pr/61'
* qubesos/pr/61:
  Once more to fix this pesky bug
2018-02-10 23:24:17 +01:00
Marta Marczykowska-Górecka
8da0d35110
Fixed incorrect default dispvm settings
Fixed error in DispVM selection in VM settings

fixes QubesOS/qubes-issues#3565
2018-02-10 22:54:00 +01:00
Marta Marczykowska-Górecka
5af2709029
Shutting down vm from qube manager bug
Hopefully, finally fixes issue #3501.

fixes QubesOS/qubes-issues#3501
2018-02-09 22:08:07 +01:00
Marta Marczykowska-Górecka
1d995de095
Refreshing vm list in qube manager fixed
If a new VM was created via button in vm settings, the refresh button will now correctly display it.
2018-02-09 21:59:43 +01:00
Marta Marczykowska-Górecka
dac7a6f208
Qube manager updates more sensibly
Many events now cause the Qube Manager to refresh better - just the appropriate row, for example.
2018-02-09 21:36:30 +01:00
Marta Marczykowska-Górecka
dc9f764baa
Fixed error in creating new VMs from GUI
Virt mode was forcibly set to HVM. Now, the virt mode is left as default,
unless a standalone VM with system installed from elsewhere is selected.

fixes QubesOS/qubes-issues#3515
2018-02-06 15:47:00 +01:00
Marta Marczykowska-Górecka
0ec3c704dd
Fixed bug with template selection
Template in VM settings was not displayed correctly. It should work now.
2018-02-06 15:38:20 +01:00
Marta Marczykowska-Górecka
2be8f8bcea
Fixed errors with virt mode choice
Current virtualization mode wasn't displayed correctly. It should work now.

fixes QubesOS/qubes-issues#3517
2018-02-06 15:31:17 +01:00
Marta Marczykowska-Górecka
81e5a92e66
Once more to fix this pesky bug
fixes QubesOS/qubes-issues#3501
2018-01-30 17:11:28 +01:00
Marek Marczykowski-Górecki
b28bd6e797
Merge remote-tracking branch 'qubesos/pr/60'
* qubesos/pr/60:
  Repaired manager icons
  Removed 'Seamless GUI' checkbox from VM settings
  Change default Qube Manager size
  Renamed 'VM' to 'qube' everywhere in manager
2018-01-29 23:55:07 +01:00
Marta Marczykowska-Górecka
71090b9e72
Change default Qube Manager size
So that it will fit all VMs from a default install.
2018-01-28 20:38:40 +01:00
Marta Marczykowska-Górecka
3a60f9146a
Renamed 'VM' to 'qube' everywhere in manager
At least I hope it's everywhere.
Note: AppVM and NetVM nomenclature have been kept as before.
2018-01-28 20:26:29 +01:00
Marta Marczykowska-Górecka
cb1519b56c
Fixed error on VM shutdown in Qube Manager
fixes QubesOS/qubes-issues#3501
2018-01-28 18:23:18 +01:00
Marta Marczykowska-Górecka
4ec36de20d
Changes as requested by @marmarek 2018-01-26 23:17:02 +01:00
Marta Marczykowska-Górecka
46fe3725d1
Refresh Qube Manager list after closing VM settings
Now the Qube Manager refreshes VM list after VM settings are launched
and closed.
2018-01-23 20:44:59 +01:00
Marta Marczykowska-Górecka
cd8a243f5c
Fixes to resizing in Qube Manager
Change column resize mode to interactive and stretch last column, so there's no useless space on the right. Also minor fix to sorting last_timestamp column, for more readability and also to fix a rare bug.
2018-01-23 20:28:19 +01:00
Marek Marczykowski-Górecki
81413907bf
Merge remote-tracking branch 'qubesos/pr/55'
* qubesos/pr/55:
  Fixed according to @marmarek request
  Fixed according to @marmarek request
  Added 'configure no strict reset for PCI devices' button
  Adding a button to list PCI devices and enable no-strict-reset
  Fixed some indents and whitespaces
  Fixed python2 in settings.py
2018-01-19 03:01:57 +01:00
Marta Marczykowska-Górecka
b158aeccbd
Fixed according to @marmarek request 2018-01-19 02:50:04 +01:00
Marta Marczykowska-Górecka
1b9737c1a7
Fixed according to @marmarek request 2018-01-19 01:48:46 +01:00
Marta Marczykowska-Górecka
03ba645009
Fixed according to @marmarek request 2018-01-19 01:24:11 +01:00
Marta Marczykowska-Górecka
f1964f0c5b
Merge branch 'master' into virt-mode-select-fixes 2018-01-19 00:36:38 +01:00
Marta Marczykowska-Górecka
2cffffdcff
Fixed error in qubesmanager utils
Fix in app.labels caused an old workaround to malfunction.

fixes QubesOS/qubes-issues#3475
2018-01-18 23:49:17 +01:00
Marta Marczykowska-Górecka
985f8fb56d
Fixed error in qube-manager
Last backup timestamp was not correctly processed.
2018-01-18 23:42:34 +01:00
Marta Marczykowska-Górecka
484f724838
Fixes to make pylint stop complaining 2018-01-17 12:13:04 +01:00
Marta Marczykowska-Górecka
48c3bfa798
Merge branch 'master' into virt-mode-select-fixes 2018-01-16 20:04:16 +01:00
Marta Marczykowska-Górecka
1a5a1fa7ee
Minor fixes to virt_mode select pull request
Changes:
- added hints about "which virt mode should I use"
- changed displayed virt modes to show modes in all caps

closes #44
2018-01-16 19:56:45 +01:00
Marta Marczykowska-Górecka
801014f2e5
Added 'configure no strict reset for PCI devices' button
The button is in 'devices' tab of VM settings; it allows the user to
select which devices should have 'no-strict-reset' enabled and tells
the user not to change this setting if there are no errors.

fixes QubesOS/qubes-issues#3205
2018-01-13 00:25:48 +01:00
Marta Marczykowska-Górecka
f4fae54057
Adding a button to list PCI devices and enable no-strict-reset 2018-01-13 00:25:46 +01:00
Marta Marczykowska-Górecka
60143e6a91
Fixed some indents and whitespaces
Fixed indents and whitespace that pylint was complaining about.
2018-01-13 00:25:02 +01:00
Marta Marczykowska-Górecka
ec3d6eb84a
Fixed python2 in settings.py
settings.py was erroneously using python2. Replaced with python3.
2018-01-13 00:19:58 +01:00
Marek Marczykowski-Górecki
90f7f8474d
Merge remote-tracking branch 'qubesos/pr/54'
* qubesos/pr/54:
  Fixed minor error in VM Settings
2018-01-12 04:39:31 +01:00
Marek Marczykowski-Górecki
57d723c61e
Merge remote-tracking branch 'qubesos/pr/53'
* qubesos/pr/53:
  Renamed 'VM' to 'qube' in GUI
  Added warning that the VM is currently running
  Fixed missing import
2018-01-12 04:37:00 +01:00
Marta Marczykowska-Górecka
670c41e4ff
Fixed minor error in VM Settings
When init page was 'firewall', the tool incorrectly displayed warnings about wrong firewall vm configuration, without actually checking if they should be displayed.
2018-01-12 04:30:47 +01:00
Marta Marczykowska-Górecka
b1dc2458f6
Code review changes
As requested by @marmarek
2018-01-10 02:18:51 +01:00
Marta Marczykowska-Górecka
f86139d0d2
Renamed 'VM' to 'qube' in GUI
For consistency with new terminology.
2018-01-08 20:09:56 +01:00
Marta Marczykowska-Górecka
45496f73de
Added warning that the VM is currently running
Added warning that the VM is currently running. User still must shut it manually (by design).
2018-01-08 20:05:25 +01:00
Marta Marczykowska-Górecka
839696f6f9
Fixed missing import
Fixed missing import in boot-from-cdrom tool.
fixes QubesOS/qubes-issues#3421
2018-01-08 20:00:55 +01:00
Marta Marczykowska-Górecka
1cee3a5fe3
Fixed 'About' window
Surprisingly, it has not been touched since 3.2. It should work now.
2018-01-08 04:22:54 +01:00
Marta Marczykowska-Górecka
e19793ea7a
Minor display fix
Changed "size on disk" widget to display only two decimal places.
2018-01-08 04:22:54 +01:00
Marta Marczykowska-Górecka
899ca6d394
Pylint corrections
Removed errors discovered by pylint, or told it to be quiet when needed.
2018-01-08 04:22:54 +01:00
Marta Marczykowska-Górecka
41b8e6a4fb
Replaced 'VM' with 'Qube'
Renamed 'VM' to 'Qube' in the user interface for Qube Manager.
2018-01-08 04:22:54 +01:00
Marta Marczykowska-Górecka
8b5e2a8d66
Qube Manager in working order
Everything that should work works. Further improvements that would be nice:
- replace untidy multitude of QtGui Items with one generic type
- restore Qubes Network functionality
- add Boot From Device action (and easy way to install windows tool from there)

fixes QubesOS/qubes-issues#2966
QubesOS/qubes-issues#2132
2018-01-08 04:22:35 +01:00
Marta Marczykowska-Górecka
d57e58ae4d
Further work on qubes manager 2018-01-06 23:05:33 +01:00
Marta Marczykowska-Górecka
443f48c648
Recreation of the old qubes manager in a leaner, cut-down form. First
commit, WIP.
2018-01-06 23:03:19 +01:00
Marta Marczykowska-Górecka
bb8abff988
Suggested changes
included changes as suggested by @marmarek.
2018-01-06 02:21:07 +01:00
Marta Marczykowska-Górecka
df31207028
Final tiny fix of unused import
Threw out unused import of shutil.
2017-12-11 02:41:50 +01:00
Marta Marczykowska-Górecka
67a32b5748
Added 'compression' checkbox to backup GUI
Added 'compress the backup' checkbox to the backup GUI.

fixes QubesOS/qubes-issues#943
2017-12-11 02:37:50 +01:00
Marta Marczykowska-Górecka
7fd0c58303
Restored 'cancel' functionality
Now user can actually cancel a backup/restore.
2017-12-11 02:28:15 +01:00
Marta Marczykowska-Górecka
14ebf9dc6d
Fixed opening file dialog at the end
Now, when "open file dialog to unmount" option is enabled, a fie dialog
actually opens.
2017-12-11 02:07:10 +01:00
Marta Marczykowska-Górecka
a4a58cc527
Fixed progress bars
Partial fix - the progress bars now move, although they do not really
indicate progress (just dance back and forth). Future fix would include
making a tray icon to signal backup progress instead.
2017-12-11 01:32:26 +01:00
Marta Marczykowska-Górecka
78b4747e81
Second pylint pass
Fixed errors pointed out by pylint on server.
2017-12-11 01:15:07 +01:00
Marta Marczykowska-Górecka
a1c6e72569
First pylint pass
Fixed errors pointed out by pylint.
2017-12-11 00:56:27 +01:00
Marta Marczykowska-Górecka
4e2835531e
Usability fixes
Added label to inform the user only running VMs are listed in backup
GUI; made "ignore missing" label clearer.
2017-12-11 00:13:15 +01:00
Marta Marczykowska-Górecka
7848b6b2c3
Fixed inability to select which VMs to restore
Fixed bug that caused all VMs to be restored, regardless of what the
user selected.
2017-12-10 23:56:22 +01:00
Marta Marczykowska-Górecka
7bcde2158e
Added optional saving of default backup profile
Added checkbox for saving default backup profile. Removed useless "should I encrypt" checkbox (yes, you have to encrypt).
2017-12-10 23:19:16 +01:00
Marta Marczykowska-Górecka
9d73ceb99d
Fixed imports
Fixed import * and unused imports.
2017-12-10 22:11:07 +01:00
Marta Marczykowska-Górecka
7a4e4b35d5
Initial backup-and-restore GUI restoration
Initial restoration: basic backup-and-restore works, but
- progress bar in backup does not work
- selecting only some VMs to restore does not work
- various miscellaneous enhancements are not yet in place
2017-12-10 21:14:14 +01:00
Marek Marczykowski-Górecki
c403fc1e8f
Merge branch 'firewall_warnings'
* firewall_warnings:
  Sort items in settingsdlg.ui / firewall tab
  Enabled Firewall config without a netvm
2017-11-21 02:42:27 +01:00
Marta Marczykowska-Górecka
5b19c825e3
Enabled Firewall config without a netvm
Enabled Firewall tab even when there's no working netvm or the netvm
doesn't support qubes-firewall. An appropriate warning label and message
are shown in both cases.

fixes QubesOS/qubes-issues#3290
2017-11-20 14:20:01 +01:00
Marta Marczykowska-Górecka
eeac042662
Fixed bug with firewall GUI settings
Fixed bug that led to correct firewall configuration not being
recognized by GUI VM Settings.

fixes QubesOS/qubes-issues#3289
2017-11-17 19:12:06 +01:00
Marta Marczykowska-Górecka
5f1e4803fe
Applied corrections from @marmarek 2017-11-17 17:42:19 +01:00
Marta Marczykowska-Górecka
135060dfe7
Final corrections
Errors that my local pylint ignored and travis' pylint didn't.
2017-11-14 15:44:43 +01:00
Marta Marczykowska-Górecka
8cfc93c70c
Misc errors part 2
Renamed variable from 'input' to 'input_string' and moved imports to a
better place (that is, at the beginning of the module and not inside of
a function).
2017-11-09 17:57:21 +01:00
Marta Marczykowska-Górecka
8b296fab0d
Disable too-many-attributes warning
It's the settings window, it has a lot of attributes.
2017-11-09 17:41:10 +01:00
Marta Marczykowska-Górecka
95599dff9f
A bunch of misc errors
Fixed a bunch of small errors: bad indents, superfluous parentheses,
missing whitespace, superfluous statement.
2017-11-09 17:41:10 +01:00
Marta Marczykowska-Górecka
e543144aec
Too-few-public-methods warning
Checked, are sensible, disabled pylint warnings.
2017-11-09 17:41:10 +01:00
Marta Marczykowska-Górecka
3d841cf14f
Checked too-many-returns error
Checked both places with a 'too-many-return-statements' warning, both
were sensible, marked them as such.
2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
6670f59853
Fixed regex strings
Fixed regex strings that were not marked as raw.
2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
59a9b7da40
Redefined variable type
Marked places where redefining variable type was actually sensible as
such.
2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
0115c931d2
Variables defined outside init
Defined them inside init and added description.
2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
ff4ee713b1
Removed unnecessary global variables
Removed three variables set to global, which were all used only in their
respective "main" function.
2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
b7060e76b2
Fixed no-self-use error
Turned methods into static methods when possible.
2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
695303f16a
Fixed unused variables
When possible removed, otherwise renamed to start with an underscore.
2017-11-09 16:26:05 +01:00
Marta Marczykowska-Górecka
3f7f5a9da3
Firewall GUI fix
Fixed error when service would be left empty, but the settings window
would nonetheless emit an error.
2017-11-09 16:19:14 +01:00
Marta Marczykowska-Górecka
b9e4f99fec
Fixed unusued arguments
Places where the variable is used in a overriding method were marked for
pylint to ignore them.
2017-11-09 16:19:12 +01:00
Marta Marczykowska-Górecka
04aa844a9d
Removed variable "anything_changed"
It was assigned in 17 places and not used otherwise in any other place.
It's highly likely it was useless.
2017-11-09 16:18:23 +01:00
Marta Marczykowska-Górecka
6e5d611f70
Fixed invalid names
Fixed camel case, too long and too short variable and function names.
2017-11-09 16:18:16 +01:00
Marta Marczykowska-Górecka
d7fbacf0d7
Fixed broad exceptions
Fixed broad exception errors: replacing them with more precise error
catching where sensible and adding appropriate pylint skip comments
where not.
2017-11-08 15:40:35 +01:00
Marta Marczykowska-Górecka
2b24abb8c8
Fixed trailing and bad whitespaces
Fixed trailing and bad whitespaces
2017-11-06 23:55:58 +01:00
Marta Marczykowska-Górecka
91572eea2d
Fixed too-long lines
Fixed lines over 80 characters.
2017-11-06 23:55:58 +01:00
Marta Marczykowska-Górecka
c252e9ec3c
Fixed wildcard imports
Fixed wildcard imports and any further problems resulting from them.
2017-11-06 23:55:58 +01:00
Marta Marczykowska-Górecka
eaccc323fb
Fixed unused imports
Fixed all unused imports errors.
2017-11-06 23:20:09 +01:00