Qubes/manager
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1,555 Commits 1 Branch 0 Tags 8.6 MiB
56528aaece
Commit Graph

1144 Commits

Author SHA1 Message Date
Marek Marczykowski-Górecki
db0e81a975
Merge remote-tracking branch 'origin/pr/248' 
* origin/pr/248:
  Added more description to applications in VM Settings
 2020-07-15 18:34:42 +02:00
Marek Marczykowski-Górecki
5322cfd1e3
Merge remote-tracking branch 'origin/pr/247' 
* origin/pr/247:
  Fixed overzealous firewall hostname checking
 2020-07-15 18:34:21 +02:00
Marta Marczykowska-Górecka
61d15dd783
Fixed some minor defaults errors in VM settings 2020-07-14 22:53:16 +02:00
Marta Marczykowska-Górecka
03c04cc93b
Fixed deprecated implicit conversion to int 2020-07-14 22:20:54 +02:00
Marta Marczykowska-Górecka
77b42e7c5a
Final improvements and cleanup to list widgets handling in manager 
Also removed old opaque prepare_choice functions and added
extensive docstrings.
 2020-07-14 22:19:43 +02:00
Marta Marczykowska-Górecka
fabd601f49
Added more description to applications in VM Settings 
Sometimes only the .desktop filename distinguishes between applications,
so now the tooltip will list that filename
 2020-07-14 21:22:41 +02:00
Marta Marczykowska-Górecka
f8c19ca984
Fixed overzealous firewall hostname checking 
Checking is now done only on the core-admin-client side; there's
no reason to reject rules that would be valid from core-admin-client side.

fixes QubesOS/qubes-issues#5943
 2020-07-14 19:57:34 +02:00
Marta Marczykowska-Górecka
2ae92dffc0
Refactored Create New VM for more readability 2020-07-09 21:38:23 +02:00
Marta Marczykowska-Górecka
f0a8241e0d
Refactored VM Settings for less ugliness 2020-07-09 19:26:31 +02:00
Marta Marczykowska-Górecka
ab5e3dcfea
Improved Global Settings with more readable widget handling 2020-07-08 22:31:50 +02:00
Marta Marczykowska-Górecka
31eb6f9df7
Added GUI daemon options to global settings 
fixes QubesOS/qubes-issues#2304
 2020-07-07 21:56:37 +02:00
Marta Marczykowska-Górecka
a41908f92f
Added gui daemon options to VM settings 
Added allow-fullscreen and allow-utf8-titles as options to VM settings

references QubesOS/qubes-issues#2304
 2020-07-07 21:47:13 +02:00
Marek Marczykowski-Górecki
a6a7560bab
Merge remote-tracking branch 'origin/pr/241' 
* origin/pr/241:
  Fixed max volume size in VM settings
 2020-06-28 05:23:40 +02:00
MSathieu
e18e9ee998
Don't reset template when changing type during qube creation 2020-06-23 12:33:04 +02:00
Marta Marczykowska-Górecka
37271db3d8
Fixed max volume size in VM settings 
Now it can be anything up to pool size.

fixes QubesOS/qubes-issues#5890
 2020-06-11 22:18:05 +02:00
Marek Marczykowski-Górecki
8a74e43dc3
Merge remote-tracking branch 'origin/pr/238' 
* origin/pr/238:
  Fixed VM settings test
 2020-06-07 04:40:28 +02:00
Marta Marczykowska-Górecka
310d583b2a
Fixed VM settings test 
Incorrect maxmem value caused error.

fixes QubesOS/qubes-issues#5857
 2020-05-28 19:31:25 +02:00
Marek Marczykowski-Górecki
2b69bf5599
Merge remote-tracking branch 'origin/pr/236' 
* origin/pr/236:
  Better error handling for opening VM settings in Qube Manager
 2020-05-27 04:20:09 +02:00
Marta Marczykowska-Górecka
683d75db31
Better error handling for opening VM settings in Qube Manager 
No more silent errors - the user will get an error message.

fixes QubesOS/qubes-issues#5810
 2020-05-26 22:22:11 +02:00
Marta Marczykowska-Górecka
deb9b323f2
Applications tab in VM settings now reacts to template change and handles missing entries 
On template change, qvm-appmenus is queried for changes in available apps.
If something is whitelisted and does not appear in the template, it is shown
in the list as "Application missing".

requires https://github.com/QubesOS/qubes-desktop-linux-common/pull/22
fixes QubesOS/qubes-issues5796
 2020-05-11 17:36:53 +02:00
Marta Marczykowska-Górecka
b058db4ccf
Fixed incorrect memory checking in VM Settings 
When a VM is not included in memory balancing, there is no point
(and it can be actively harmful via deception) in showing warnings
about init_mem and maxmem mismatch.

fixes QubesOS/qubes-issues#5306
 2020-04-06 15:31:00 +02:00
Marek Marczykowski-Górecki
f1ad829d71
Merge remote-tracking branch 'origin/pr/233' 
* origin/pr/233:
  Template should not be enabled for running VMs in VM Settings
  Show correct template for DispVMs VM Settings
 2020-03-28 04:21:58 +01:00
Marta Marczykowska-Górecka
96e75b350a
Template should not be enabled for running VMs in VM Settings 2020-03-26 16:51:41 +01:00
Marta Marczykowska-Górecka
08d1435eea
Show correct template for DispVMs VM Settings 
DispVMs should have a template listed from among vms with 'template_from_dispvm'
property, not from the normal available templates.

fixes QubesOS/qubes-issues#5746
 2020-03-26 16:50:25 +01:00
Marta Marczykowska-Górecka
5c82ad5a29
Added "Open console" action to Qube Manager 
The action uses qvm-console-dispvm.

fixes QubesOS/qubes-issues#4544
 2020-03-24 17:34:14 +01:00
Marek Marczykowski-Górecki
29df599968
Merge remote-tracking branch 'origin/pr/231' 
* origin/pr/231:
  Fixed tests for new debug mode location in VM settings
  Fixed bug in tests that leads to occassional timeouts on slow machines
 2020-03-15 13:03:52 +01:00
Marta Marczykowska-Górecka
cf601fbc66
Fixed tests for new debug mode location in VM settings 2020-02-28 18:58:20 +01:00
Marta Marczykowska-Górecka
92465f71e7
Fixed bug in tests that leads to occassional timeouts on slow machines 
fixes QubesOS/qubes-issues#5694
 2020-02-27 17:28:37 +01:00
Marek Marczykowski-Górecki
84ff5ffa09
Merge remote-tracking branch 'origin/pr/230' 
* origin/pr/230:
  Removed unnecessary 'needs restarting' icons for DisposableVMs in Qube Manager
 2020-02-17 04:04:40 +01:00
Marek Marczykowski-Górecki
2520952d76
Merge remote-tracking branch 'origin/pr/227' 
* origin/pr/227:
  Changed display of image sizes in VM settings to GB when sensible
 2020-02-17 04:02:04 +01:00
Marta Marczykowska-Górecka
9acb22fb1f
Removed unnecessary 'needs restarting' icons for DisposableVMs in Qube Manager 
fixes QubesOS/qubes-issues#5661
 2020-02-16 22:38:44 +01:00
Marta Marczykowska-Górecka
bd8fc05725
Changed display of image sizes in VM settings to GB when sensible 
For sizes above 1 GB, the sizes of private image and root image will be displayed
as %.1f GB; smaller sizes will be displayed as %d MB.

fixes QubesOS/qubes-issues#5592
 2020-02-09 17:17:48 +01:00
Marta Marczykowska-Górecka
0534ec6d15
Fixed init memory warning being shown twice 
Also fixed the init memory warning to only be shown for Linux qubes (it is
not necessary for other qubes)

fixes QubesOS/qubes-issues#5612
 2020-01-30 21:46:18 +01:00
Marek Marczykowski-Górecki
20da3a5854
Merge remote-tracking branch 'origin/pr/224' 
* origin/pr/224:
  Handle deleting in VM Settings without silent fails
 2020-01-16 04:41:37 +01:00
Marek Marczykowski-Górecki
848277ae4b
Merge remote-tracking branch 'origin/pr/223' 
* origin/pr/223:
  Fixed Apply behavior for VM Settings
 2020-01-16 04:39:39 +01:00
Marek Marczykowski-Górecki
acfdca3851
Merge remote-tracking branch 'origin/pr/221' 
* origin/pr/221:
  Fixed tab order
  Moved debug mode checkbox to advanced settings
  Added handling for supported services to VM settings
 2020-01-16 04:38:08 +01:00
Marta Marczykowska-Górecka
e17332d84c
Handle deleting in VM Settings without silent fails 
Deleting qube will now show a Delete in Progress dialog box and
not exit QApplication before QThread finishes.

fixes QubesOS/qubes-issues#5515
 2020-01-08 22:04:36 +01:00
Marta Marczykowska-Górecka
f4f76110f0
Fixed Apply behavior for VM Settings 
VM Setting will now update (current) markers correctly after Apply.

fixes QubesOS/qubes-issues#5531
 2020-01-08 21:20:27 +01:00
Marta Marczykowska-Górecka
4298de6564
Moved debug mode checkbox to advanced settings 
It really had no place in Basic settings, and will free up space for future
settings.
 2019-12-14 15:39:09 +01:00
Marta Marczykowska-Górecka
5f86660305
Added handling for supported services to VM settings 
Slight change to layout of services tab, made it hopefully
less confusing. Dropdown will now list services supported by this
VM and its template, not just an assortment of hardcoded services.
 2019-12-14 15:39:09 +01:00
Marek Marczykowski-Górecki
cca5d7d785
Merge remote-tracking branch 'origin/pr/219' 
* origin/pr/219:
  Fixed transifex integration
 2019-12-09 19:29:02 +01:00
Marta Marczykowska-Górecka
0329383453
Fixed transifex integration 
Corrected .tx/config file and added instructions on pulling/pushing translations
to transifex.

references QubesOS/qubes-issues#5410
references QubesOS/qubes-issues#3548
 2019-12-09 19:19:29 +01:00
Marek Marczykowski-Górecki
52727c898d
Merge remote-tracking branch 'origin/pr/220' 
* origin/pr/220:
  Use events instead of pulling for updates-available status
  settings: wrap direct network access warning
  tests: fix startup timeout and looking for logs
 2019-12-07 05:02:28 +01:00
Marek Marczykowski-Górecki
041adcfc1e
Use events instead of pulling for updates-available status 2019-12-05 22:59:24 +01:00
Marek Marczykowski-Górecki
ffcfb4e7cf
tests: fix startup timeout and looking for logs 
On OpenQA 20 isn't enough to start a VM. Also make sure previous
shutdown has finished by using qvm-shutdown --wait.

VM needs to be started at least once to have active "logs" submenu. For
this reason, choose a running VM.
 2019-12-04 21:05:45 +01:00
Marta Marczykowska-Górecka
0a1f12fb27
Fixed bug with Global Settings 
Incorrectly named variable caused crash on start.
 2019-11-30 13:37:33 +01:00
Marta Marczykowska-Górecka
2a73bfbb4c
Fixed bug in VM Settings 
Wrong variable name caused a crash on start
 2019-11-28 15:44:54 +01:00
Marek Marczykowski-Górecki
6886585d17
Merge remote-tracking branch 'origin/pr/216' 
* origin/pr/216:
  Add handling for backup in progress
 2019-11-16 15:42:38 +01:00
Frédéric Pierret (fepitre)
4c39d7bfc2
global_settings: copy env instead of global assignment 2019-11-12 22:49:09 +01:00
Marta Marczykowska-Górecka
b27c10f1d4
Add handling for backup in progress 
Shows a better error message when a given backup is already running.

fixes QubesOS/qubes-issues#5432
requires https://github.com/QubesOS/qubes-core-admin/pull/292
 2019-11-11 17:44:53 +01:00
Frédéric Pierret (fepitre)
51acbde8d5
_run_qrexec_repo: default C local in subprocess call 2019-11-11 17:08:19 +01:00
Frédéric Pierret (fepitre)
0bacf37994
global_settings: make PEP8 happy 2019-11-11 17:05:02 +01:00
Frédéric Pierret (fepitre)
2c132d9b83
utils: make PEP8 happy 2019-11-10 10:16:47 +01:00
Frédéric Pierret (fepitre)
044d91d73e
utils: get linux-kernels from storage API 2019-11-10 10:16:08 +01:00
Marek Marczykowski-Górecki
283ed2540c
Merge remote-tracking branch 'origin/pr/210' 
* origin/pr/210:
  Fixed translation for application names
  Added translation support to all untranslated qubesmanager files
  Re-enabled translation support for Qt5
 2019-11-09 15:32:18 +01:00
Marta Marczykowska-Górecka
b4cb9303bc
Fixed translation for application names 2019-11-09 00:50:44 +01:00
Malte Leip
5ba012b7d3
Fix KernelVersion comparisons 
In the __lt__ function for the class KernelVersions, if
self.groups != other.groups, but self.groups == other.groups[0:n] or
self.groups[0:n] == other.groups for some n, then at some point, one of
the two pieces to be compared will be None, which resulted in an
Exception when calling isdigit.

Hence check whether one of the pieces to be compared is None and handle
this as a special case.

(cherry picked from commit b901203390b4994a8169021d7dc47928561dad24)
 2019-11-07 04:18:37 +01:00
Marek Marczykowski-Górecki
fe56b3e0e7
Merge remote-tracking branch 'origin/pr/211' 
* origin/pr/211:
  Fixed VM settings warning labels
 2019-10-29 13:36:31 +01:00
Marta Marczykowska-Górecka
46952ebad2
Added translation support to all untranslated qubesmanager files 
references QubesOS/qubes-issues#5410
 2019-10-29 12:28:22 +01:00
Marta Marczykowska-Górecka
520cefa010
Fixed VM settings warning labels 
No netvm warning will now show differently for VMs that don't provide
network and those that do.
 2019-10-29 11:53:44 +01:00
Marta Marczykowska-Górecka
245534d886
Re-enabled translation support for Qt5 
Fixed obsolete source files, regenerated translation sources,
re-enabled translation loading in the programs themselves.
Also removed the completely obsolete block.py file. (It was not used anywhere)

references QubesOS/qubes-issues#5410
 2019-10-29 00:49:22 +01:00
Marta Marczykowska-Górecka
afad888343
Fixed error in selecting backup directory in GUI backup 
Also removed unused settings.

fixes QubesOS/qubes-issues#5430
 2019-10-29 00:30:09 +01:00
hexagonrecursion
42affe0da6
Remove redundant popups 2019-10-27 10:22:41 +00:00
Marek Marczykowski-Górecki
7bdcb23fb8
Fix erroneous usage of 'qubes' module 
On the client side it should use only 'qubesadmin'. In practice, those
few are trivial to replace:
 - get_disk_usage() is also available in shutil (as disk_usage())
 - BackupCancelledError should be used from qubesadmin.exc anyway (there
   was also a typo)

Remove also test-packages/qubes to let pylint detect such issues in the
future.

QubesOS/qubes-issues#5403
 2019-10-24 05:47:26 +02:00
Marek Marczykowski-Górecki
1dabce0f54
Merge remote-tracking branch 'origin/pr/205' 
* origin/pr/205:
  Added better exception handling on Backup Cancel
  Tests fixed for new features and bugfixes
  Removed not needed workaround for check-updates on dom0
  Fixed default install_system state for Create New VM
  Fixed manager tests to use Qt5
 2019-10-24 03:20:28 +02:00
Marta Marczykowska-Górecka
0d2d9970b7
Added better exception handling on Backup Cancel 
Qt segfaults when the reject method throws an unhandled
exception; fixed that.
 2019-10-24 00:29:04 +02:00
Marta Marczykowska-Górecka
4c2adbca00
Tests fixed for new features and bugfixes 
After switching to Qt5, a bunch of fixes and changes were introduced.
This fixes tests to take them into account.
 2019-10-17 22:33:08 +02:00
Marta Marczykowska-Górecka
74eba3bb7f
Removed not needed workaround for check-updates on dom0 
And fixed test referring to it.
 2019-10-17 00:29:10 +02:00
Marta Marczykowska-Górecka
6f73ef2163
Fixed manager tests to use Qt5 
Also due to old workarounds not working around anymore,
switched over to "single QApplication object" model.
 2019-10-15 01:28:04 +02:00
Marta Marczykowska-Górecka
0c10723205
Fixed incorrect QApplication start that led to missing icons 
Using QIcon object before initializing QApplication leads to
missing theme icons.

fixes QubesOS/qubes-issues#5354
 2019-10-06 21:55:11 +02:00
Marek Marczykowski-Górecki
12481fd561
Merge remote-tracking branch 'origin/pr/202' 
* origin/pr/202:
  Fixed change in QFileDialog behavior in PyQt5
 2019-09-30 03:51:46 +02:00
Marek Marczykowski-Górecki
fcec3d7464
Merge remote-tracking branch 'origin/pr/200' 
* origin/pr/200:
  Pylint fixes
  Code deduplication and cleanup
  Removed unused line in GUI Backup
 2019-09-30 03:51:44 +02:00
Marta Marczykowska-Górecka
442066d96c
Fixed change in QFileDialog behavior in PyQt5 
Return type of QFileDialog changed between PyQt4 and PyQt5.

fixes QubesOS/qubes-issues#5353
 2019-09-28 22:06:29 +02:00
Saswat Padhi
4ee3c556c4
Show the previous VM name while renaming 
Currently while renaming VMs, the default text is empty "". This change modifies this default text to the original name of the VM.
 2019-09-26 18:29:31 -07:00
Marta Marczykowska-Górecka
5d88e5f851
Pylint fixes 
Several minor fixes for updated pylint checker.
 2019-09-26 22:44:05 +02:00
Marta Marczykowska-Górecka
32078242c9
Code deduplication and cleanup 
Moved loop handling, exception handling and program
running methods of the gui tools to the utils file.

fixes QubesOS/qubes-issues#5342
 2019-09-26 22:31:39 +02:00
Marta Marczykowska-Górecka
8a3653723d
Removed unused line in GUI Backup 
File selection dialog in GUI backup was using an obsolete
(and possibly never working as intented) setReadOnly method.
Removed it, because it neither works nor is needed.

fixes QubesOS/qubes-issues#5348
 2019-09-26 21:37:32 +02:00
Marek Marczykowski-Górecki
bdf0951c52
Merge remote-tracking branch 'origin/pr/198' 
* origin/pr/198:
  Fixed new firewall rule window
 2019-09-23 03:48:09 +02:00
Marek Marczykowski-Górecki
0dc73fd618
Merge remote-tracking branch 'origin/pr/196' 
* origin/pr/196:
  Added an Advanced tab to Create New Qube dialog
 2019-09-23 03:48:07 +02:00
Marta Marczykowska-Górecka
d85940c5a5
Added an Advanced tab to Create New Qube dialog 
Tab contains a warning, provides_network checkbox,
install_system_after_creation checkbox, storage pool settings
and initial RAM.

references QubesOS/qubes-issues#5127
fixes QubeSOS/qubes-issues#5198
 2019-09-20 17:59:23 +02:00
Marta Marczykowska-Górecka
2e152b8dfb
Fixed new firewall rule window 
Now, an error will not close the window, enabling
the user to correct any mistakes.

fixes QubesOS/qubes-issues#bugfix5234
 2019-09-20 17:50:31 +02:00
Marek Marczykowski-Górecki
b0d5263d5e
Merge remote-tracking branch 'origin/pr/199' 
* origin/pr/199:
  Improved display of default disposable VM in Qube Manager
  Qube Manager now reacts to changing some global properties
 2019-09-20 02:10:15 +02:00
Marta Marczykowska-Górecka
2d644c371f
Improved display of default disposable VM in Qube Manager 
Now 'default' value will be correctly shown as default (vm name).
 2019-09-19 01:45:32 +02:00
Marta Marczykowska-Górecka
9aeacce9c5
Qube Manager now reacts to changing some global properties 
Properties checked are: default_netvm and default_dispvm. Qube Manager
will now properly update displayed values.

fixes QubesOS/qubes-issues#5328
 2019-09-19 01:45:32 +02:00
Marta Marczykowska-Górecka
df9576a0f1
Fixed UI error 
Qube Manager columns did not resize correctly in Qt5.

fixes QubesOS/qubes-issues#5278
 2019-09-06 16:31:27 +02:00
Marek Marczykowski-Górecki
c32d63df58
Merge remote-tracking branch 'origin/pr/181' 
* origin/pr/181:
  Add tooltip to application list in VM settings
 2019-08-28 16:50:23 +02:00
Marek Marczykowski-Górecki
1edf363efe
Merge remote-tracking branch 'origin/pr/172' 
* origin/pr/172:
  Say which repository caused the error in warnings
  Only make qrexec calls when necessary
  Squash more PyLint warnings
  Decode stderr in repo qrexec calls
  Fix error handling
  Fix `self` being undefined when showing warnings
  Only apply repo preferences when "OK" is clicked
  Don't use asserts for error handling
  Check that repo management succeeded
  Remove unnecessary assert
  Squash some PyLint warnings
  Add UI for managing Qubes update repositories
  Fix typo

Fixes QubesOS/qubes-issues#4550
 2019-08-28 16:42:01 +02:00
Marek Marczykowski-Górecki
1e3c0bfcd8
Merge remote-tracking branch 'origin/pr/194' 
* origin/pr/194:
  Fix arithmetic in init/max mem ratio correction
 2019-08-28 15:52:22 +02:00
Marek Marczykowski-Górecki
6107a1fcbf
Merge remote-tracking branch 'origin/pr/192' 
* origin/pr/192:
  Added virt mode column to Qube Manager
 2019-08-28 15:50:29 +02:00
Marek Marczykowski-Górecki
b4b3588bf1
Minor fix qt4 -> qt5 
Pylint detected one more missing QtGui->QtWidgets change.
 2019-08-28 15:48:29 +02:00
Marek Marczykowski-Górecki
990e4abbbf
Merge remote-tracking branch 'origin/pr/178' 
* origin/pr/178:
  Update Qt version used in qubesmanager to Qt5
 2019-08-28 15:19:26 +02:00
Aras Ergus
bbe14f524d
Fix arithmetic in init/max mem ratio correction 
Qubes Manager seems to try to guarantee that 10*init_mem is at
least max_mem by automatically adjusting init_mem to max_mem/10 if
inappropriate values are set. However, this may not guarantee that
10*init_mem >= max_mem due to rounding errors. This change fixes
these edge cases by basically rounding up the result of division
by 10.
 2019-08-17 15:42:36 +02:00
Marek Marczykowski-Górecki
3c9d7d3da4
firewall: service name can contain digits too 2019-08-10 03:54:35 +02:00
Marta Marczykowska-Górecka
dedde71d7a
Fixed bug with port numbers and services in VM settings 
Opening an existing FW rule resulted in an invalid port number.
 2019-08-09 14:16:30 +02:00
Marta Marczykowska-Górecka
1cd95fceb2
Added virt mode column to Qube Manager 
Just another column that shows the
contents of virt_mode property.

fixes QubesOS/qubes-issues#4702
 2019-08-08 17:30:15 +02:00
Marek Marczykowski-Górecki
d5a4ddb7ef
Merge remote-tracking branch 'origin/pr/191' 
* origin/pr/191:
  Fixed parsing port ranges in VM settings
  Better handling of port/service names for VM settings
 2019-08-02 20:03:35 +02:00
Marta Marczykowska-Górecka
1d7d51eafd
Fixed parsing port ranges in VM settings 
Now service names with dash ('-') in them will be parsed
correctly and not result in an error.

fixes QubesOS/qubes-issues#4766
 2019-08-02 16:58:30 +02:00
Marta Marczykowska-Górecka
6cd02b47b3
Better handling of port/service names for VM settings 
Now port will be displayed as port_number [(service name)]
, and not just service name. Also added a tooltip with explanation
of what can be put in the 'port/service' field, renamed
the field to 'Port/service' and added some examples of pure port
numbers to the drop down.

fixes QubesOS/qubes-issues#5211
 2019-08-02 16:39:51 +02:00
Marta Marczykowska-Górecka
31e3f72ae0
Kernel sorting fix 
Fixed bug with kernel versions ending with a letter,
hopefully now the sorting is even more robust and sensible.

fixes QubesOS/qubes-issues#5208
 2019-07-31 23:00:00 +02:00
Marek Marczykowski-Górecki
1dadca8ed8
Merge remote-tracking branch 'origin/pr/189' 
* origin/pr/189:
  Better settings for a newly created VM
  Changed checking for VM name in use
 2019-07-31 17:29:00 +02:00