Commit Graph

83 Commits

Author SHA1 Message Date
Marta Marczykowska-Górecka
77b42e7c5a
Final improvements and cleanup to list widgets handling in manager
Also removed old opaque prepare_choice functions and added
extensive docstrings.
2020-07-14 22:19:43 +02:00
Marta Marczykowska-Górecka
b27c10f1d4
Add handling for backup in progress
Shows a better error message when a given backup is already running.

fixes QubesOS/qubes-issues#5432
requires https://github.com/QubesOS/qubes-core-admin/pull/292
2019-11-11 17:44:53 +01:00
Marek Marczykowski-Górecki
283ed2540c
Merge remote-tracking branch 'origin/pr/210'
* origin/pr/210:
  Fixed translation for application names
  Added translation support to all untranslated qubesmanager files
  Re-enabled translation support for Qt5
2019-11-09 15:32:18 +01:00
Marta Marczykowska-Górecka
b4cb9303bc
Fixed translation for application names 2019-11-09 00:50:44 +01:00
Marta Marczykowska-Górecka
46952ebad2
Added translation support to all untranslated qubesmanager files
references QubesOS/qubes-issues#5410
2019-10-29 12:28:22 +01:00
Marta Marczykowska-Górecka
afad888343
Fixed error in selecting backup directory in GUI backup
Also removed unused settings.

fixes QubesOS/qubes-issues#5430
2019-10-29 00:30:09 +01:00
Marek Marczykowski-Górecki
7bdcb23fb8
Fix erroneous usage of 'qubes' module
On the client side it should use only 'qubesadmin'. In practice, those
few are trivial to replace:
 - get_disk_usage() is also available in shutil (as disk_usage())
 - BackupCancelledError should be used from qubesadmin.exc anyway (there
   was also a typo)

Remove also test-packages/qubes to let pylint detect such issues in the
future.

QubesOS/qubes-issues#5403
2019-10-24 05:47:26 +02:00
Marek Marczykowski-Górecki
1dabce0f54
Merge remote-tracking branch 'origin/pr/205'
* origin/pr/205:
  Added better exception handling on Backup Cancel
  Tests fixed for new features and bugfixes
  Removed not needed workaround for check-updates on dom0
  Fixed default install_system state for Create New VM
  Fixed manager tests to use Qt5
2019-10-24 03:20:28 +02:00
Marta Marczykowska-Górecka
0d2d9970b7
Added better exception handling on Backup Cancel
Qt segfaults when the reject method throws an unhandled
exception; fixed that.
2019-10-24 00:29:04 +02:00
Marta Marczykowska-Górecka
0c10723205
Fixed incorrect QApplication start that led to missing icons
Using QIcon object before initializing QApplication leads to
missing theme icons.

fixes QubesOS/qubes-issues#5354
2019-10-06 21:55:11 +02:00
Marta Marczykowska-Górecka
5d88e5f851
Pylint fixes
Several minor fixes for updated pylint checker.
2019-09-26 22:44:05 +02:00
Marta Marczykowska-Górecka
32078242c9
Code deduplication and cleanup
Moved loop handling, exception handling and program
running methods of the gui tools to the utils file.

fixes QubesOS/qubes-issues#5342
2019-09-26 22:31:39 +02:00
Marta Marczykowska-Górecka
e79724f9db
Update Qt version used in qubesmanager to Qt5
Fixed dependencies, places where obsolete functions stopped working,
code fragments that started throwing warnings and an .ui file that
stopped being readable after the update.
2019-05-30 21:33:49 +02:00
Marta Marczykowska-Górecka
597a3e728f
fix incorrect behavior after backup error
the Backup Qubes tool failed to allow user to exit correctly
after backup errored out in any way.

fixes QubesOS/qubes-issues#4885
2019-03-20 23:34:19 +01:00
Marta Marczykowska-Górecka
60f62ff7cf
More consistent 'include_in_backups' behavior
Instead of always selecting for backup all the VMs that were selected
during last saved backup, now the GUI tool will disregard last selected
VMs and instead use VM attribute 'include_in_backups'

fixes QubesOS/qubes-issues#4713
2019-01-16 20:43:08 +01:00
Marta Marczykowska-Górecka
f047a56906
Fixed Backup tool's QT bug
Exiting the program was handled incorrectly.

fixes QubesOS/qubes-issues#4677
2019-01-16 20:21:46 +01:00
donoban
6fdf16278e
wait thread to finish when aborting 2018-11-25 18:53:31 +01:00
donoban
f477084bfe
Don't terminate backup thread when aborting 2018-11-25 18:49:02 +01:00
donoban
60af90ec5f
Adding # pylint: disable=too-few-public-methods 2018-10-22 10:14:26 +02:00
donoban
831769d2dd
Fix travis build 2018-10-20 23:01:35 +02:00
donoban
11cc8b7a67
Remove debug print 2018-10-20 19:20:39 +02:00
donoban
29ca4eb3a8
Migration from python threads and to QThread obj
Simple design and better performance, just start() thread and finished
call back will show any error or msg, stop progress dialog and do cleanup.

Full remove of QT process_events() calls.
2018-10-20 18:34:15 +02:00
Marta Marczykowska-Górecka
9d16bec870
Pylint whitespace fix
Removed superfluous whitespace.
2018-07-12 23:31:30 +02:00
Marta Marczykowska-Górecka
80b3a82963
Add option to turn off computer after backup to Backup GUI
A simple checkbox to turn off the computer after backup finishes
successfully. It is off by default and must be switched on every time
(unexpected system shutdowns are a huge pain, much more problematic
than forgetting to shut down can be).

fixes QubesOS/qubes-issues#2039
2018-07-12 22:47:02 +02:00
Marta Marczykowska-Górecka
dc0f8c0a9e
Fixed bug 3594
Incorrect targetVM display - dom0 was not included, and the code
erroneously assumed that not only it is included, but also it's always
the first in the dropdown. No more assumptions.

fixes QubesOS/qubes-issues#3594
2018-02-20 19:22:57 +01:00
Marta Marczykowska-Górecka
bb8abff988
Suggested changes
included changes as suggested by @marmarek.
2018-01-06 02:21:07 +01:00
Marta Marczykowska-Górecka
df31207028
Final tiny fix of unused import
Threw out unused import of shutil.
2017-12-11 02:41:50 +01:00
Marta Marczykowska-Górecka
67a32b5748
Added 'compression' checkbox to backup GUI
Added 'compress the backup' checkbox to the backup GUI.

fixes QubesOS/qubes-issues#943
2017-12-11 02:37:50 +01:00
Marta Marczykowska-Górecka
7fd0c58303
Restored 'cancel' functionality
Now user can actually cancel a backup/restore.
2017-12-11 02:28:15 +01:00
Marta Marczykowska-Górecka
14ebf9dc6d
Fixed opening file dialog at the end
Now, when "open file dialog to unmount" option is enabled, a fie dialog
actually opens.
2017-12-11 02:07:10 +01:00
Marta Marczykowska-Górecka
a4a58cc527
Fixed progress bars
Partial fix - the progress bars now move, although they do not really
indicate progress (just dance back and forth). Future fix would include
making a tray icon to signal backup progress instead.
2017-12-11 01:32:26 +01:00
Marta Marczykowska-Górecka
78b4747e81
Second pylint pass
Fixed errors pointed out by pylint on server.
2017-12-11 01:15:07 +01:00
Marta Marczykowska-Górecka
a1c6e72569
First pylint pass
Fixed errors pointed out by pylint.
2017-12-11 00:56:27 +01:00
Marta Marczykowska-Górecka
4e2835531e
Usability fixes
Added label to inform the user only running VMs are listed in backup
GUI; made "ignore missing" label clearer.
2017-12-11 00:13:15 +01:00
Marta Marczykowska-Górecka
7bcde2158e
Added optional saving of default backup profile
Added checkbox for saving default backup profile. Removed useless "should I encrypt" checkbox (yes, you have to encrypt).
2017-12-10 23:19:16 +01:00
Marta Marczykowska-Górecka
9d73ceb99d
Fixed imports
Fixed import * and unused imports.
2017-12-10 22:11:07 +01:00
Marta Marczykowska-Górecka
7a4e4b35d5
Initial backup-and-restore GUI restoration
Initial restoration: basic backup-and-restore works, but
- progress bar in backup does not work
- selecting only some VMs to restore does not work
- various miscellaneous enhancements are not yet in place
2017-12-10 21:14:14 +01:00
Marta Marczykowska-Górecka
3009610a62
Fixed GPL license
Replaced old, address-having, too-many-characters-in-a-line version with
the new one with URL.
2017-11-06 21:06:30 +01:00
Marta Marczykowska-Górecka
41b602ec48
Initial setup
Initialize .pylintrc, put ignore in used files' headers.
2017-11-06 20:36:09 +01:00
Wojtek Porczyk
2c3df7bd67 spring cleaning part 5: more python3 fixes 2017-07-12 14:54:14 +02:00
Marta Marczykowska-Górecka
fb3dc6ecf7
update qubesmanager to compile under python3.
note: qvm-net.py has changed location to a weird one.
2017-06-25 17:53:23 +02:00
Jean-Philippe Ouellet
2f72aaf05f
Add more missing unicode()s around .tr()s
Fixes https://github.com/QubesOS/qubes-issues/issues/2637
2017-02-19 21:49:03 -05:00
Marek Marczykowski-Górecki
d073b3582d
i18n: wrap self.tf in unicode() where 'format' function is used
Qstring (returned by self.tr) does not have 'format' method.

Fixes QubesOS/qubes-issues#2599
2017-02-06 04:20:13 +01:00
Marek Marczykowski-Górecki
7c602bf7d2
i18n: wrap strings with self.tr
Allow translations to handle strings defined in code.

Fixes QubesOS/qubes-issues#2599
2017-01-22 13:22:26 +01:00
unman
0f1e7bb352
Sort items in Backup selection dialog 2017-01-05 02:58:03 +00:00
Marek Marczykowski-Górecki
6b7b07acb8 backup: allow backup templates, even when installed by rpm 2015-03-31 05:44:37 +02:00
Marek Marczykowski-Górecki
5e925b23d4 backup+restore: remove an option to attach disk from a VM to dom0
This is (intentionally) not possible in R3. The user can choose to
backup directly to the VM, encrypting the backup in dom0 first.
2015-03-31 05:40:53 +02:00
Wojciech Zygmunt Porczyk
e9f1bb3880 *.py: Use full paths when calling subprocess.Popen().
Also removed unneeded imports of subprocess.
2014-05-22 15:07:35 +02:00
Marek Marczykowski-Górecki
c2038ec20b backups: open file selection dialog at the end for unmounting the disk (#831) 2014-05-15 03:06:51 +02:00
Marek Marczykowski-Górecki
b4dcf0ceb4 backups: fix get_disk_usage usage
It isn't member of QubesVm anymore
2014-05-05 02:14:24 +02:00