Commit Graph

264 Commits

Author SHA1 Message Date
Marta Marczykowska-Górecka
6cf0e83b1d
Fixed device list behavior for a running VM in VM settings
PCI devices will now correctly be unmodifiable if the VM is running.

fixes QubesOS/qubes-issues#4933
2019-04-02 22:16:55 +02:00
donoban
34adc75752
Moved busy_cursor() inside save_changes() 2019-03-31 20:04:04 +02:00
donoban
c85d6e4e8b
Removed unneded calls to Override/Restore cursor 2019-03-31 20:01:38 +02:00
donoban
16f2997222
Removed duplicated call to save_changes() 2019-03-31 19:59:55 +02:00
donoban
1fbf6c9a59
Removed unneeded Cursor override/restore 2019-03-31 19:58:52 +02:00
donoban
8e383e3022
Added busy_cursor()
fix https://github.com/QubesOS/qubes-issues/issues/4744
2019-03-31 19:56:01 +02:00
donoban
8816a764ee
Merge remote-tracking branch 'upstream/master' 2019-03-17 17:09:13 +01:00
Marta Marczykowska-Górecka
1c06d241f0
Fix bug with fixed bug in VM Settings
fixes QubesOS/qubes-issues#4866
2019-03-11 22:02:32 +01:00
Marta Marczykowska-Górecka
e556c8f848
Fix bug with VM Settings
Bug related to previous fixes to 'apply'; part of the code still
incorrectly assumed some attributes may not exist

fixes QubesOS/qubes-issues#4866
2019-03-09 16:45:22 +01:00
donoban
6469dd8341
Merge remote-tracking branch 'upstream/master' 2019-03-06 21:59:56 +01:00
Marek Marczykowski-Górecki
7874aa73fe
Merge remote-tracking branch 'origin/pr/158'
* origin/pr/158:
  Fixed error in displaying error on VM Rename
2019-02-26 23:12:35 +01:00
Marta Marczykowska-Górecka
26779a4826
Fixed error in displaying error on VM Rename
VM rename was incorrectly trying to display an error by itself and not
use QThreads embedded mechanism.

fixes QubesOS/qubes-issues#4843
fixes QubesOS/qubes-issues#4767
2019-02-26 21:10:22 +01:00
Marek Marczykowski-Górecki
94cefc9d09 Merge remote-tracking branch 'qubesos/pr/157'
* qubesos/pr/157:
  Fixed error in detecting dvm-template having different NetVM
2019-02-26 19:50:21 +01:00
Marek Marczykowski-Górecki
74987f6554 Merge remote-tracking branch 'qubesos/pr/156'
* qubesos/pr/156:
  Fixed incorrect behavior after 'Apply' in Settings
2019-02-26 19:49:04 +01:00
Marta Marczykowska-Górecka
b31a154e32
Fixed error in detecting dvm-template having different NetVM
when the currect VM is the same as the dvm_template, there should be no
warning

fixes QubesOS/qubes-issues#4844
2019-02-26 19:31:41 +01:00
Marta Marczykowska-Górecka
d23dafed28
Fixed incorrect behavior after 'Apply' in Settings
Changes in some fields (to be precise, drop-downs) were discarded
in VM Settings when changed after an 'Apply' and before an 'OK'.

fixes QubesOS/qubes-issues#4833
2019-02-26 18:02:36 +01:00
Marek Marczykowski-Górecki
9afa6faca0
Merge remote-tracking branch 'origin/pr/151'
* origin/pr/151:
  Added "set as dvm template" to VM settings
2019-02-23 18:40:07 +01:00
Marta Marczykowska-Górecka
ef6288f1ff
Added "set as dvm template" to VM settings
Added an 'Advanced' settings checkbox that allows the user to set a given
VM as template fo dispvms. It sets both the template_for_dispvms property
and the appmenus-dispvm feature - instead of delving into particulars
of how and which should be set, the user can just turn off the
whole setting if they want to make some changes in the vm and then turn
it on again.

fixes QubesOS/qubes-issues#4004
2019-02-23 18:27:22 +01:00
Marta Marczykowska-Górecka
faae2d0026
Added warning when setting NetVM
When NetVM is set to something else than default_dispvm has set, a warning
icon appears.
2019-02-19 22:27:28 +01:00
donoban
17fdb3c263
Added BusyCursor for notify manager is working
https://github.com/QubesOS/qubes-issues/issues/4744
2019-02-19 21:58:33 +01:00
donoban
56cc6c79e5
Revert "Added progress bar to __save_changes__"
This reverts commit bb7b8c79ae.
2019-02-19 21:46:38 +01:00
donoban
dda98610d5
Revert "Increase progress wait time to 2s"
This reverts commit 0e9f8d4c45.
2019-02-19 21:46:17 +01:00
donoban
0e9f8d4c45
Increase progress wait time to 2s 2019-02-17 20:37:16 +01:00
donoban
bb7b8c79ae
Added progress bar to __save_changes__ 2019-02-16 15:56:46 +01:00
donoban
a9a2022206
Remove unneeded slot connections and reject overwrite 2019-02-16 15:54:22 +01:00
Marek Marczykowski-Górecki
52188318b8
Enable seamless mode buttons for Windows template-based qubes too
Fixes QubesOS/qubes-issues#4813
2019-02-12 22:23:38 +01:00
Marta Marczykowska-Górecka
60944bb2fd
Fix error on warning in Settings on Rename VM
fixes QubesOS/qubes-issues#4745
2019-01-21 19:53:12 +01:00
Marta Marczykowska-Górecka
470390d789
Added explanatory tooltip to root resize
If system storage cannot be resized (due to belonging to an AppVM), the
system storage max field is grayed out without explanation; now it
will have a tooltip.

fixes QubesOS/qubes-issues#4617
2018-12-28 17:13:39 +01:00
Marta Marczykowska-Górecka
9727a0938b
Changed handling of maxmem/memory balancing in VM Settings
According to changes in 4dc8631010 ,
memory balancing is now handled not by a special service but by
magic value of 0 maxmem. Added handling thereof to VM Settings -
also, settings will store the last used maxmem value in
qubesmanager.maxmem_value feature.

fixes QubesOS/qubes-issues#4480
2018-12-18 16:40:51 +01:00
Marta Marczykowska-Górecka
f0357623e6
Refresh Apps in vm settings now refreshes the vm and template both
requires e26debfe97

fixes QubesOS/qubes-issues#4383
2018-11-30 21:47:15 +01:00
Marek Marczykowski-Górecki
334fefe559
Merge remote-tracking branch 'origin/pr/132'
* origin/pr/132: (48 commits)
  Fixed unreachable code thanks to travis
  Clear searchbox pressing esc without need of selecting it
  Fix errors when some domain fails to start
  wait thread to finish when aborting
  Don't terminate backup thread when aborting
  Fix iterating and removing over list
  Use 'qube' instead 'Qube'
  Qube -> qube
  Catch possible KeyError when starting dispVM
  Fix authorship and python version
  Create backup_window on the stack
  Removed sigchld_handler old code
  Fix pylint
  Do not terminate the thread
  Fix error/success message on dialog
  Fix opening settings/boot dialog after VM creation
  Add pylint disable too-few-methods
  Fix travis errors
  Removed unused import
  Workaround for backup dialog modeless behaviour
  ...
2018-11-28 01:13:48 +01:00
donoban
fd845a1219
Fixed unreachable code thanks to travis 2018-11-25 19:33:16 +01:00
donoban
22a9823871
Fix iterating and removing over list
Return after removing and raise exception if removable item not found
2018-11-25 18:37:34 +01:00
Marta Marczykowska-Górecka
65b50c0f3b
Added GUI for toggling of seamless mode for windows
Added two buttons to enable/disable seamless mode
for windows qubes.

references QubesOS/qubes-issues#3585
references QubesOS/qubes-issues#4342
2018-10-23 22:51:28 +02:00
donoban
edb13aec17
Thread.error renamed to Thread.msg
Since it could be used for both error or sucess
messages, I think msg is a better name
2018-10-22 20:00:37 +02:00
donoban
60af90ec5f
Adding # pylint: disable=too-few-public-methods 2018-10-22 10:14:26 +02:00
donoban
4aea47c9f7
... 2018-10-21 22:52:52 +02:00
donoban
df15c4e3ae
Fix pylint warnings and errors 2018-10-21 22:38:41 +02:00
donoban
a7537a323a
Wops
I did not notice on my pylint because it complains about all imports
2018-10-21 00:16:23 +02:00
donoban
c46b38ab42
Travis3 2018-10-21 00:06:37 +02:00
donoban
f93908f5b7
Fix travis build2 2018-10-20 23:23:06 +02:00
donoban
831769d2dd
Fix travis build 2018-10-20 23:01:35 +02:00
donoban
38051ad243
Fixes in ProgressDialogs and settings window close 2018-10-20 22:09:39 +02:00
donoban
ad1bcc55b9
Deleted unneded method _clone_vm() 2018-10-20 21:25:13 +02:00
donoban
29ca4eb3a8
Migration from python threads and to QThread obj
Simple design and better performance, just start() thread and finished
call back will show any error or msg, stop progress dialog and do cleanup.

Full remove of QT process_events() calls.
2018-10-20 18:34:15 +02:00
Marta Marczykowska-Górecka
4ff111eb81
Changed blank kernelopts in VM settings from [] to -
as requested by @marmarek
2018-09-27 21:34:56 +02:00
Marta Marczykowska-Górecka
bc15ef91ec
Fixed kernelopts in VM settings
For some reason, they were not being displayed at all. Now fixed.

fixes QubesOS/qubes-issues#4188
2018-09-21 14:09:07 +02:00
Marta Marczykowska-Górecka
5e52b16fd3
Minor changes as requested
Minor changes as requested by @marmarek
2018-07-20 17:48:39 +02:00
Christopher Laprise
b2fdbb950a
Handling VM dependencies in GUI tools
Added the following reactions ot VM dependencies in GUI tools:
- Qube Manager will inform the user why they cannot delete a VM (which
properties of which VMS [or global] are using the VM)
- Settings window will try to intelligently rename VMs (change
properties to the new name, if possible, and inform the user what went
wrong if not)
- Settings window will inform the user why they cannot delete a VM
Also, renaming VM from Settings launched from Qube Manager will
refresh the VM list through a horrible hack, to be replaced by a neater
Admin API solution in some near future.

depends on ca848ca7bd

fixes QubesOS/qubes-issues#3992
fixes QubesOS/qubes-issues#3993
fixes QubesOS/qubes-issues#3892
fixes QubesOS/qubes-issues#3499
2018-07-20 00:03:37 +02:00
Marek Marczykowski-Górecki
f62aeb51d6
Merge remote-tracking branch 'qubesos/pr/116'
* qubesos/pr/116:
  Add a list of Suggested Services to VM settings
2018-07-16 13:52:47 +02:00
Marta Marczykowska-Górecka
6f4870bc8d
Changes to for pylint 2.0
Fixes to make pylint 2.0 stop complaining.
2018-07-16 02:17:48 +02:00
Marta Marczykowska-Górecka
63a202f3bd
Add a list of Suggested Services to VM settings
Added a list of suggested services to the Services tab in VM Settings.
The list is drawn from man qvm-services (manually, not automatically).

fixes QubesOS/qubes-issues#3891
2018-07-16 01:33:20 +02:00
Marta Marczykowska-Górecka
3f0af4498c
Fixed VM name validation in GUI tools (Create VM, Settings, Manager)
VM name validation in various places in Manager did not allow a
perfectly legal '_' character.

references QubesOS/qubes-issues#2422
2018-07-13 21:05:00 +02:00
Marek Marczykowski-Górecki
7a5c304c1e
Merge remote-tracking branch 'qubesos/pr/95'
* qubesos/pr/95:
  Revert last and removed pylint disables
  Added BaseException
  Show updates pending while running domain
  Fix search coherence when adding a domain
  Last no-member
  Try with disable=no-member
  Another try for travis
  Disable no-name-in-module
  Fix pylint warnings
  Fix very unlikely case when user right clicks the VM in the exact moment he deletes it.
  Don't close the settings window if something failed when renaming e.g. the VM name already exists
  Revert "Since __lt__ methods are safe, is not needed to stop and reenable sorting."
  Added standalone VM's to check_updates() Also added an initial call when creating the timer, most users will look for updates inmediately after start the manager
  Since __lt__ methods are safe, is not needed to stop and reenable sorting. It causes a short freeze of the main window when reenabling, so better removing it.
  Added try/except for all __lt__() methods since some VM could be deleted before the signal is received and handled.
2018-06-27 03:07:46 +02:00
Marta Marczykowska-Górecka
8de26419c1
Fixed a bug with warnings not modal in VM Settings
Warnings and error messages in VM settings were not
modal and thus could be erroneously hidden.

fixes QubesOS/qubes-issues#3959
2018-06-12 22:50:03 +02:00
donoban
cb5bc16948
Don't close the settings window if something failed when renaming
e.g. the VM name already exists
2018-05-31 00:39:34 +02:00
Marta Marczykowska-Górecka
d3bd164e2f
Tiny fix to make pylint stop complaining 2018-05-17 19:58:44 +02:00
Marta Marczykowska-Górecka
744ddfcc80
Fixes unwanted behavior in VM settings
Whenever Enter was pressed, the Settings window
closed and applied changes, which was very unintuitive
especially in case of Services tab.

references QubesOS/qubes-issues#3891
2018-05-17 19:41:20 +02:00
Marta Marczykowska-Górecka
8218f5fde1
Added 'Apply' button to VM Settings
Simple "Apply" button.

fixes QubesOS/qubes-issues#3321
2018-02-20 20:32:00 +01:00
Marek Marczykowski-Górecki
83936ba93e
Merge remote-tracking branch 'qubesos/pr/66'
* qubesos/pr/66:
  Fixed incorrect default dispvm settings
2018-02-10 23:35:12 +01:00
Marta Marczykowska-Górecka
8da0d35110
Fixed incorrect default dispvm settings
Fixed error in DispVM selection in VM settings

fixes QubesOS/qubes-issues#3565
2018-02-10 22:54:00 +01:00
Marta Marczykowska-Górecka
0ec3c704dd
Fixed bug with template selection
Template in VM settings was not displayed correctly. It should work now.
2018-02-06 15:38:20 +01:00
Marta Marczykowska-Górecka
2be8f8bcea
Fixed errors with virt mode choice
Current virtualization mode wasn't displayed correctly. It should work now.

fixes QubesOS/qubes-issues#3517
2018-02-06 15:31:17 +01:00
Marta Marczykowska-Górecka
3a60f9146a
Renamed 'VM' to 'qube' everywhere in manager
At least I hope it's everywhere.
Note: AppVM and NetVM nomenclature have been kept as before.
2018-01-28 20:26:29 +01:00
Marek Marczykowski-Górecki
81413907bf
Merge remote-tracking branch 'qubesos/pr/55'
* qubesos/pr/55:
  Fixed according to @marmarek request
  Fixed according to @marmarek request
  Added 'configure no strict reset for PCI devices' button
  Adding a button to list PCI devices and enable no-strict-reset
  Fixed some indents and whitespaces
  Fixed python2 in settings.py
2018-01-19 03:01:57 +01:00
Marta Marczykowska-Górecka
b158aeccbd
Fixed according to @marmarek request 2018-01-19 02:50:04 +01:00
Marta Marczykowska-Górecka
1b9737c1a7
Fixed according to @marmarek request 2018-01-19 01:48:46 +01:00
Marta Marczykowska-Górecka
03ba645009
Fixed according to @marmarek request 2018-01-19 01:24:11 +01:00
Marta Marczykowska-Górecka
484f724838
Fixes to make pylint stop complaining 2018-01-17 12:13:04 +01:00
Marta Marczykowska-Górecka
48c3bfa798
Merge branch 'master' into virt-mode-select-fixes 2018-01-16 20:04:16 +01:00
Marta Marczykowska-Górecka
1a5a1fa7ee
Minor fixes to virt_mode select pull request
Changes:
- added hints about "which virt mode should I use"
- changed displayed virt modes to show modes in all caps

closes #44
2018-01-16 19:56:45 +01:00
Marta Marczykowska-Górecka
801014f2e5
Added 'configure no strict reset for PCI devices' button
The button is in 'devices' tab of VM settings; it allows the user to
select which devices should have 'no-strict-reset' enabled and tells
the user not to change this setting if there are no errors.

fixes QubesOS/qubes-issues#3205
2018-01-13 00:25:48 +01:00
Marta Marczykowska-Górecka
f4fae54057
Adding a button to list PCI devices and enable no-strict-reset 2018-01-13 00:25:46 +01:00
Marta Marczykowska-Górecka
60143e6a91
Fixed some indents and whitespaces
Fixed indents and whitespace that pylint was complaining about.
2018-01-13 00:25:02 +01:00
Marta Marczykowska-Górecka
ec3d6eb84a
Fixed python2 in settings.py
settings.py was erroneously using python2. Replaced with python3.
2018-01-13 00:19:58 +01:00
Marta Marczykowska-Górecka
670c41e4ff
Fixed minor error in VM Settings
When init page was 'firewall', the tool incorrectly displayed warnings about wrong firewall vm configuration, without actually checking if they should be displayed.
2018-01-12 04:30:47 +01:00
Marta Marczykowska-Górecka
5b19c825e3
Enabled Firewall config without a netvm
Enabled Firewall tab even when there's no working netvm or the netvm
doesn't support qubes-firewall. An appropriate warning label and message
are shown in both cases.

fixes QubesOS/qubes-issues#3290
2017-11-20 14:20:01 +01:00
Marta Marczykowska-Górecka
5f1e4803fe
Applied corrections from @marmarek 2017-11-17 17:42:19 +01:00
Marta Marczykowska-Górecka
135060dfe7
Final corrections
Errors that my local pylint ignored and travis' pylint didn't.
2017-11-14 15:44:43 +01:00
Marta Marczykowska-Górecka
8b296fab0d
Disable too-many-attributes warning
It's the settings window, it has a lot of attributes.
2017-11-09 17:41:10 +01:00
Marta Marczykowska-Górecka
95599dff9f
A bunch of misc errors
Fixed a bunch of small errors: bad indents, superfluous parentheses,
missing whitespace, superfluous statement.
2017-11-09 17:41:10 +01:00
Marta Marczykowska-Górecka
e543144aec
Too-few-public-methods warning
Checked, are sensible, disabled pylint warnings.
2017-11-09 17:41:10 +01:00
Marta Marczykowska-Górecka
ff4ee713b1
Removed unnecessary global variables
Removed three variables set to global, which were all used only in their
respective "main" function.
2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
695303f16a
Fixed unused variables
When possible removed, otherwise renamed to start with an underscore.
2017-11-09 16:26:05 +01:00
Marta Marczykowska-Górecka
b9e4f99fec
Fixed unusued arguments
Places where the variable is used in a overriding method were marked for
pylint to ignore them.
2017-11-09 16:19:12 +01:00
Marta Marczykowska-Górecka
04aa844a9d
Removed variable "anything_changed"
It was assigned in 17 places and not used otherwise in any other place.
It's highly likely it was useless.
2017-11-09 16:18:23 +01:00
Marta Marczykowska-Górecka
6e5d611f70
Fixed invalid names
Fixed camel case, too long and too short variable and function names.
2017-11-09 16:18:16 +01:00
Marta Marczykowska-Górecka
d7fbacf0d7
Fixed broad exceptions
Fixed broad exception errors: replacing them with more precise error
catching where sensible and adding appropriate pylint skip comments
where not.
2017-11-08 15:40:35 +01:00
Marta Marczykowska-Górecka
2b24abb8c8
Fixed trailing and bad whitespaces
Fixed trailing and bad whitespaces
2017-11-06 23:55:58 +01:00
Marta Marczykowska-Górecka
91572eea2d
Fixed too-long lines
Fixed lines over 80 characters.
2017-11-06 23:55:58 +01:00
Marta Marczykowska-Górecka
c252e9ec3c
Fixed wildcard imports
Fixed wildcard imports and any further problems resulting from them.
2017-11-06 23:55:58 +01:00
Marta Marczykowska-Górecka
eaccc323fb
Fixed unused imports
Fixed all unused imports errors.
2017-11-06 23:20:09 +01:00
Marta Marczykowska-Górecka
3009610a62
Fixed GPL license
Replaced old, address-having, too-many-characters-in-a-line version with
the new one with URL.
2017-11-06 21:06:30 +01:00
Marta Marczykowska-Górecka
41b602ec48
Initial setup
Initialize .pylintrc, put ignore in used files' headers.
2017-11-06 20:36:09 +01:00
Marta Marczykowska-Górecka
ef86e33dee
Style fixes
Changes requested by @marmarek
2017-11-06 19:45:36 +01:00
Marta Marczykowska-Górecka
b7e4e55d05
Added Clone VM button
Button added on the basic tab of VM Settings. Also some refactoring to
clean up the rename/clone/delete buttons.
2017-11-03 23:50:04 +01:00
Marta Marczykowska-Górecka
458968d37f
Added Remove VM button
Button added on the basic tab of VM Settings. Button active only when
VM is shutdown; furthermore, requires the user to enter full VM name
to confirm.
2017-11-03 22:20:34 +01:00
Marek Marczykowski-Górecki
d165bd33b6
Merge remote-tracking branch 'qubesos/pr/45'
* qubesos/pr/45:
  Firewall settings
2017-10-21 01:38:20 +02:00
Marek Marczykowski-Górecki
43576d786c
Fix setting include_in_balancing checkbox
Generally vm.features values are strings, need to cast them to boot to
use in such context.
Additionally fix typo in feature name ('services' -> 'service').

Fixes QubesOS/qubes-issues#2947
Fixes QubesOS/qubes-issues#3104
2017-10-16 03:18:27 +02:00
Marek Marczykowski-Górecki
9ebd602407
One more place to use vm.klass instead of type(vm) 2017-10-16 03:10:19 +02:00