Marta Marczykowska-Górecka
df31207028
Final tiny fix of unused import
...
Threw out unused import of shutil.
2017-12-11 02:41:50 +01:00
Marta Marczykowska-Górecka
67a32b5748
Added 'compression' checkbox to backup GUI
...
Added 'compress the backup' checkbox to the backup GUI.
fixes QubesOS/qubes-issues#943
2017-12-11 02:37:50 +01:00
Marta Marczykowska-Górecka
7fd0c58303
Restored 'cancel' functionality
...
Now user can actually cancel a backup/restore.
2017-12-11 02:28:15 +01:00
Marta Marczykowska-Górecka
14ebf9dc6d
Fixed opening file dialog at the end
...
Now, when "open file dialog to unmount" option is enabled, a fie dialog
actually opens.
2017-12-11 02:07:10 +01:00
Marta Marczykowska-Górecka
a4a58cc527
Fixed progress bars
...
Partial fix - the progress bars now move, although they do not really
indicate progress (just dance back and forth). Future fix would include
making a tray icon to signal backup progress instead.
2017-12-11 01:32:26 +01:00
Marta Marczykowska-Górecka
78b4747e81
Second pylint pass
...
Fixed errors pointed out by pylint on server.
2017-12-11 01:15:07 +01:00
Marta Marczykowska-Górecka
a1c6e72569
First pylint pass
...
Fixed errors pointed out by pylint.
2017-12-11 00:56:27 +01:00
Marta Marczykowska-Górecka
4e2835531e
Usability fixes
...
Added label to inform the user only running VMs are listed in backup
GUI; made "ignore missing" label clearer.
2017-12-11 00:13:15 +01:00
Marta Marczykowska-Górecka
7848b6b2c3
Fixed inability to select which VMs to restore
...
Fixed bug that caused all VMs to be restored, regardless of what the
user selected.
2017-12-10 23:56:22 +01:00
Marta Marczykowska-Górecka
7bcde2158e
Added optional saving of default backup profile
...
Added checkbox for saving default backup profile. Removed useless "should I encrypt" checkbox (yes, you have to encrypt).
2017-12-10 23:19:16 +01:00
Marta Marczykowska-Górecka
9d73ceb99d
Fixed imports
...
Fixed import * and unused imports.
2017-12-10 22:11:07 +01:00
Marta Marczykowska-Górecka
7a4e4b35d5
Initial backup-and-restore GUI restoration
...
Initial restoration: basic backup-and-restore works, but
- progress bar in backup does not work
- selecting only some VMs to restore does not work
- various miscellaneous enhancements are not yet in place
2017-12-10 21:14:14 +01:00
Marek Marczykowski-Górecki
c403fc1e8f
Merge branch 'firewall_warnings'
...
* firewall_warnings:
Sort items in settingsdlg.ui / firewall tab
Enabled Firewall config without a netvm
2017-11-21 02:42:27 +01:00
Marta Marczykowska-Górecka
5b19c825e3
Enabled Firewall config without a netvm
...
Enabled Firewall tab even when there's no working netvm or the netvm
doesn't support qubes-firewall. An appropriate warning label and message
are shown in both cases.
fixes QubesOS/qubes-issues#3290
2017-11-20 14:20:01 +01:00
Marta Marczykowska-Górecka
eeac042662
Fixed bug with firewall GUI settings
...
Fixed bug that led to correct firewall configuration not being
recognized by GUI VM Settings.
fixes QubesOS/qubes-issues#3289
2017-11-17 19:12:06 +01:00
Marta Marczykowska-Górecka
5f1e4803fe
Applied corrections from @marmarek
2017-11-17 17:42:19 +01:00
Marta Marczykowska-Górecka
135060dfe7
Final corrections
...
Errors that my local pylint ignored and travis' pylint didn't.
2017-11-14 15:44:43 +01:00
Marta Marczykowska-Górecka
8cfc93c70c
Misc errors part 2
...
Renamed variable from 'input' to 'input_string' and moved imports to a
better place (that is, at the beginning of the module and not inside of
a function).
2017-11-09 17:57:21 +01:00
Marta Marczykowska-Górecka
8b296fab0d
Disable too-many-attributes warning
...
It's the settings window, it has a lot of attributes.
2017-11-09 17:41:10 +01:00
Marta Marczykowska-Górecka
95599dff9f
A bunch of misc errors
...
Fixed a bunch of small errors: bad indents, superfluous parentheses,
missing whitespace, superfluous statement.
2017-11-09 17:41:10 +01:00
Marta Marczykowska-Górecka
e543144aec
Too-few-public-methods warning
...
Checked, are sensible, disabled pylint warnings.
2017-11-09 17:41:10 +01:00
Marta Marczykowska-Górecka
3d841cf14f
Checked too-many-returns error
...
Checked both places with a 'too-many-return-statements' warning, both
were sensible, marked them as such.
2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
6670f59853
Fixed regex strings
...
Fixed regex strings that were not marked as raw.
2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
59a9b7da40
Redefined variable type
...
Marked places where redefining variable type was actually sensible as
such.
2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
0115c931d2
Variables defined outside init
...
Defined them inside init and added description.
2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
ff4ee713b1
Removed unnecessary global variables
...
Removed three variables set to global, which were all used only in their
respective "main" function.
2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
b7060e76b2
Fixed no-self-use error
...
Turned methods into static methods when possible.
2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
695303f16a
Fixed unused variables
...
When possible removed, otherwise renamed to start with an underscore.
2017-11-09 16:26:05 +01:00
Marta Marczykowska-Górecka
3f7f5a9da3
Firewall GUI fix
...
Fixed error when service would be left empty, but the settings window
would nonetheless emit an error.
2017-11-09 16:19:14 +01:00
Marta Marczykowska-Górecka
b9e4f99fec
Fixed unusued arguments
...
Places where the variable is used in a overriding method were marked for
pylint to ignore them.
2017-11-09 16:19:12 +01:00
Marta Marczykowska-Górecka
04aa844a9d
Removed variable "anything_changed"
...
It was assigned in 17 places and not used otherwise in any other place.
It's highly likely it was useless.
2017-11-09 16:18:23 +01:00
Marta Marczykowska-Górecka
6e5d611f70
Fixed invalid names
...
Fixed camel case, too long and too short variable and function names.
2017-11-09 16:18:16 +01:00
Marta Marczykowska-Górecka
d7fbacf0d7
Fixed broad exceptions
...
Fixed broad exception errors: replacing them with more precise error
catching where sensible and adding appropriate pylint skip comments
where not.
2017-11-08 15:40:35 +01:00
Marta Marczykowska-Górecka
2b24abb8c8
Fixed trailing and bad whitespaces
...
Fixed trailing and bad whitespaces
2017-11-06 23:55:58 +01:00
Marta Marczykowska-Górecka
91572eea2d
Fixed too-long lines
...
Fixed lines over 80 characters.
2017-11-06 23:55:58 +01:00
Marta Marczykowska-Górecka
c252e9ec3c
Fixed wildcard imports
...
Fixed wildcard imports and any further problems resulting from them.
2017-11-06 23:55:58 +01:00
Marta Marczykowska-Górecka
eaccc323fb
Fixed unused imports
...
Fixed all unused imports errors.
2017-11-06 23:20:09 +01:00
Marta Marczykowska-Górecka
3009610a62
Fixed GPL license
...
Replaced old, address-having, too-many-characters-in-a-line version with
the new one with URL.
2017-11-06 21:06:30 +01:00
Marta Marczykowska-Górecka
41b602ec48
Initial setup
...
Initialize .pylintrc, put ignore in used files' headers.
2017-11-06 20:36:09 +01:00
Marta Marczykowska-Górecka
ef86e33dee
Style fixes
...
Changes requested by @marmarek
2017-11-06 19:45:36 +01:00
Marta Marczykowska-Górecka
b7e4e55d05
Added Clone VM button
...
Button added on the basic tab of VM Settings. Also some refactoring to
clean up the rename/clone/delete buttons.
2017-11-03 23:50:04 +01:00
Marta Marczykowska-Górecka
458968d37f
Added Remove VM button
...
Button added on the basic tab of VM Settings. Button active only when
VM is shutdown; furthermore, requires the user to enter full VM name
to confirm.
2017-11-03 22:20:34 +01:00
Marek Marczykowski-Górecki
d165bd33b6
Merge remote-tracking branch 'qubesos/pr/45'
...
* qubesos/pr/45:
Firewall settings
2017-10-21 01:38:20 +02:00
Marek Marczykowski-Górecki
43576d786c
Fix setting include_in_balancing checkbox
...
Generally vm.features values are strings, need to cast them to boot to
use in such context.
Additionally fix typo in feature name ('services' -> 'service').
Fixes QubesOS/qubes-issues#2947
Fixes QubesOS/qubes-issues#3104
2017-10-16 03:18:27 +02:00
Marek Marczykowski-Górecki
9ebd602407
One more place to use vm.klass instead of type(vm)
2017-10-16 03:10:19 +02:00
Marta Marczykowska-Górecka
dd990c04ac
Firewall settings
...
Modified VM Settings - Firewall tab to be easier to use and saner.
2017-10-13 22:41:10 +02:00
HW42
ebc7426cab
Add handling for virt_mode including PVH mode
2017-10-12 17:06:17 +02:00
Marek Marczykowski-Górecki
0c5a2b1dcc
Fix resizing root volume
...
Use "system storage" value from the window, not "private storage"...
Reported by @0spinboson
Fixes QubesOS/qubes-issues#3143
2017-10-08 16:57:08 +02:00
Marek Marczykowski-Górecki
058b813690
Merge branch 'klass-attr'
...
* klass-attr:
Fix setting kernel property
use 'klass' property instead of actual VM object class
2017-10-08 16:55:33 +02:00
Marek Marczykowski-Górecki
4d3a992ac6
Fix setting kernel property
...
Fixes QubesOS/qubes-issues#3145
2017-10-07 00:23:37 +02:00
Marek Marczykowski-Górecki
07162ba089
use 'klass' property instead of actual VM object class
...
The later is going to be generic QubesVM class, to save admin.vm.List
calls.
2017-10-07 00:22:41 +02:00
Marta Marczykowska-Górecka
75ddc62bed
Fixed issue#3113 - boot from cdrom
...
Fixes missing cast to string in boot from cdrom tool.
fixes QubesOS/qubes-issues#3113
2017-10-04 23:28:02 +02:00
Marek Marczykowski-Górecki
c2aad3ce20
Remove code referencing removed "extra drive" box
2017-09-14 02:34:10 +02:00
Marek Marczykowski-Górecki
54b45a91af
Merge remote-tracking branch 'qubesos/pr/41'
...
* qubesos/pr/41:
Create new VM
2017-09-14 00:28:39 +02:00
Marta Marczykowska-Górecka
79f82e4d23
Create new VM
...
Create new VM window.
Window slightly redesigned for more logical flow.
2017-09-14 00:20:15 +02:00
Marek Marczykowski-Górecki
3c906f9a5f
Merge remote-tracking branch 'qubesos/pr/40'
...
* qubesos/pr/40:
Added gui for booting VM from CDROM/block device.
Remove obsolete sections from VM Settings: - drive image - paths
2017-09-13 23:50:53 +02:00
Marta Marczykowska-Górecka
2ac9b1d182
Added gui for booting VM from CDROM/block device.
...
Available via command line (qubes-vm-boot-from-device) and
from a button in VM Settings/Advanced.
2017-09-13 23:30:45 +02:00
Marta Marczykowska-Górecka
0e5feeac0d
Remove obsolete sections from VM Settings:
...
- drive image
- paths
2017-09-08 22:39:54 +02:00
Marta Marczykowska-Górecka
9c85dc34ec
Rename NetVM to Networking in vm-settings
...
Renamed "NetVM" to "Networking" and to clear up any possible
misunderstanding, renamed "none" to "(none)" in the appropriate dropdown.
Fixes QubesOS/qubes-issues#1763
2017-09-05 00:51:25 +02:00
Marek Marczykowski-Górecki
da23873b47
settings: fix volume resize
...
- use MiB instead of MB
- do not allow root volume resize for template-based VMs
- do not resize if nothing was changed (use int, not float)
2017-07-30 18:56:35 +02:00
Marek Marczykowski-Górecki
861d7c5413
settings: fix settings applications list
...
Fix qvm-appmenus usage, do nothing when no change was made.
2017-07-30 18:55:32 +02:00
Marta Marczykowska-Górecka
693e1340ed
'rename VM' button in VM Settings
...
rename VM button in VM settings: it asks for a new name, and then clones
VM under the new name and deletes old one. Renaming VM closes VM settings
window without saving any other changes.
Changed max size of VM name field to 32 characters.
2017-07-29 13:28:53 +02:00
Marta Marczykowska-Górecka
2dda433fd3
'refresh available apps' button in VM Setting
...
added a button in VM Settings, Applications tab to refresh the list of
available apps
2017-07-29 13:28:53 +02:00
Marek Marczykowski-Górecki
9de507f95d
Change 'hvm' property to 'virt_mode'
...
QubesOS/qubes-issues#2912
2017-07-18 04:24:32 +02:00
Marek Marczykowski-Górecki
402f1db80d
firewall: check for 'qubes-firewall' feature instead of being ProxyVM
...
This enable better detection whether firewall settings will really be
respected.
Fixes QubesOS/qubes-issues#2003
2017-07-16 10:50:07 +02:00
Marek Marczykowski-Górecki
576299afea
settings: fix getting available appmenus list
2017-07-16 10:40:59 +02:00
Wojtek Porczyk
96fc9c192c
fixes from @marmarek's review
2017-07-14 02:19:24 +02:00
Wojtek Porczyk
1861ff386d
settings: devices
2017-07-12 15:12:44 +02:00
Wojtek Porczyk
c32391a030
settings: services
2017-07-12 15:12:44 +02:00
Wojtek Porczyk
e78ede26f1
adminapi storage
2017-07-12 15:12:43 +02:00
Wojtek Porczyk
092d38e09a
settings: misc removed
2017-07-12 15:12:43 +02:00
Wojtek Porczyk
cd2d3d7c0e
settings: firewall and network
2017-07-12 15:05:05 +02:00
Wojtek Porczyk
ac06eee39b
settings: dir_path, config_path
2017-07-12 15:05:05 +02:00
Wojtek Porczyk
cae10193e7
qubesmanager/settings: imports
2017-07-12 15:05:05 +02:00
Wojtek Porczyk
37d501c42b
rewrite firewall
2017-07-12 15:05:05 +02:00
Wojtek Porczyk
43f2f6b881
rewrite creating new qube
2017-07-12 15:05:05 +02:00
Wojtek Porczyk
eefa6c31c2
appmenus fix
2017-07-12 15:05:05 +02:00
Wojtek Porczyk
6462ae88b7
qubesmanager/utils
2017-07-12 15:05:05 +02:00
Wojtek Porczyk
ea28980717
settings: debug mode
2017-07-12 15:05:05 +02:00
Wojtek Porczyk
f6a5c02adb
qubesmanager/settings: make it work on qubesadmin, part 0
2017-07-12 15:04:55 +02:00
Wojtek Porczyk
2c3df7bd67
spring cleaning part 5: more python3 fixes
2017-07-12 14:54:14 +02:00
Wojtek Porczyk
f5d83d31dd
spring cleaning part 4
...
remove old imports
2017-07-12 14:54:13 +02:00
Wojtek Porczyk
64913fd968
spring cleaning part 3
...
some unnecessary leftovers
2017-07-12 14:54:12 +02:00
Wojtek Porczyk
a023fb708e
spring cleaning part 2
...
setup.py
2017-07-12 14:54:12 +02:00
Marta Marczykowska-Górecka
fb3dc6ecf7
update qubesmanager to compile under python3.
...
note: qvm-net.py has changed location to a weird one.
2017-06-25 17:53:23 +02:00
Marta Marczykowska-Górecka
5daa35a301
update globalsettingsdlg for new API
2017-06-25 17:31:10 +02:00
Marek Marczykowski-Górecki
2a381227f2
Merge remote-tracking branch 'qubesos/pr/34'
...
* qubesos/pr/34:
Show size of current inter-VM clipboard in Ctrl-Shift-C notification message
Show size of current inter-VM clipboard in Ctrl-Shift-C notification message
2017-05-31 12:59:21 +02:00
itinerarium
c2a340698e
Show size of current inter-VM clipboard in Ctrl-Shift-C notification message
...
Fix copy/paste error
QubesOS/qubes-issues#2825
2017-05-28 12:12:25 -04:00
itinerarium
9c284ebedb
Show size of current inter-VM clipboard in Ctrl-Shift-C notification message
...
QubesOS/qubes-issues#2825
2017-05-28 11:49:34 -04:00
M. Vefa Bicakci
2ba6df43fc
Remove left-over debugging print-outs
2017-05-26 02:02:25 -04:00
M. Vefa Bicakci
a2d0b128b7
Make sure that new value of uses_default_kernel persists
...
Prior to this commit, whenever the user selected the default kernel in
a VM's "Advanced Settings" dialog in Qubes Manager, the
"uses_default_kernel" flag would not be saved as expected. Instead of
the intent to use the default kernel version for the VM in the future,
the VM would be stuck with the specific kernel version and not any new
future default kernel versions.
This issue occurs because the "kernel" property setter for the QubesVm
class resets the "uses_default_kernel" member variable to False, and
Qubes Manager sets the "uses_default_kernel" property before setting the
"kernel" property.
Resolve this issue by making sure that the "uses_default_kernel"
member variable of the VM in question is set after the "kernel" member
variable.
2017-05-26 02:02:25 -04:00
M. Vefa Bicakci
d551bdc3fa
Do not abort VM restarts due to inconsistent info
...
Prior to this commit, there have been occasional issues with the usage
of the Qubes Manager's VM restart button where the restart procedure
is interrupted due to an exception thrown after the VM in question is
shut down. The exception has the following backtrace:
----
line: assert not vm.is_running()
func: start_vm
line no.: 1198
file: /usr/lib64/python2.7/site-packages/qubesmanager/main.py
----
line: self.caller.start_vm(vm)
func: check_if_vm_has_shutdown
line no.: 308
file: /usr/lib64/python2.7/site-packages/qubesmanager/main.py
Upon investigation, the root cause of the issue appears to be
inconsistent information provided by Xen regarding a recently-shut-down
VM's start-up timestamp and its state (i.e., running or shut down).
In some cases Xen would report that the VM is running whereas the
start-up timestamp would be returned as None, due to unknown reasons.
This inconsistency would then cause the code modified by this commit to
call the Qubes Manager's "start_vm" method, which would attempt to
assert that a VM is shut down, which would raise the aforementioned
exception.
This commit aims to resolve this issue by checking whether the VM has
fully shut down according to Xen and by calling "start_vm" only if the
VM has fully shut down.
This commit also slightly refactors the affected code.
Fixes : QubesOS/qubes-issues#2438
2017-05-13 14:30:37 -04:00
Marek Marczykowski-Górecki
23fc7df23c
settings: save qubes.xml after saving firewall rules
...
Saving (and also applying) firewall rules may modify VM's "services",
which are stored in qubes.xml. This is the case for "Allow connection to
Updates Proxy" - which also enables/disables 'yum-proxy-setup' service.
Without this commit, such change was ignored.
Fixes QubesOS/qubes-issues#2770
2017-04-24 01:59:00 +02:00
Christopher Laprise
edd62efd78
Progress bar can match light or dark palette
2017-03-21 10:57:32 -04:00
Christopher Laprise
2d3cf6cdb2
Run InstallUpdatesGUI service as root
2017-03-12 23:43:41 -04:00
Marek Marczykowski-Górecki
16a556c0a1
Merge remote-tracking branch 'qubesos/pr/27'
...
* qubesos/pr/27:
Add more missing unicode()s around .tr()s
2017-02-20 04:07:13 +01:00
Jean-Philippe Ouellet
2f72aaf05f
Add more missing unicode()s around .tr()s
...
Fixes https://github.com/QubesOS/qubes-issues/issues/2637
2017-02-19 21:49:03 -05:00
Marek Marczykowski-Górecki
3a011da65d
Add missing unicode() wrapper before .format() on QString
...
self.tr return QString, which do not support python's str.format().
Fixes QubesOS/qubes-issues#2637
2017-02-19 22:51:09 +01:00
Jean-Philippe Ouellet
3e84b9e2ae
Use app instead of self for .tr() outside QObject
...
Fixes https://github.com/QubesOS/qubes-issues/issues/2637
2017-02-19 15:49:28 -05:00
Marek Marczykowski-Górecki
ed8f889c92
Merge remote-tracking branch 'qubesos/pr/25'
...
* qubesos/pr/25:
Restrict VM search field to valid VM names
Revert "Fix for UnicodeEncodeError in search"
2017-02-14 21:45:52 +01:00
Jean-Philippe Ouellet
6b3ef1dab2
Restrict VM search field to valid VM names
...
Properly fixes https://github.com/QubesOS/qubes-issues/issues/2562
This regex is starting to get duplicated in too many places...
Maybe it belongs in core somewhere?
2017-02-13 04:41:18 -05:00
Jean-Philippe Ouellet
b2bcc00e1d
Revert "Fix for UnicodeEncodeError in search"
...
This reverts commit 4a3240bf1a
2017-02-13 04:34:54 -05:00
Marek Marczykowski-Górecki
d073b3582d
i18n: wrap self.tf in unicode() where 'format' function is used
...
Qstring (returned by self.tr) does not have 'format' method.
Fixes QubesOS/qubes-issues#2599
2017-02-06 04:20:13 +01:00
Marek Marczykowski-Górecki
4946d7b8d0
Merge branch 'i18n'
...
* i18n:
i18n: update translations
i18n: add configuration for transifex client
i18n: add 'en' translation file as a source template
Translated some strings to test the process
i18n: add skeleton translation file for spanish
i18n: wrap strings with self.tr
i18n: add basic support for translations
2017-02-03 17:29:08 +01:00
Marek Marczykowski-Górecki
cab53b21aa
Merge remote-tracking branch 'qubesos/pr/24'
...
* qubesos/pr/24:
Turn on NetVM view in Manager by default. CPU column off.
2017-01-29 13:27:10 +01:00
unman
d9ef229049
Turn on NetVM view in Manager by default. CPU column off.
2017-01-29 01:25:17 +00:00
unman
4b31b206ef
Move network diagram to System menu in Manager
2017-01-28 03:15:58 +00:00
unman
a72003f44b
Add extended information and Network diagram to Manager
2017-01-26 20:36:39 +00:00
Marek Marczykowski-Górecki
7c602bf7d2
i18n: wrap strings with self.tr
...
Allow translations to handle strings defined in code.
Fixes QubesOS/qubes-issues#2599
2017-01-22 13:22:26 +01:00
Marek Marczykowski-Górecki
cf8b99c763
i18n: add basic support for translations
...
Handle translations of GUI elements defined in .ui files.
See README.md for details.
Fixes QubesOS/qubes-issues#2599
2017-01-22 13:22:16 +01:00
Marek Marczykowski-Górecki
e1e55c6bea
Merge remote-tracking branch 'qubesos/pr/22'
...
* qubesos/pr/22:
Fix for UnicodeEncodeError in search
2017-01-10 02:48:14 +01:00
Marek Marczykowski-Górecki
684abd4a1b
Merge remote-tracking branch 'qubesos/pr/21'
...
* qubesos/pr/21:
Sort items in Backup selection dialog
2017-01-10 02:48:01 +01:00
yaqu
4a3240bf1a
Fix for UnicodeEncodeError in search
...
Entering non-ascii characters (e.g. "ą") in search
causes an UnicodeEncodeError. This is a quick fix.
Fixes QubesOS/qubes-issues#2562
2017-01-09 23:31:49 +01:00
unman
0f1e7bb352
Sort items in Backup selection dialog
2017-01-05 02:58:03 +00:00
Marek Marczykowski-Górecki
c214c65589
Merge remote-tracking branch 'qubesos/pr/20'
...
* qubesos/pr/20:
Select search box contents on focus
2016-12-20 03:01:02 +01:00
Jean-Philippe Ouellet
9fa8ca5520
Select search box contents on focus
...
Attempt #2
2016-12-18 18:11:45 -05:00
Jean-Philippe Ouellet
1e3a60e286
Add Ctrl+F as keyboard shortcut to focus search box
2016-12-18 09:40:34 -05:00
Jean-Philippe Ouellet
d2d29c6865
Re-write to avoid leaking fd if flock(2) fails
2016-11-26 21:00:01 -05:00
Jean-Philippe Ouellet
4c4def2876
Avoid potential deadlock
...
Could happen if exception thrown in open/write while holding flock.
2016-11-26 20:59:49 -05:00
Jean-Philippe Ouellet
a0bb943af9
Implement "Copy Dom0 clipboard" tray menu item
...
Ctrl+Shift+C would be preferable, but is quite difficult to do safely,
and this method seems like a reasonable security/UX compromise.
Discussed in:
- https://groups.google.com/forum/#!topic/qubes-devel/4_x7Su21i9o
- https://github.com/QubesOS/qubes-issues/issues/2438#issuecomment-261704575
Fixes https://github.com/QubesOS/qubes-issues/issues/2450
2016-11-26 20:59:24 -05:00
Marek Marczykowski-Górecki
c7c86d12a7
Merge remote-tracking branch 'qubesos/pr/14'
...
* qubesos/pr/14:
Make inter-appviewer lock permissions consistent
2016-11-27 02:19:52 +01:00
Jean-Philippe Ouellet
f6e00adebe
Make inter-appviewer lock permissions consistent
...
Currently in gui-daemon/xside.c (only other holder of the lock):
g->inter_appviewer_lock_fd = open("/var/run/qubes/appviewer.lock",
O_RDWR | O_CREAT, 0666);
...
/* ignore possible errors */
fchmod(g->inter_appviewer_lock_fd, 0666);
2016-11-26 14:42:31 -05:00
Jean-Philippe Ouellet
4c08f75399
Implement searching for VMs in qubes-manager
2016-11-23 02:49:13 -05:00
Marek Marczykowski-Górecki
88eedc1a43
Merge remote-tracking branch 'qubesos/pr/11'
...
* qubesos/pr/11:
Use more idiomatic python in VM filtering
2016-11-23 01:06:59 +01:00
Marek Marczykowski-Górecki
cf0fbcd908
Merge remote-tracking branch 'qubesos/pr/10'
...
* qubesos/pr/10:
Require typing name of VM to remove
Fixes QubesOS/qubes-issues#1329
2016-11-23 01:06:39 +01:00
Jean-Philippe Ouellet
99a9f52297
Use more idiomatic python in VM filtering
2016-11-22 03:38:37 -05:00
Jean-Philippe Ouellet
86d5825464
Require typing name of VM to remove
...
It is too easy to accidentally delete the wrong VM if you use lots
of short-term (but longer than disposable) VMs and have built
muscle memory of just clicking "Ok" in the deletion confirmation box.
This patch requires you to type the full name of the VM, inspired by
repo deletion confirmation on GitHub.
2016-11-22 00:41:32 -05:00
Jean-Philippe Ouellet
a604a3fce2
Refactor "Logs" menu population
2016-11-21 23:37:51 -05:00
Rusty Bird
11be5d65fa
Gray out "Restart VM" for dispVMs
2016-11-21 14:39:25 +00:00
Marek Marczykowski-Górecki
f34328836e
Fix unicode handling in command to run
...
Thanks @igilik for the patch!
Fixes QubesOS/qubes-issues#2040
2016-10-03 00:11:59 +02:00
Marek Marczykowski-Górecki
d4131b8092
Merge remote-tracking branch 'qubesos/pr/7'
...
* qubesos/pr/7:
fix TypeError
2016-07-08 01:07:33 +02:00
Markus Bach
baf5c90dbe
fix TypeError
...
fixes QubesOS/qubes-issues#2156
2016-07-07 18:16:16 +02:00
Marek Marczykowski-Górecki
f7b558c55e
formatting
2016-07-01 03:09:27 +02:00
Marek Marczykowski-Górecki
816659b893
Merge remote-tracking branch 'qubesos/pr/6'
...
* qubesos/pr/6:
Implemented 'Restart' button QubesOS/qubes-issues#1499
2016-06-24 22:48:15 +02:00
Marek Marczykowski-Górecki
4e5b990f02
Check for qubes-windows-tools presence before starting installation
...
Prevents confusing error message.
Fixes QubesOS/qubes-issues#1977
2016-06-21 02:07:22 +02:00
Marek Marczykowski-Górecki
49c209d077
firewall: Warn earlier and improve message on empty service name for TCP/UDP
...
Fixes QubesOS/qubes-issues#2093
2016-06-21 02:05:21 +02:00
Marek Marczykowski-Górecki
00caebda95
wrap long lines
2016-06-21 02:03:32 +02:00
Ivan Konov
7cd1afbb3c
Implemented 'Restart' button
...
QubesOS/qubes-issues#1499
2016-06-05 22:19:18 +03:00
Marek Marczykowski-Górecki
eac2df7e18
Do not allow setting dom0 as any system VM
...
Fixes QubesOS/qubes-issues#1379
2015-12-17 22:49:45 +01:00
Marek Marczykowski-Górecki
1021d718a7
Disable "add/remote app shortcuts" action for dom0
...
Fixes QubesOS/qubes-issues#1367
2015-12-13 01:22:03 +01:00
Marek Marczykowski-Górecki
0f2e999230
Do not allow setting dom0 as default netvm
...
Fixes QubesOS/qubes-issues#1379
2015-12-13 01:21:41 +01:00
Marek Marczykowski-Górecki
dc6fa673bc
Fix 'qubes.InstallUpdatesGUI' call
...
There is no 'verbose' parameter
QubesOS/qubes-issues#1249
2015-11-29 04:07:48 +01:00
Marek Marczykowski-Górecki
f5b1a34894
Prevent scarry error at startup (pyinotify ERROR ... ENOENT)
...
If the clipboard file doesn't exist (and it doesn't at system startup),
pyinotify will output an error to stderr. This situation is already
handled by also monitoring the directory itself for CREATE event. But
prevent error message.
2015-11-27 01:33:42 +01:00
Marek Marczykowski-Górecki
0a5a5253b0
Use 'qubes.InstallUpdatesGUI' RPC service instead of hardcoded script
...
It should be up to the VM what software is used for installing updates.
Fixes QubesOS/qubes-issues#1249
2015-11-13 05:42:24 +01:00
Brennan Novak
3d1cd783ec
exception popup message now shows exc_type sometimes
...
fixes : QubesOS/qubes-issues#1394
2015-11-09 23:25:08 +01:00
Brennan Novak
e1685a18f1
trimed exception popup message text quite a bit. Fixes QubesOS/qubes-issues#1394
2015-11-09 18:54:29 +01:00
Marek Marczykowski-Górecki
c1552af281
Prevent SEGV when background thread raise an exception
...
non-GUI thread can't open new window in PyQt. So as a band aid print the
message to stderr in such case.
And while at it, fix filename in error message (it was clobbered later
while constructing stack trace).
QubesOS/qubes-issues#1266
2015-10-29 18:04:38 +01:00
Marek Marczykowski-Górecki
6563f3078f
Fix "block attached" icon
...
This was broken since 8a91c90Fixes QubesOS/qubes-issues#1291
2015-10-10 20:09:47 +02:00
qubesuser
16cb2e301b
don't call verify_files() before start()
2015-10-02 13:11:13 +02:00
Marek Marczykowski-Górecki
b001f26ee1
Create custom 'About' dialog, with 'release notes' viewer ( #1259 )
...
Fixes QubesOS/qubes-issues#1259
2015-10-01 22:34:49 +02:00
Marek Marczykowski-Górecki
dfd355fe71
Give the user chance to read final meesages after installing updates ( #982 )
...
xterm closes itself immediatelly when the specified command ends, so
wait for user reaction to give a chance to read the message (potentially
some error info). Also add some more meaningful window title.
QubesOS/qubes-issues#982
2015-09-27 00:21:48 +02:00
Marek Marczykowski-Górecki
3ba1a990df
Call yum/apt in xterm to update template ( #982 )
...
Since GUI updaters are broken, workaround this by starting terminal
update in xterm. Not an ideal option, but the proper solution seems to
be much more complicated:
https://phabricator.whonix.org/T373
QubesOS/qubes-issues#1197
QubesOS/qubes-issues#982
2015-09-24 01:27:32 +02:00
Marek Marczykowski-Górecki
1d02420f86
global settings: VMs 'updates check' status now can be also retrieved
...
qubesos/qubes-issues#892
2015-08-05 01:24:52 +02:00
Marek Marczykowski-Górecki
d2a4dd810b
Remove unused imports
2015-07-23 07:34:30 +02:00
Marek Marczykowski-Górecki
0724e37e3c
Use DBUS instead of pid file to prevent multiple simultaneous instances
...
The pid file solution was racy. Since we register DBUS name anyway, we
can use it for this purpose.
2015-07-23 07:32:55 +02:00
Marek Marczykowski-Górecki
e2fa049032
Fix block devices menu update (NameError)
2015-05-28 02:00:23 +02:00
Michal Rostecki
43bc59bfa6
Checking whether the "default NetVM" exists
...
The "default NetVM" is usually the first created ProxyVM which is
set by qubes-core during its creation. [1] If there is no ProxyVM,
there is no "default NetVM". Therefore, creating an AppVM and
launching its settings dialog raised AttributeError, because
get_default_netvm method returned None.
This can be reproduced by installing QubesOS without creating VMs
by installer.
[1] https://github.com/QubesOS/qubes-core-admin/blob/master/core/qubes.py#L355
Fixes qubesos/qubes-issues#1008
2015-05-24 11:23:57 +02:00
Marek Marczykowski-Górecki
b82a88c4a8
Fix VM clone name prompt dialog ( #989 )
...
Fixes qubesos/qubes-issues#989
2015-05-13 04:09:10 +02:00
Marek Marczykowski-Górecki
14c7a9250c
Fix logic about VM "running" state
...
Qubes manager used different logic what it considers as "running VM",
than qubes core.
Here it was "running or starting/stopping", while qubes core uses the
same as libvirt (isActive()), which effectively means "not halted" -
which includes also "paused" and "suspended". This creates a lot
confusion in which action should be available when.
The actual detected bug was about resuming paused VM. There was assert
"not vm.is_running()", while the paused VM _is_ running in terms of
qubes core.
Fixes qubesos/qubes-issues#981
2015-05-04 01:29:20 +02:00
Marek Marczykowski-Górecki
f6941bd3d3
Use separate QubesVmCollection instance when running a task in background ( #986 )
...
QubesVmCollection is not thread safe. If for example update_table() will
be called during some long-running task (like creating or removing VM),
it will try to reload qubes.xml (so get read lock first), but the thread
already holds a lock on this file. This would result in "Lock already
taken" exception.
Fixes qubesos/qubes-issues#986
2015-05-04 01:25:55 +02:00
Marek Marczykowski-Górecki
351225a4b3
Fix resuming VMs ( #981 )
...
Fixes qubesos/qubes-issues#981
2015-05-03 20:28:45 +02:00
Marek Marczykowski-Górecki
1faa0ac37e
mainwindow: code style (part 3), no functional change
...
Organize imports.
2015-05-03 19:03:26 +02:00
Marek Marczykowski-Górecki
4a136507e9
mainwindow: code style (part 2), no functional change
...
Rename variables to match PEP8, use is/is not None instead of ==/!=,
initialize instance variables in __init__, fix methods overloads.
2015-05-03 19:03:26 +02:00
Marek Marczykowski-Górecki
a4a022e2c0
mainwindow: code style (part 1), no functional change
...
Wrap long lines, whitespace fixes
2015-05-03 19:03:25 +02:00
Noah Vesely
7395797182
Added SMTPS and ODMR
...
Added SMTPS and On-Demand Mail Relay (used by Fetchmail, xODMR). Both of these are in the Fedora 20 /etc/services.
2015-04-25 13:26:42 -04:00
Marek Marczykowski-Górecki
8a91c90cf8
Fix block attach/detach
2015-04-14 23:11:12 +02:00
Marek Marczykowski-Górecki
dd93b1237f
settings: add "dispvm_netvm" property in advanced tab
2015-04-06 00:59:15 +02:00
Marek Marczykowski-Górecki
4e5f63be24
settings: mark template as read-only when the VM is running
2015-04-05 21:53:09 +02:00
Marek Marczykowski-Górecki
6b7b07acb8
backup: allow backup templates, even when installed by rpm
2015-03-31 05:44:37 +02:00
Marek Marczykowski-Górecki
5e925b23d4
backup+restore: remove an option to attach disk from a VM to dom0
...
This is (intentionally) not possible in R3. The user can choose to
backup directly to the VM, encrypting the backup in dom0 first.
2015-03-31 05:40:53 +02:00
Marek Marczykowski-Górecki
f65dcdbf10
Watch for domain start/stop events and refresh VM connection info
...
QubesVm object caches some domain state (domain ID in libvirt object,
Qubes DB connection socket), which can become out of date in
case of start/stop events. Currently it needs manual trigger to refresh
itself.
2015-03-30 04:59:08 +02:00
Marek Marczykowski-Górecki
10ec6014b0
Update to follow core-admin change: rename write_iptables_xenstore_entry
2015-03-28 22:59:13 +01:00
Marek Marczykowski-Górecki
80b3afdab4
Revert "Add 'Requested MEM' column (aka prefmem) ( #788 )"
...
This reverts commit 227597cf93
2015-03-28 22:57:03 +01:00
Wojtek Porczyk
be94c87f61
table: sort dom0 first no matter sort order
...
It seems that when sort is reversed, dom0 gets sorted last. This is expected
and hard to counter. Will remain for now.
2015-03-10 21:05:48 +01:00
Matt McCutchen
aefe0dde43
Show an icon for VMs whose TemplateVM is running.
...
https://groups.google.com/d/topic/qubes-users/woHD9RaHvF8/discussion
2015-02-09 21:15:54 +01:00
Marek Marczykowski-Górecki
0d9bb27229
Update CPU measurement call for the new API
2015-02-09 05:05:03 +01:00
Marek Marczykowski-Górecki
6329c6e07e
Disable meminfo watch - not implemented in R3
2015-02-06 08:26:53 +01:00
Marek Marczykowski-Górecki
3c555c9b53
block: update the code for new block API
2014-12-12 05:13:57 +01:00
Marek Marczykowski-Górecki
97620f76a7
settings: hide "add all" widget from devices tab
...
It is very dangerous - adding all the devices to some VM will make the
system unusable once such VM is started.
2014-11-01 19:57:17 +01:00
Marek Marczykowski-Górecki
c8a8a56c73
settings: prevent changing VM name and label while the VM is running
...
Those changes will take effect after VM restart (at least for VM windows
borders), so to not confuse the user with partly updated colors, simply
block the change while the VM is running. The same applies to VM name.
2014-10-28 04:55:14 +01:00
Victor Lopez
473b822e0c
Linux VM specific: force minimum init mem to allow scaling up memory
...
Check init_mem and max_mem_size in a single function (merging the
previous two) taking into account the minimum init memory that allows
the requested maximum memory.
Explanation:
Linux kernel needs space for memory-related structures created at boot.
If init_mem is just 400MB, then max_mem can't balloon above 4.3GB (at
which poing it yields "add_memory() failed: -17" messages and apps
crash), regardless of the max_mem_size value.
Base of Marek's findings and my tests on a 16GB PC, using several
processes like:
stress -m 1 --vm-bytes 1g --vm-hang 100
result in the following points:
init_mem ==> actual max memory
400 4300
700 7554
800 8635
1024 11051
1200 12954
1300 14038
1500 14045 <== probably capped on my 16GB system
The actual ratio of max_mem_size/init_mem is surprisingly constant at
10.79
If less init memory is set than that ratio allows, then the set
max_mem_size is unreachable and the VM becomes unstable (app crashes)
Based on qubes-devel discussion titled "Qubes Dom0 init memory against
Xen best practices?" at:
https://groups.google.com/d/msg/qubes-devel/VRqkFj1IOtA/UgMgnwfxVSIJ
2014-10-06 04:00:20 +02:00
Marek Marczykowski-Górecki
470e1c0879
backups/restore: always allow an option to manually unmount storage device
2014-09-26 15:01:37 +02:00
Marek Marczykowski-Górecki
1ff9ce8a46
backups/restore: add support for 'verify-only' option
2014-09-17 23:07:32 +02:00
Marek Marczykowski-Górecki
c2ae785c5d
backups/restore: fix handling of unicode messages, improve indentation
2014-09-17 23:06:41 +02:00
Marek Marczykowski-Górecki
1cadc1e943
Merge remote-tracking branch 'woju/master'
2014-09-09 22:01:54 +02:00
Marek Marczykowski-Górecki
c992fc0f48
settings: fix drive path setting ( #897 )
2014-09-09 21:59:54 +02:00
Wojciech Zygmunt Porczyk
24759d2762
settings.py: do not attempt to remove service when none selected
...
Thanks to Andrew B (kyboren at gmail dot com) for bug report.
2014-09-04 21:59:05 +02:00
Wojciech Zygmunt Porczyk
fdaaa780a4
use new padlocks from theme
2014-07-10 16:50:29 +02:00
Wojciech Zygmunt Porczyk
060b16900a
use new icon from qubes-artwork
2014-07-09 18:21:56 +02:00
Marek Marczykowski-Górecki
159eea7ac8
block: fix attaching r/o devices (cdrom for example)
2014-07-08 02:06:35 +02:00
Marek Marczykowski-Górecki
61ef08eb47
settings: cast all QString to str
...
QString does not have "startswith" method.
2014-07-05 14:57:47 +02:00
Marek Marczykowski-Górecki
edb40bbfb6
Notify about dom0 updates ( #824 )
...
Tray notifications from cron job (outside of session) didn't worked well.
2014-06-10 01:15:26 +02:00
Marek Marczykowski-Górecki
ca6cc8e01f
create-vm: Handle the case when no HVM-template exists
2014-06-07 04:40:24 +02:00
Marek Marczykowski-Górecki
aca43a46da
Filter out 'dom0' from selectable netvm list
...
This is workaround until #757 will be done.
2014-06-07 04:07:26 +02:00
Andrew B
ba0cced495
Implemented NetVM selection via drop-down in AppVM creation dialog.
2014-06-07 04:02:45 +02:00
Wojciech Zygmunt Porczyk
e9f1bb3880
*.py: Use full paths when calling subprocess.Popen().
...
Also removed unneeded imports of subprocess.
2014-05-22 15:07:35 +02:00
Wojciech Zygmunt Porczyk
fe954632c0
regexp fixes and validation ( #829 )
2014-05-19 15:41:37 +02:00
Wojciech Zygmunt Porczyk
e834b33d42
Merge remote-tracking branch 'marmarek/master'
2014-05-19 13:54:02 +02:00
Hansi
44fe1cc845
small update to add "autostart" checkbox to the basic settings dialog
2014-05-17 21:43:29 +02:00
Wojciech Zygmunt Porczyk
f882042994
settings.py: launch lspci by full path (/usr/sbin/lspci)
2014-05-16 19:16:16 +02:00
