Qubes/manager
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1,487 Commits 1 Branch 0 Tags 8.6 MiB
9a2daa4039
Commit Graph

1095 Commits

Author SHA1 Message Date
Marta Marczykowska-Górecka
b27c10f1d4
Add handling for backup in progress 
Shows a better error message when a given backup is already running.

fixes QubesOS/qubes-issues#5432
requires https://github.com/QubesOS/qubes-core-admin/pull/292
 2019-11-11 17:44:53 +01:00
Frédéric Pierret (fepitre)
51acbde8d5
_run_qrexec_repo: default C local in subprocess call 2019-11-11 17:08:19 +01:00
Frédéric Pierret (fepitre)
0bacf37994
global_settings: make PEP8 happy 2019-11-11 17:05:02 +01:00
Frédéric Pierret (fepitre)
2c132d9b83
utils: make PEP8 happy 2019-11-10 10:16:47 +01:00
Frédéric Pierret (fepitre)
044d91d73e
utils: get linux-kernels from storage API 2019-11-10 10:16:08 +01:00
Marek Marczykowski-Górecki
283ed2540c
Merge remote-tracking branch 'origin/pr/210' 
* origin/pr/210:
  Fixed translation for application names
  Added translation support to all untranslated qubesmanager files
  Re-enabled translation support for Qt5
 2019-11-09 15:32:18 +01:00
Marta Marczykowska-Górecka
b4cb9303bc
Fixed translation for application names 2019-11-09 00:50:44 +01:00
Malte Leip
5ba012b7d3
Fix KernelVersion comparisons 
In the __lt__ function for the class KernelVersions, if
self.groups != other.groups, but self.groups == other.groups[0:n] or
self.groups[0:n] == other.groups for some n, then at some point, one of
the two pieces to be compared will be None, which resulted in an
Exception when calling isdigit.

Hence check whether one of the pieces to be compared is None and handle
this as a special case.

(cherry picked from commit b901203390b4994a8169021d7dc47928561dad24)
 2019-11-07 04:18:37 +01:00
Marek Marczykowski-Górecki
fe56b3e0e7
Merge remote-tracking branch 'origin/pr/211' 
* origin/pr/211:
  Fixed VM settings warning labels
 2019-10-29 13:36:31 +01:00
Marta Marczykowska-Górecka
46952ebad2
Added translation support to all untranslated qubesmanager files 
references QubesOS/qubes-issues#5410
 2019-10-29 12:28:22 +01:00
Marta Marczykowska-Górecka
520cefa010
Fixed VM settings warning labels 
No netvm warning will now show differently for VMs that don't provide
network and those that do.
 2019-10-29 11:53:44 +01:00
Marta Marczykowska-Górecka
245534d886
Re-enabled translation support for Qt5 
Fixed obsolete source files, regenerated translation sources,
re-enabled translation loading in the programs themselves.
Also removed the completely obsolete block.py file. (It was not used anywhere)

references QubesOS/qubes-issues#5410
 2019-10-29 00:49:22 +01:00
Marta Marczykowska-Górecka
afad888343
Fixed error in selecting backup directory in GUI backup 
Also removed unused settings.

fixes QubesOS/qubes-issues#5430
 2019-10-29 00:30:09 +01:00
hexagonrecursion
42affe0da6
Remove redundant popups 2019-10-27 10:22:41 +00:00
Marek Marczykowski-Górecki
7bdcb23fb8
Fix erroneous usage of 'qubes' module 
On the client side it should use only 'qubesadmin'. In practice, those
few are trivial to replace:
 - get_disk_usage() is also available in shutil (as disk_usage())
 - BackupCancelledError should be used from qubesadmin.exc anyway (there
   was also a typo)

Remove also test-packages/qubes to let pylint detect such issues in the
future.

QubesOS/qubes-issues#5403
 2019-10-24 05:47:26 +02:00
Marek Marczykowski-Górecki
1dabce0f54
Merge remote-tracking branch 'origin/pr/205' 
* origin/pr/205:
  Added better exception handling on Backup Cancel
  Tests fixed for new features and bugfixes
  Removed not needed workaround for check-updates on dom0
  Fixed default install_system state for Create New VM
  Fixed manager tests to use Qt5
 2019-10-24 03:20:28 +02:00
Marta Marczykowska-Górecka
0d2d9970b7
Added better exception handling on Backup Cancel 
Qt segfaults when the reject method throws an unhandled
exception; fixed that.
 2019-10-24 00:29:04 +02:00
Marta Marczykowska-Górecka
4c2adbca00
Tests fixed for new features and bugfixes 
After switching to Qt5, a bunch of fixes and changes were introduced.
This fixes tests to take them into account.
 2019-10-17 22:33:08 +02:00
Marta Marczykowska-Górecka
74eba3bb7f
Removed not needed workaround for check-updates on dom0 
And fixed test referring to it.
 2019-10-17 00:29:10 +02:00
Marta Marczykowska-Górecka
6f73ef2163
Fixed manager tests to use Qt5 
Also due to old workarounds not working around anymore,
switched over to "single QApplication object" model.
 2019-10-15 01:28:04 +02:00
Marta Marczykowska-Górecka
0c10723205
Fixed incorrect QApplication start that led to missing icons 
Using QIcon object before initializing QApplication leads to
missing theme icons.

fixes QubesOS/qubes-issues#5354
 2019-10-06 21:55:11 +02:00
Marek Marczykowski-Górecki
12481fd561
Merge remote-tracking branch 'origin/pr/202' 
* origin/pr/202:
  Fixed change in QFileDialog behavior in PyQt5
 2019-09-30 03:51:46 +02:00
Marek Marczykowski-Górecki
fcec3d7464
Merge remote-tracking branch 'origin/pr/200' 
* origin/pr/200:
  Pylint fixes
  Code deduplication and cleanup
  Removed unused line in GUI Backup
 2019-09-30 03:51:44 +02:00
Marta Marczykowska-Górecka
442066d96c
Fixed change in QFileDialog behavior in PyQt5 
Return type of QFileDialog changed between PyQt4 and PyQt5.

fixes QubesOS/qubes-issues#5353
 2019-09-28 22:06:29 +02:00
Saswat Padhi
4ee3c556c4
Show the previous VM name while renaming 
Currently while renaming VMs, the default text is empty "". This change modifies this default text to the original name of the VM.
 2019-09-26 18:29:31 -07:00
Marta Marczykowska-Górecka
5d88e5f851
Pylint fixes 
Several minor fixes for updated pylint checker.
 2019-09-26 22:44:05 +02:00
Marta Marczykowska-Górecka
32078242c9
Code deduplication and cleanup 
Moved loop handling, exception handling and program
running methods of the gui tools to the utils file.

fixes QubesOS/qubes-issues#5342
 2019-09-26 22:31:39 +02:00
Marta Marczykowska-Górecka
8a3653723d
Removed unused line in GUI Backup 
File selection dialog in GUI backup was using an obsolete
(and possibly never working as intented) setReadOnly method.
Removed it, because it neither works nor is needed.

fixes QubesOS/qubes-issues#5348
 2019-09-26 21:37:32 +02:00
Marek Marczykowski-Górecki
bdf0951c52
Merge remote-tracking branch 'origin/pr/198' 
* origin/pr/198:
  Fixed new firewall rule window
 2019-09-23 03:48:09 +02:00
Marek Marczykowski-Górecki
0dc73fd618
Merge remote-tracking branch 'origin/pr/196' 
* origin/pr/196:
  Added an Advanced tab to Create New Qube dialog
 2019-09-23 03:48:07 +02:00
Marta Marczykowska-Górecka
d85940c5a5
Added an Advanced tab to Create New Qube dialog 
Tab contains a warning, provides_network checkbox,
install_system_after_creation checkbox, storage pool settings
and initial RAM.

references QubesOS/qubes-issues#5127
fixes QubeSOS/qubes-issues#5198
 2019-09-20 17:59:23 +02:00
Marta Marczykowska-Górecka
2e152b8dfb
Fixed new firewall rule window 
Now, an error will not close the window, enabling
the user to correct any mistakes.

fixes QubesOS/qubes-issues#bugfix5234
 2019-09-20 17:50:31 +02:00
Marek Marczykowski-Górecki
b0d5263d5e
Merge remote-tracking branch 'origin/pr/199' 
* origin/pr/199:
  Improved display of default disposable VM in Qube Manager
  Qube Manager now reacts to changing some global properties
 2019-09-20 02:10:15 +02:00
Marta Marczykowska-Górecka
2d644c371f
Improved display of default disposable VM in Qube Manager 
Now 'default' value will be correctly shown as default (vm name).
 2019-09-19 01:45:32 +02:00
Marta Marczykowska-Górecka
9aeacce9c5
Qube Manager now reacts to changing some global properties 
Properties checked are: default_netvm and default_dispvm. Qube Manager
will now properly update displayed values.

fixes QubesOS/qubes-issues#5328
 2019-09-19 01:45:32 +02:00
Marta Marczykowska-Górecka
df9576a0f1
Fixed UI error 
Qube Manager columns did not resize correctly in Qt5.

fixes QubesOS/qubes-issues#5278
 2019-09-06 16:31:27 +02:00
Marek Marczykowski-Górecki
c32d63df58
Merge remote-tracking branch 'origin/pr/181' 
* origin/pr/181:
  Add tooltip to application list in VM settings
 2019-08-28 16:50:23 +02:00
Marek Marczykowski-Górecki
1edf363efe
Merge remote-tracking branch 'origin/pr/172' 
* origin/pr/172:
  Say which repository caused the error in warnings
  Only make qrexec calls when necessary
  Squash more PyLint warnings
  Decode stderr in repo qrexec calls
  Fix error handling
  Fix `self` being undefined when showing warnings
  Only apply repo preferences when "OK" is clicked
  Don't use asserts for error handling
  Check that repo management succeeded
  Remove unnecessary assert
  Squash some PyLint warnings
  Add UI for managing Qubes update repositories
  Fix typo

Fixes QubesOS/qubes-issues#4550
 2019-08-28 16:42:01 +02:00
Marek Marczykowski-Górecki
1e3c0bfcd8
Merge remote-tracking branch 'origin/pr/194' 
* origin/pr/194:
  Fix arithmetic in init/max mem ratio correction
 2019-08-28 15:52:22 +02:00
Marek Marczykowski-Górecki
6107a1fcbf
Merge remote-tracking branch 'origin/pr/192' 
* origin/pr/192:
  Added virt mode column to Qube Manager
 2019-08-28 15:50:29 +02:00
Marek Marczykowski-Górecki
b4b3588bf1
Minor fix qt4 -> qt5 
Pylint detected one more missing QtGui->QtWidgets change.
 2019-08-28 15:48:29 +02:00
Marek Marczykowski-Górecki
990e4abbbf
Merge remote-tracking branch 'origin/pr/178' 
* origin/pr/178:
  Update Qt version used in qubesmanager to Qt5
 2019-08-28 15:19:26 +02:00
Aras Ergus
bbe14f524d
Fix arithmetic in init/max mem ratio correction 
Qubes Manager seems to try to guarantee that 10*init_mem is at
least max_mem by automatically adjusting init_mem to max_mem/10 if
inappropriate values are set. However, this may not guarantee that
10*init_mem >= max_mem due to rounding errors. This change fixes
these edge cases by basically rounding up the result of division
by 10.
 2019-08-17 15:42:36 +02:00
Marek Marczykowski-Górecki
3c9d7d3da4
firewall: service name can contain digits too 2019-08-10 03:54:35 +02:00
Marta Marczykowska-Górecka
dedde71d7a
Fixed bug with port numbers and services in VM settings 
Opening an existing FW rule resulted in an invalid port number.
 2019-08-09 14:16:30 +02:00
Marta Marczykowska-Górecka
1cd95fceb2
Added virt mode column to Qube Manager 
Just another column that shows the
contents of virt_mode property.

fixes QubesOS/qubes-issues#4702
 2019-08-08 17:30:15 +02:00
Marek Marczykowski-Górecki
d5a4ddb7ef
Merge remote-tracking branch 'origin/pr/191' 
* origin/pr/191:
  Fixed parsing port ranges in VM settings
  Better handling of port/service names for VM settings
 2019-08-02 20:03:35 +02:00
Marta Marczykowska-Górecka
1d7d51eafd
Fixed parsing port ranges in VM settings 
Now service names with dash ('-') in them will be parsed
correctly and not result in an error.

fixes QubesOS/qubes-issues#4766
 2019-08-02 16:58:30 +02:00
Marta Marczykowska-Górecka
6cd02b47b3
Better handling of port/service names for VM settings 
Now port will be displayed as port_number [(service name)]
, and not just service name. Also added a tooltip with explanation
of what can be put in the 'port/service' field, renamed
the field to 'Port/service' and added some examples of pure port
numbers to the drop down.

fixes QubesOS/qubes-issues#5211
 2019-08-02 16:39:51 +02:00
Marta Marczykowska-Górecka
31e3f72ae0
Kernel sorting fix 
Fixed bug with kernel versions ending with a letter,
hopefully now the sorting is even more robust and sensible.

fixes QubesOS/qubes-issues#5208
 2019-07-31 23:00:00 +02:00
Marek Marczykowski-Górecki
1dadca8ed8
Merge remote-tracking branch 'origin/pr/189' 
* origin/pr/189:
  Better settings for a newly created VM
  Changed checking for VM name in use
 2019-07-31 17:29:00 +02:00
Marek Marczykowski-Górecki
1a147121f0
Merge remote-tracking branch 'origin/pr/188' 
* origin/pr/188:
  Fixed silent fail in Boot from File window
 2019-07-31 17:28:10 +02:00
Marta Marczykowska-Górecka
4e9ed5e261
Better settings for a newly created VM 
Now a standalone VM not cloned from a template
will not have a kernel and have HVM virt mode.

fixes QubesOS/qubes-issues#5203
 2019-07-29 21:53:44 +02:00
Marta Marczykowska-Górecka
b19d9e1373
Changed checking for VM name in use 
In near future the old way will stop working, so
this is a pre-emptive fix.
 2019-07-29 21:52:40 +02:00
Marta Marczykowska-Górecka
349fb693be
Fixed silent fail in Boot from File window 
Now, when selecting a file fails for some reason
(lack of installed file manager, VM crashed on start,
anything), the user will get an error message.

references QubesOS/qubes-issues#5202
 2019-07-29 19:23:42 +02:00
xaki23
61cb9acf3b
make else/default branch of version-detection non-fatal since any new-and-coming debian variants at this point probably are 4371 fixed to begin with 2019-07-09 23:37:26 +02:00
AJ Jordan
7245603628
Say which repository caused the error in warnings 2019-07-03 01:48:55 -07:00
AJ Jordan
352c0d0386
Only make qrexec calls when necessary 
This helps in situations where the qrexec calls are forbidden; it also
prevents settings from being unintentionally changed and gives a
noticeable performance boost when the "OK" button is clicked.
 2019-07-03 01:46:39 -07:00
AJ Jordan
e0919beec1
Squash more PyLint warnings 
This definitely worked before, and I haven't touched this code recently
so I have no idea why these errors are just now popping up... but
whatever.
 2019-07-02 16:04:04 -07:00
AJ Jordan
6a5823b74a
Decode stderr in repo qrexec calls 
Before this change, "foobar\n" on stderr would be rendered (in the
warning dialog) as "b'foobar\n'", which is ugly. Now it'll be rendered
just as "foobar", followed by an actual newline character.
 2019-07-02 13:45:21 -07:00
AJ Jordan
4931bf9401
Fix error handling 
Apparently Python exceptions don't take **kwargs, so we just pass a
dictionary as the second (regular) argument. While we're at it, we
pretty-print said dictionary when displaying error messages.
 2019-07-02 13:37:29 -07:00
AJ Jordan
33ef478626
Fix self being undefined when showing warnings 2019-07-02 13:07:06 -07:00
AJ Jordan
026a844a91
Only apply repo preferences when "OK" is clicked 2019-07-02 12:36:29 -07:00
AJ Jordan
f3305b8288
Don't use asserts for error handling 2019-07-02 12:36:22 -07:00
AJ Jordan
8f9989a61d
Check that repo management succeeded 2019-07-01 17:23:49 -07:00
AJ Jordan
047cfbc407
Remove unnecessary assert 
First of all, the method that was being called has asserts of its own,
so it's guaranteed to either succeed or crash the program with
AssertionError. Second, asserts are optimized out by the interpreter
when -O is passed. Therefore, this code is buggy because it sometimes
wouldn't be run, but we need the side effects.
 2019-07-01 17:23:48 -07:00
AJ Jordan
df48c749c4
Squash some PyLint warnings 2019-07-01 17:23:46 -07:00
AJ Jordan
fdd06d32a5
Add UI for managing Qubes update repositories 
Depends on QubesOS/qubes-core-admin-linux#48

Fixes QubesOS/qubes-issues#4550
 2019-07-01 17:23:40 -07:00
AJ Jordan
a8df324b2d
Fix typo 2019-07-01 17:23:31 -07:00
Marta Marczykowska-Górecka
d0b99ef438
Cleaned up QThreads usage in VM Settings 
fixes QubesOS/qubes-issues#4949
 2019-06-14 21:13:56 +02:00
Marta Marczykowska-Górecka
4567707207
Add tooltip to application list in VM settings 
The 'Comment' field will now be displayed as a tooltip in VM settings.
Requires https://github.com/QubesOS/qubes-desktop-linux-common/pull/12

references QubesOS/qubes-issues#5076
 2019-06-10 16:01:44 +02:00
Marek Marczykowski-Górecki
ccdddc6a7e
Merge remote-tracking branch 'origin/pr/183' 
* origin/pr/183:
  Sorted kernels in VM settings
 2019-06-10 03:49:13 +02:00
Marek Marczykowski-Górecki
b2e6c1556a
Merge remote-tracking branch 'origin/pr/182' 
* origin/pr/182:
  Added 'provides network' checkbox to VM settings
 2019-06-10 03:48:13 +02:00
Marta Marczykowska-Górecka
65d07eca0d
Sorted kernels in VM settings 
Kernels are sorted with a rough algorithm, comparing groups of numbers
numerically, and names consisting of strings alphabetically.

fixes QubesOS/qubes-issues#5084
 2019-06-10 00:37:32 +02:00
Marta Marczykowska-Górecka
1f9b462bd3
Added 'provides network' checkbox to VM settings 
A simple checkbox in the 'Advanced' tab. Does not allow disabling
'provides_network' if the VM is in use as NetVM; instead, a tooltip
informs the user which VMs use it.

fixes QubesOS/qubes-issues#5079
 2019-06-07 20:13:24 +02:00
Marek Marczykowski-Górecki
09178bc00c
Merge remote-tracking branch 'origin/pr/180' 
* origin/pr/180:
  More safeguards for a VM that started in a weird way
 2019-06-06 04:15:28 +02:00
Marta Marczykowska-Górecka
8c1a9e5120
More safeguards for a VM that started in a weird way 
If for any reason adding a VM failed, Qube Manager will attempt to add it on the next state event it receives.

references QubesOS/qubes-issues#5066
 2019-06-03 21:21:48 +02:00
Marta Marczykowska-Górecka
e79724f9db
Update Qt version used in qubesmanager to Qt5 
Fixed dependencies, places where obsolete functions stopped working,
code fragments that started throwing warnings and an .ui file that
stopped being readable after the update.
 2019-05-30 21:33:49 +02:00
Marta Marczykowska-Górecka
7e17d23003
Added Virtual DNS display to VM settings 
fixes QubesOS/qubes-issues#5050
 2019-05-29 22:24:24 +02:00
Marek Marczykowski-Górecki
43cf50858f
Fix handling buster in dsa-4371-update script 
Fixes QubesOS/qubes-issues#5057
 2019-05-29 18:23:52 +02:00
Marek Marczykowski-Górecki
6550070135
Merge remote-tracking branch 'qubesos/pr/175' 
* qubesos/pr/175:
  More fixes to force tests to work
  Tests for Create New VM
  Tests for VM settings
  Fixed spec
  Tests for backup_utils file
  Tests for Qubes Backup
  Test changes related to fixes in https://github.com/QubesOS/qubes-manager/pull/176
  Tests for qube manager
  Tests for global settings
 2019-05-24 12:18:26 +02:00
Marta Marczykowska-Górecka
5d3c870c1b
More fixes to force tests to work 
Fixed yet another odd QT behavior when tests
were run all together.
 2019-05-20 23:23:03 +02:00
Marta Marczykowska-Górecka
d92c782ec9
Tests for Create New VM 2019-05-12 20:50:21 +02:00
Marta Marczykowska-Górecka
d4965c5b27
Tests for VM settings 2019-05-12 20:50:20 +02:00
Marta Marczykowska-Górecka
526799022d
Fixed spec 2019-05-12 19:47:13 +02:00
Marta Marczykowska-Górecka
9764479aff
Tests for backup_utils file 2019-05-12 19:47:13 +02:00
Marta Marczykowska-Górecka
9252dad222
Tests for Qubes Backup 2019-05-12 19:47:12 +02:00
Marta Marczykowska-Górecka
893764a50c
Test changes related to fixes in https://github.com/QubesOS/qubes-manager/pull/176 2019-05-12 19:47:12 +02:00
Marta Marczykowska-Górecka
702ef75d1c
Tests for qube manager 2019-05-12 19:47:12 +02:00
Marta Marczykowska-Górecka
4fb9672d66
Tests for global settings 2019-05-12 19:47:12 +02:00
Marek Marczykowski-Górecki
af555fa9b1
Merge remote-tracking branch 'origin/pr/176' 
* origin/pr/176:
  Fixed logs display in Qube Manager
  Protected loading manager settings from malformed config files
  Fixed bug with hiding last visible column
  Added additional check for cloning a VM
  Fixed unnecessary property set in Global Settings
  Fixed bug in Global Settings
 2019-05-07 00:09:01 +02:00
Marek Marczykowski-Górecki
e997b4708d
Merge remote-tracking branch 'origin/pr/173' 
* origin/pr/173:
  Changed wording in Create New Qube and fixed minor bug
  Made terminology in Create New VM GUI clearer
 2019-05-07 00:06:33 +02:00
Marta Marczykowska-Górecka
768bfac019
Changed wording in Create New Qube and fixed minor bug 
references QubesOS/qubes-issues#4723
 2019-05-06 17:39:14 +02:00
Marta Marczykowska-Górecka
2634b3b229
Made terminology in Create New VM GUI clearer 
Changed the terms used in Create New VM Gui to the following:
-Qube based on a template (AppVM)
-Standalone qube
-Standalone qube copied from a template

references QubesOS/qubes-issues#4723
 2019-05-06 17:39:14 +02:00
Marta Marczykowska-Górecka
cb70b9bd65
Fixed logs display in Qube Manager 
Logs menu was not updated correctly on all occassions.
 2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
f5586e770b
Protected loading manager settings from malformed config files 
Malformed config files will no longer prevent Qube Manager from
starting.
 2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
0bb92311ba
Fixed bug with hiding last visible column 
Removed old buggy code, replaced it with disabling hiding the 'name'
column (because manager is useless without VM name).
 2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
ddb70fe8ea
Added additional check for cloning a VM 
An attempt to clone a VM to a name that is already in use will
fail more gracefully and with an explicit warning message.
 2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
733f00ddf2
Fixed unnecessary property set in Global Settings 2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
b9316bcd62
Fixed bug in Global Settings 
Incorrect handling of Check dom0 updates being set to false.

fixes QubesOS/qubes-issues#4988
 2019-05-03 14:41:00 +02:00