Qubes/manager
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1,413 Commits 1 Branch 0 Tags 8.6 MiB
b27c10f1d4
Commit Graph

1043 Commits

Author SHA1 Message Date
Marta Marczykowska-Górecka
4e9ed5e261
Better settings for a newly created VM 
Now a standalone VM not cloned from a template
will not have a kernel and have HVM virt mode.

fixes QubesOS/qubes-issues#5203
 2019-07-29 21:53:44 +02:00
Marta Marczykowska-Górecka
b19d9e1373
Changed checking for VM name in use 
In near future the old way will stop working, so
this is a pre-emptive fix.
 2019-07-29 21:52:40 +02:00
Marta Marczykowska-Górecka
349fb693be
Fixed silent fail in Boot from File window 
Now, when selecting a file fails for some reason
(lack of installed file manager, VM crashed on start,
anything), the user will get an error message.

references QubesOS/qubes-issues#5202
 2019-07-29 19:23:42 +02:00
xaki23
61cb9acf3b
make else/default branch of version-detection non-fatal since any new-and-coming debian variants at this point probably are 4371 fixed to begin with 2019-07-09 23:37:26 +02:00
AJ Jordan
7245603628
Say which repository caused the error in warnings 2019-07-03 01:48:55 -07:00
AJ Jordan
352c0d0386
Only make qrexec calls when necessary 
This helps in situations where the qrexec calls are forbidden; it also
prevents settings from being unintentionally changed and gives a
noticeable performance boost when the "OK" button is clicked.
 2019-07-03 01:46:39 -07:00
AJ Jordan
e0919beec1
Squash more PyLint warnings 
This definitely worked before, and I haven't touched this code recently
so I have no idea why these errors are just now popping up... but
whatever.
 2019-07-02 16:04:04 -07:00
AJ Jordan
6a5823b74a
Decode stderr in repo qrexec calls 
Before this change, "foobar\n" on stderr would be rendered (in the
warning dialog) as "b'foobar\n'", which is ugly. Now it'll be rendered
just as "foobar", followed by an actual newline character.
 2019-07-02 13:45:21 -07:00
AJ Jordan
4931bf9401
Fix error handling 
Apparently Python exceptions don't take **kwargs, so we just pass a
dictionary as the second (regular) argument. While we're at it, we
pretty-print said dictionary when displaying error messages.
 2019-07-02 13:37:29 -07:00
AJ Jordan
33ef478626
Fix self being undefined when showing warnings 2019-07-02 13:07:06 -07:00
AJ Jordan
026a844a91
Only apply repo preferences when "OK" is clicked 2019-07-02 12:36:29 -07:00
AJ Jordan
f3305b8288
Don't use asserts for error handling 2019-07-02 12:36:22 -07:00
AJ Jordan
8f9989a61d
Check that repo management succeeded 2019-07-01 17:23:49 -07:00
AJ Jordan
047cfbc407
Remove unnecessary assert 
First of all, the method that was being called has asserts of its own,
so it's guaranteed to either succeed or crash the program with
AssertionError. Second, asserts are optimized out by the interpreter
when -O is passed. Therefore, this code is buggy because it sometimes
wouldn't be run, but we need the side effects.
 2019-07-01 17:23:48 -07:00
AJ Jordan
df48c749c4
Squash some PyLint warnings 2019-07-01 17:23:46 -07:00
AJ Jordan
fdd06d32a5
Add UI for managing Qubes update repositories 
Depends on QubesOS/qubes-core-admin-linux#48

Fixes QubesOS/qubes-issues#4550
 2019-07-01 17:23:40 -07:00
AJ Jordan
a8df324b2d
Fix typo 2019-07-01 17:23:31 -07:00
Marta Marczykowska-Górecka
d0b99ef438
Cleaned up QThreads usage in VM Settings 
fixes QubesOS/qubes-issues#4949
 2019-06-14 21:13:56 +02:00
Marta Marczykowska-Górecka
4567707207
Add tooltip to application list in VM settings 
The 'Comment' field will now be displayed as a tooltip in VM settings.
Requires https://github.com/QubesOS/qubes-desktop-linux-common/pull/12

references QubesOS/qubes-issues#5076
 2019-06-10 16:01:44 +02:00
Marek Marczykowski-Górecki
ccdddc6a7e
Merge remote-tracking branch 'origin/pr/183' 
* origin/pr/183:
  Sorted kernels in VM settings
 2019-06-10 03:49:13 +02:00
Marek Marczykowski-Górecki
b2e6c1556a
Merge remote-tracking branch 'origin/pr/182' 
* origin/pr/182:
  Added 'provides network' checkbox to VM settings
 2019-06-10 03:48:13 +02:00
Marta Marczykowska-Górecka
65d07eca0d
Sorted kernels in VM settings 
Kernels are sorted with a rough algorithm, comparing groups of numbers
numerically, and names consisting of strings alphabetically.

fixes QubesOS/qubes-issues#5084
 2019-06-10 00:37:32 +02:00
Marta Marczykowska-Górecka
1f9b462bd3
Added 'provides network' checkbox to VM settings 
A simple checkbox in the 'Advanced' tab. Does not allow disabling
'provides_network' if the VM is in use as NetVM; instead, a tooltip
informs the user which VMs use it.

fixes QubesOS/qubes-issues#5079
 2019-06-07 20:13:24 +02:00
Marek Marczykowski-Górecki
09178bc00c
Merge remote-tracking branch 'origin/pr/180' 
* origin/pr/180:
  More safeguards for a VM that started in a weird way
 2019-06-06 04:15:28 +02:00
Marta Marczykowska-Górecka
8c1a9e5120
More safeguards for a VM that started in a weird way 
If for any reason adding a VM failed, Qube Manager will attempt to add it on the next state event it receives.

references QubesOS/qubes-issues#5066
 2019-06-03 21:21:48 +02:00
Marta Marczykowska-Górecka
e79724f9db
Update Qt version used in qubesmanager to Qt5 
Fixed dependencies, places where obsolete functions stopped working,
code fragments that started throwing warnings and an .ui file that
stopped being readable after the update.
 2019-05-30 21:33:49 +02:00
Marta Marczykowska-Górecka
7e17d23003
Added Virtual DNS display to VM settings 
fixes QubesOS/qubes-issues#5050
 2019-05-29 22:24:24 +02:00
Marek Marczykowski-Górecki
43cf50858f
Fix handling buster in dsa-4371-update script 
Fixes QubesOS/qubes-issues#5057
 2019-05-29 18:23:52 +02:00
Marek Marczykowski-Górecki
6550070135
Merge remote-tracking branch 'qubesos/pr/175' 
* qubesos/pr/175:
  More fixes to force tests to work
  Tests for Create New VM
  Tests for VM settings
  Fixed spec
  Tests for backup_utils file
  Tests for Qubes Backup
  Test changes related to fixes in https://github.com/QubesOS/qubes-manager/pull/176
  Tests for qube manager
  Tests for global settings
 2019-05-24 12:18:26 +02:00
Marta Marczykowska-Górecka
5d3c870c1b
More fixes to force tests to work 
Fixed yet another odd QT behavior when tests
were run all together.
 2019-05-20 23:23:03 +02:00
Marta Marczykowska-Górecka
d92c782ec9
Tests for Create New VM 2019-05-12 20:50:21 +02:00
Marta Marczykowska-Górecka
d4965c5b27
Tests for VM settings 2019-05-12 20:50:20 +02:00
Marta Marczykowska-Górecka
526799022d
Fixed spec 2019-05-12 19:47:13 +02:00
Marta Marczykowska-Górecka
9764479aff
Tests for backup_utils file 2019-05-12 19:47:13 +02:00
Marta Marczykowska-Górecka
9252dad222
Tests for Qubes Backup 2019-05-12 19:47:12 +02:00
Marta Marczykowska-Górecka
893764a50c
Test changes related to fixes in https://github.com/QubesOS/qubes-manager/pull/176 2019-05-12 19:47:12 +02:00
Marta Marczykowska-Górecka
702ef75d1c
Tests for qube manager 2019-05-12 19:47:12 +02:00
Marta Marczykowska-Górecka
4fb9672d66
Tests for global settings 2019-05-12 19:47:12 +02:00
Marek Marczykowski-Górecki
af555fa9b1
Merge remote-tracking branch 'origin/pr/176' 
* origin/pr/176:
  Fixed logs display in Qube Manager
  Protected loading manager settings from malformed config files
  Fixed bug with hiding last visible column
  Added additional check for cloning a VM
  Fixed unnecessary property set in Global Settings
  Fixed bug in Global Settings
 2019-05-07 00:09:01 +02:00
Marek Marczykowski-Górecki
e997b4708d
Merge remote-tracking branch 'origin/pr/173' 
* origin/pr/173:
  Changed wording in Create New Qube and fixed minor bug
  Made terminology in Create New VM GUI clearer
 2019-05-07 00:06:33 +02:00
Marta Marczykowska-Górecka
768bfac019
Changed wording in Create New Qube and fixed minor bug 
references QubesOS/qubes-issues#4723
 2019-05-06 17:39:14 +02:00
Marta Marczykowska-Górecka
2634b3b229
Made terminology in Create New VM GUI clearer 
Changed the terms used in Create New VM Gui to the following:
-Qube based on a template (AppVM)
-Standalone qube
-Standalone qube copied from a template

references QubesOS/qubes-issues#4723
 2019-05-06 17:39:14 +02:00
Marta Marczykowska-Górecka
cb70b9bd65
Fixed logs display in Qube Manager 
Logs menu was not updated correctly on all occassions.
 2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
f5586e770b
Protected loading manager settings from malformed config files 
Malformed config files will no longer prevent Qube Manager from
starting.
 2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
0bb92311ba
Fixed bug with hiding last visible column 
Removed old buggy code, replaced it with disabling hiding the 'name'
column (because manager is useless without VM name).
 2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
ddb70fe8ea
Added additional check for cloning a VM 
An attempt to clone a VM to a name that is already in use will
fail more gracefully and with an explicit warning message.
 2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
733f00ddf2
Fixed unnecessary property set in Global Settings 2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
b9316bcd62
Fixed bug in Global Settings 
Incorrect handling of Check dom0 updates being set to false.

fixes QubesOS/qubes-issues#4988
 2019-05-03 14:41:00 +02:00
xaki23
f063aa5eea
treat kali-* as a variant of buster/sid 2019-04-11 01:06:01 +02:00
Marek Marczykowski-Górecki
baeabc2e8c
Merge remote-tracking branch 'qubesos/pr/171' 
* qubesos/pr/171:
  Fixed error in VM settings
 2019-04-05 22:10:24 +02:00
Marta Marczykowska-Górecka
6b6621abfc
Fixed error in VM settings 
fixes QubesOS/qubes-issues#4951
 2019-04-05 21:35:46 +02:00
Marek Marczykowski-Górecki
6585ab4f29
Merge remote-tracking branch 'origin/pr/166' 
* origin/pr/166:
  Refactored QThread classes for more clarity and less code duplication
  Fixed inconsisted icon in Qube Manager messages
 2019-04-05 00:53:32 +02:00
Marta Marczykowska-Górecka
6e10daa309
Refactored QThread classes for more clarity and less code duplication 2019-04-04 22:58:10 +02:00
Marek Marczykowski-Górecki
f4d0417e1a
Merge remote-tracking branch 'origin/pr/170' 
* origin/pr/170:
  Fix error on reverting Qube Manager to an older version
 2019-04-04 01:28:35 +02:00
Marek Marczykowski-Górecki
0cdbda5df9
Merge remote-tracking branch 'origin/pr/168' 
* origin/pr/168:
  Fixed device handling in VM settings widget
 2019-04-04 01:27:08 +02:00
Marek Marczykowski-Górecki
278a72d461
Merge remote-tracking branch 'origin/pr/167' 
* origin/pr/167:
  More documentation and added another column for default_dispvm to Qube Manager
  Added DVM Template column to Qube Manager
  Rewritten Qube Manager widgets
 2019-04-04 01:26:03 +02:00
Marta Marczykowska-Górecka
d2ad60edd2
Fix error on reverting Qube Manager to an older version 
In rare case (when the Qube Manager was reverted to an older version
that does not have a column on which it was last sorted) downgrading
Qube Manager could result in a crash on start.
 2019-04-03 20:49:33 +02:00
Marta Marczykowska-Górecka
077bcb3a8e
Fixed device handling in VM settings widget 
PCI devices are now handled as DeviceInfo objects, not (string,name) tuples;
furthermore, a device that no longer exists in the system can be
correctly removed via VM settings window (it is displayed as Unknown
device).

fixes QubesOS/qubes-issues#2789
 2019-04-03 20:47:09 +02:00
Marta Marczykowska-Górecka
c2e7010b25
More documentation and added another column for default_dispvm to Qube Manager 
Including also a minor visual fix - the headers in Qube Manager
will now be multi-line when it looks needed.

fixes QubesOS/qubes-issues#4912
 2019-04-03 19:21:25 +02:00
Marek Marczykowski-Górecki
8318db9b4e
Merge remote-tracking branch 'origin/pr/169' 
* origin/pr/169:
  Fixed device list behavior for a running VM in VM settings
 2019-04-03 16:43:37 +02:00
Marek Marczykowski-Górecki
1d65d692ad
Merge remote-tracking branch 'origin/pr/154' 
* origin/pr/154:
  Fix too long lines
  Moved busy_cursor() inside save_changes()
  Removed unneded calls to Override/Restore cursor
  Removed duplicated call to save_changes()
  Removed unneeded Cursor override/restore
  Added busy_cursor()
  Added BusyCursor for notify manager is working
  Revert "Added progress bar to __save_changes__"
  Revert "Increase progress wait time to 2s"
  Increase progress wait time to 2s
  Added progress bar to __save_changes__
  Remove unneeded slot connections and reject overwrite
 2019-04-03 16:19:10 +02:00
Marta Marczykowska-Górecka
6cf0e83b1d
Fixed device list behavior for a running VM in VM settings 
PCI devices will now correctly be unmodifiable if the VM is running.

fixes QubesOS/qubes-issues#4933
 2019-04-02 22:16:55 +02:00
donoban
b7228e8419
Fix too long lines 2019-04-01 11:48:11 +02:00
Marek Marczykowski-Górecki
57376456a7
Merge remote-tracking branch 'origin/pr/165' 
* origin/pr/165:
  Set the window title when cloning a qube
 2019-03-31 23:00:25 +02:00
Marek Marczykowski-Górecki
1d68a70356
Merge remote-tracking branch 'origin/pr/164' 
* origin/pr/164:
  Fixed minor error in Qubes Backup
 2019-03-31 23:00:07 +02:00
donoban
34adc75752
Moved busy_cursor() inside save_changes() 2019-03-31 20:04:04 +02:00
donoban
c85d6e4e8b
Removed unneded calls to Override/Restore cursor 2019-03-31 20:01:38 +02:00
donoban
16f2997222
Removed duplicated call to save_changes() 2019-03-31 19:59:55 +02:00
donoban
1fbf6c9a59
Removed unneeded Cursor override/restore 2019-03-31 19:58:52 +02:00
donoban
8e383e3022
Added busy_cursor() 
fix https://github.com/QubesOS/qubes-issues/issues/4744
 2019-03-31 19:56:01 +02:00
donoban
9750d990a7
Merge remote-tracking branch 'upstream/master' 2019-03-30 15:06:07 +01:00
Marta Marczykowska-Górecka
cf1dd0d355
Added DVM Template column to Qube Manager 
It is labelled "Template for DispVMs" and behaves like every
other column.

fixes QubesOS/qubes-issues#4912
 2019-03-29 19:04:45 +01:00
Marta Marczykowska-Górecka
2ce6e8b1cc
Rewritten Qube Manager widgets 
Less duplicate code and more extendability - now most
widgets are based on a single class.
 2019-03-29 18:33:51 +01:00
Marta Marczykowska-Górecka
fe810c5ad0
Fixed inconsisted icon in Qube Manager messages 
Now success will not be accompanied by a 'warning'
icon.

fixes QubesOS/qubes-issues#4922
 2019-03-29 17:01:15 +01:00
AJ Jordan
868632555b
Set the window title when cloning a qube 2019-03-27 21:37:27 -04:00
Marta Marczykowska-Górecka
8fbf3fd2a6
Fixed minor error in Qubes Backup 
Possibly due to changes in how services work,
the run_service_for_stdio was returning path with trailing
whitespace.

fixes QubesOS/qubes-issues#4921
 2019-03-27 18:31:26 +01:00
Marek Marczykowski-Górecki
26462a32ab
Merge remote-tracking branch 'origin/pr/163' 
* origin/pr/163:
  fix incorrect behavior after backup error
 2019-03-23 03:25:20 +01:00
Marta Marczykowska-Górecka
00ccce4816
Fixed minor errors found when debugging feature settings 
the check-updates default was being incorrectly set
 2019-03-21 14:47:03 +01:00
Marta Marczykowska-Górecka
597a3e728f
fix incorrect behavior after backup error 
the Backup Qubes tool failed to allow user to exit correctly
after backup errored out in any way.

fixes QubesOS/qubes-issues#4885
 2019-03-20 23:34:19 +01:00
donoban
8816a764ee
Merge remote-tracking branch 'upstream/master' 2019-03-17 17:09:13 +01:00
Marta Marczykowska-Górecka
1c06d241f0
Fix bug with fixed bug in VM Settings 
fixes QubesOS/qubes-issues#4866
 2019-03-11 22:02:32 +01:00
Marta Marczykowska-Górecka
e556c8f848
Fix bug with VM Settings 
Bug related to previous fixes to 'apply'; part of the code still
incorrectly assumed some attributes may not exist

fixes QubesOS/qubes-issues#4866
 2019-03-09 16:45:22 +01:00
Marek Marczykowski-Górecki
f6c8103f46
Fix boot CD image path validation 
re.match checks only beginning of the path. There should be
re.fullmatch.

Fixes QubesOS/qubes-issues#4860
 2019-03-07 02:54:10 +01:00
donoban
6469dd8341
Merge remote-tracking branch 'upstream/master' 2019-03-06 21:59:56 +01:00
Marek Marczykowski-Górecki
7874aa73fe
Merge remote-tracking branch 'origin/pr/158' 
* origin/pr/158:
  Fixed error in displaying error on VM Rename
 2019-02-26 23:12:35 +01:00
Marta Marczykowska-Górecka
26779a4826
Fixed error in displaying error on VM Rename 
VM rename was incorrectly trying to display an error by itself and not
use QThreads embedded mechanism.

fixes QubesOS/qubes-issues#4843
fixes QubesOS/qubes-issues#4767
 2019-02-26 21:10:22 +01:00
Marek Marczykowski-Górecki
94cefc9d09 Merge remote-tracking branch 'qubesos/pr/157' 
* qubesos/pr/157:
  Fixed error in detecting dvm-template having different NetVM
 2019-02-26 19:50:21 +01:00
Marek Marczykowski-Górecki
74987f6554 Merge remote-tracking branch 'qubesos/pr/156' 
* qubesos/pr/156:
  Fixed incorrect behavior after 'Apply' in Settings
 2019-02-26 19:49:04 +01:00
Marta Marczykowska-Górecka
b31a154e32
Fixed error in detecting dvm-template having different NetVM 
when the currect VM is the same as the dvm_template, there should be no
warning

fixes QubesOS/qubes-issues#4844
 2019-02-26 19:31:41 +01:00
Marta Marczykowska-Górecka
d23dafed28
Fixed incorrect behavior after 'Apply' in Settings 
Changes in some fields (to be precise, drop-downs) were discarded
in VM Settings when changed after an 'Apply' and before an 'OK'.

fixes QubesOS/qubes-issues#4833
 2019-02-26 18:02:36 +01:00
Marek Marczykowski-Górecki
9afa6faca0
Merge remote-tracking branch 'origin/pr/151' 
* origin/pr/151:
  Added "set as dvm template" to VM settings
 2019-02-23 18:40:07 +01:00
Marta Marczykowska-Górecka
ef6288f1ff
Added "set as dvm template" to VM settings 
Added an 'Advanced' settings checkbox that allows the user to set a given
VM as template fo dispvms. It sets both the template_for_dispvms property
and the appmenus-dispvm feature - instead of delving into particulars
of how and which should be set, the user can just turn off the
whole setting if they want to make some changes in the vm and then turn
it on again.

fixes QubesOS/qubes-issues#4004
 2019-02-23 18:27:22 +01:00
Marta Marczykowska-Górecka
faae2d0026
Added warning when setting NetVM 
When NetVM is set to something else than default_dispvm has set, a warning
icon appears.
 2019-02-19 22:27:28 +01:00
donoban
17fdb3c263
Added BusyCursor for notify manager is working 
https://github.com/QubesOS/qubes-issues/issues/4744
 2019-02-19 21:58:33 +01:00
donoban
56cc6c79e5
Revert "Added progress bar to __save_changes__" 
This reverts commit bb7b8c79ae.
 2019-02-19 21:46:38 +01:00
donoban
dda98610d5
Revert "Increase progress wait time to 2s" 
This reverts commit 0e9f8d4c45.
 2019-02-19 21:46:17 +01:00
donoban
0e9f8d4c45
Increase progress wait time to 2s 2019-02-17 20:37:16 +01:00
donoban
bb7b8c79ae
Added progress bar to __save_changes__ 2019-02-16 15:56:46 +01:00
donoban
a9a2022206
Remove unneeded slot connections and reject overwrite 2019-02-16 15:54:22 +01:00
Marek Marczykowski-Górecki
52188318b8
Enable seamless mode buttons for Windows template-based qubes too 
Fixes QubesOS/qubes-issues#4813
 2019-02-12 22:23:38 +01:00