Commit Graph

1213 Commits

Author SHA1 Message Date
Saswat Padhi
bf37bb366e
Avoid spurious warnings when setting NetVM
Qube Manager currently shows a security warning when changing the NetVM of TemplateVMs.
This warning is generally useful, but not when disabling networking;
for example changing the NetVM from from "default" to "none".

In this chnage I suppress the warning when the NetVM for a TemplateVM is changed to "none".
2021-05-15 18:32:18 -04:00
Marek Marczykowski-Górecki
1afd46da6b
Make pylint happy 2021-04-05 16:29:35 +02:00
Marek Marczykowski-Górecki
0e1c9cfeb9
Merge remote-tracking branch 'origin/pr/289'
* origin/pr/289:
  Fix spelling mistake in warning message
2021-04-05 15:41:48 +02:00
Marek Marczykowski-Górecki
29afe2a088
Merge remote-tracking branch 'origin/pr/290'
* origin/pr/290:
  Pass the command line arguments to LogDialog
2021-04-05 15:41:27 +02:00
Marek Marczykowski-Górecki
b2c40eb578
Merge remote-tracking branch 'origin/pr/258'
* origin/pr/258:
  qvm-template-gui: auto resize columns to the content
  qvm-template-gui: change date format to '%d %b %Y'
  qvm-template-gui: UX improvements
  Make pylint happy
  qvm-template-gui: improve displaying progress
  qvm-template-gui: UI improvements
  qvm-template: Include files in deb/rpm package
  qvm-template: Change size unit from kB to MB.
  qvm-template: Disable multi-selection for simplicity.
  qvm-template: Port initial code to PyQt.
  qvm-template: Initial GUI implementation.
2021-04-05 15:41:13 +02:00
Marek Marczykowski-Górecki
fcf5db817f
qvm-template-gui: auto resize columns to the content 2021-04-03 19:07:06 +02:00
Marek Marczykowski-Górecki
6c9514c034
qvm-template-gui: change date format to '%d %b %Y'
Make it always include month as a word, to less overwhelm the user with
a table full of numbers.
2021-04-03 19:07:06 +02:00
Marek Marczykowski-Górecki
099bbe99aa
qvm-template-gui: UX improvements
- hide license, URL and summary - those are the same for all the templates, and
  not really useful for the user
- remove repeated "Time" word from column headers
- use full "Repository" word as the column header
2021-04-03 19:07:06 +02:00
Demi Marie Obenour
883ae3b082
Pass the command line arguments to LogDialog
instead of only the first one.  That caused argv[1] to be iterated over,
meaning that LogDialog would see it as a list of one-character
filenames.  Hilarity ensued.
2021-04-02 23:39:45 -04:00
Marek Marczykowski-Górecki
be4e2050a1
Make pylint happy 2021-04-02 05:39:42 +02:00
Marek Marczykowski-Górecki
03a34fbedd
qvm-template-gui: improve displaying progress
The final version of qvm-template does not display untrusted data, so it
is safe to decode UTF-8. Specifically, this shows download progress bar
done using tqdm library.
For this to work, \r needs to be properly handled, as tqdm uses it to
erase the current line to update progress status. Since QTextEdit does
not support it natively, add a simple wrapper for this job.
Alternatively, qvm-template could be modified to display
machine-readable progress info that would be passed through QT progress
widget, but it would basically duplicate the work already done by tqdm
library. We might do this at some point, though.

And also enlarge progress window default size, to avoid wrapping.
2021-04-02 05:39:35 +02:00
Marek Marczykowski-Górecki
679a23980d
qvm-template-gui: UI improvements
- rename "install" button to "apply" - it also does remove and
  reinstall
- show button descriptions always
- show help text always, not only before selecting anything
- make the window a bit wider
2021-04-02 02:58:24 +02:00
Encrypted Giraffe
2e548f955c
Fix spelling mistake in warning message 2021-03-30 01:32:40 -06:00
Marek Marczykowski-Górecki
465d66189a
tests: changing netvm and template via right click 2021-02-25 02:30:47 +01:00
Marek Marczykowski-Górecki
66e478d968
tests: add a decorator for keeping event listener alive
This is useful for tests causing events in qube manager itsef (not just
external qvm-prefs calls). If event listener isn't connected at this
time, qube manager won't receive them and also qubesadmin internal cache
won't be refreshed.
2021-02-25 02:28:38 +01:00
Marek Marczykowski-Górecki
1e36eb9d30
Restore checkboxes to show/hide columns 2021-02-24 03:59:02 +01:00
Marek Marczykowski-Górecki
d253b50545
Merge remote-tracking branch 'origin/pr/273'
* origin/pr/273: (24 commits)
  Fix coherence in network menu when adding/removing domains
  Fix too long line
  Add warning if trying to change template VM
  Disable network menu for templates
  Display default netvm
  Fix possible 'None' default error
  Added default option for network change
  Wrap warnings message in self.tr()
  Added wait argument to start_vm
  Better dialog creation
  Added try/except for starting netvm
  Added error message to dialogs
  Added proper error handling and Check netvm_name is not None
  Changed checkboxes to icons
  Added change network confirmation
  Added Template Change Confirmation
  Moved change_* funcs after __init__()
  Added QMessageBox if netvm is halted and user wants to start it
  Added network_menu updates
  Added try/except for change_network
  ...
2021-02-24 02:29:13 +01:00
donoban
8034060896
Fix coherence in network menu when adding/removing domains 2021-02-09 21:11:35 +01:00
donoban
4e6cf91f63
Fix too long line 2021-02-03 00:07:41 +01:00
donoban
1edc4effd8
Add warning if trying to change template VM 2021-02-03 00:05:37 +01:00
donoban
37513dec7e
Disable network menu for templates 2021-02-03 00:04:30 +01:00
donoban
c4da25c6b7
Just warning message improve 2021-01-28 21:08:11 +01:00
donoban
94ede98007
Display default netvm 2021-01-25 21:27:50 +01:00
donoban
a02aeb4c25
Fix possible 'None' default error 2021-01-10 23:39:33 +01:00
Marek Marczykowski-Górecki
96612fa355
tests: update for recent changes
- create_new_vm rework - especially new VM type selection
- minor changes in the main manager table
- rework of logs dialog (the test for the actual dialog is still
  missing, the current one only checks if it's called with proper
  arguments)
2021-01-09 06:01:59 +01:00
Marek Marczykowski-Górecki
2f48fb33a3
create_new_vm: enable/disable "install system" option on template change
When choosing StandaloneVM type, the option to install a system should
be enabled when empty source template is set. Fix this when choosing VM
type first and only then changing template to empty.
2021-01-09 05:53:53 +01:00
donoban
9f44f7413d
Added default option for network change 2021-01-09 00:42:47 +01:00
Marek Marczykowski-Górecki
81c0872f2b
Merge remote-tracking branch 'origin/pr/278'
* origin/pr/278:
  fixed trailing spaces
  Added TemplateVM and disposableVM to Create New Qube
2021-01-05 21:17:35 +01:00
Marek Marczykowski-Górecki
7f257b1c8e
Merge remote-tracking branch 'origin/pr/275'
* origin/pr/275:
  Replace '2' with Qt.Checked
  Rename 'Include in backups' to 'Backup'
  flags() rewrite
  Fix empty lines
  Include in backups changed to 'CheckStateRole'
2021-01-05 21:17:12 +01:00
donoban
b72cc34a83
Wrap warnings message in self.tr() 2020-12-16 11:30:39 +01:00
ctrlaltf24
1f26067a1d
fixed trailing spaces 2020-12-13 09:23:39 -08:00
donoban
c666357625
Replace '2' with Qt.Checked 2020-12-12 14:22:15 +01:00
donoban
1812989ecd
Rename 'Include in backups' to 'Backup' 2020-12-12 14:18:34 +01:00
donoban
9152218921
Merge branch 'master' of https://github.com/QubesOS/qubes-manager into template_menu
# Conflicts:
#	qubesmanager/qube_manager.py
#	ui/qubemanager.ui
2020-12-12 14:08:41 +01:00
donoban
f95bcbb1bc
Added wait argument to start_vm
Easier error handling for start vm's from other places
2020-12-12 00:34:41 +01:00
donoban
4343691b92
Better dialog creation 2020-12-12 00:19:30 +01:00
donoban
81d95f3de9
Added try/except for starting netvm 2020-12-12 00:08:49 +01:00
donoban
b29934b898
Added error message to dialogs 2020-12-11 23:48:16 +01:00
donoban
2164b82c34
Changed filter to list comprehension (avoids pylint warning) 2020-12-11 01:01:21 +01:00
donoban
df0e4699a0
File checking and error dialog moved to qube_manager 2020-12-11 00:53:57 +01:00
donoban
0cb89e611a
Added proper error handling and Check netvm_name is not None 2020-12-11 00:38:06 +01:00
donoban
f90ab86a73
Merge branch 'master' of https://github.com/QubesOS/qubes-manager into template_menu
# Conflicts:
#	qubesmanager/qube_manager.py
2020-12-11 00:07:51 +01:00
donoban
78d76eb70f
Fix Spanglish accident 2020-12-10 23:46:44 +01:00
donoban
a49463a30b
Merge branch 'log_dialog' of https://github.com/donob4n/qubes-manager into log_dialog 2020-12-10 23:43:49 +01:00
donoban
ebe777c5a1
Merge branch 'master' of https://github.com/QubesOS/qubes-manager into log_dialog
# Conflicts:
#	qubesmanager/qube_manager.py
#	ui/qubemanager.ui
2020-12-10 23:39:34 +01:00
donob4n
b5e092fa8b
Update qubesmanager/log_dialog.py
Co-authored-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
2020-12-10 09:49:41 +01:00
Marek Marczykowski-Górecki
3d1ff3e58d
Merge remote-tracking branch 'origin/pr/272'
* origin/pr/272:
  Save 'compactview' state
  Added 'Compact View' Action
2020-12-10 05:17:52 +01:00
Marek Marczykowski-Górecki
c44880f9f5
Merge remote-tracking branch 'origin/pr/270'
* origin/pr/270:
  Restored removed lines by accident (although I think that are useless at this moment)
  Fix pylint warnings
  Added saving and restore settings for showing checkboxes
  Removed unused import
  Enable 'Show' checkboxes by default
  Added filterAcceptsRow() to QubesProxyModel
  Added 'Show' Checkboxes to .ui
  Fix SelectionMode on ui file
2020-12-10 05:07:27 +01:00
ctrlaltf24
c7b28ca6c8
Added TemplateVM and disposableVM to Create New Qube 2020-12-09 13:55:22 -08:00
donoban
4fa13d3295
Pylint fixes 2020-12-05 12:41:20 +01:00