869 Commits

Author	SHA1	Message	Date
donoban	c43a47019e	Added missing updates() method for some widget ... internal, ip, include_in_backups and last_backup	2018-05-10 17:59:07 +02:00
donoban	a77cc5172d	Fix missing template updates-available	2018-05-10 10:04:17 +02:00
donoban	78ba3057eb	Added startup progress dialog	2018-05-10 09:49:22 +02:00
donoban	1dcfc6e634	Removed debug print	2018-05-09 19:42:45 +02:00
donoban	224c8708fc	Outdated state cleanup ... Fixes problems showing 'outdated' instead 'to-be-outdated' when template is running Fixes the removal of the icon calling setVisible(False) before removeWidget()	2018-05-09 19:39:41 +02:00
donoban	e2fccf592a	Revert "Removed progress wait when updating template" ... This reverts commit 9633f6e9c6.	2018-05-09 15:50:39 +02:00
donoban	ce07b9dcb1	This tries to fix some rare case when it stops receieving dbus events	2018-05-09 14:37:46 +02:00
donoban	806915f834	Added Timer for template updates ... Since there is no template updates dbus events, we need to check it periodically	2018-05-09 14:36:39 +02:00
donoban	bc07e37266	Refresh table selection when pause/resume ... Since them dont have dbus events we need to manually update the selection	2018-05-09 12:05:07 +02:00
donoban	e2e66cbccb	Added calls to table_selection_changed() ... If row updated is the selected row we need to update start/pause/stop buttons	2018-05-09 11:48:19 +02:00
donoban	027d106507	VmRowInTable dbus events moved to VmManagerWindow ... Since we need to do some updates affecting all vms or the Window itself, this is a better place for handling this.	2018-05-09 11:31:44 +02:00
donoban	bfc54b779f	- Removed unnedeed calls to vms_in_table[vm.qid].update() ... - Fixed unpause case where it was not properly updated	2018-05-07 22:50:13 +02:00
donoban	5e6c0539c2	- Removed update_single_row() and add direct calls to update() ... (Some of them could be deleted since dbus events will handle them) - Removed update_table() and TODO refering dbus events	2018-05-07 22:26:39 +02:00
donoban	5b846a73cc	Removed unneeded calls to table.update()	2018-05-07 22:21:17 +02:00
donoban	8753119327	Initial version with dbus ... - Added connections for PropertiesChanged for each VM in VmRowInTable - DomainAdded/Removed handled in VmManager	2018-05-07 21:10:15 +02:00
donoban	ddf2e73f20	- Remove some stuff on fill_table since its only called once on startup ... - Removed table.setEnabled/Disabled tweak since I dont see any improvement, maybe because fill_table() is only called without the window shown - Removed unneeded update_table() calls, dbus events will handle them	2018-05-07 20:50:20 +02:00
donoban	be055d8b41	Revert order of fill_table() and show() and removed the timer ... This does not seem to have any problem and the manager window appears already filled which seems more user friendly	2018-05-07 13:30:03 +02:00
donoban	07d36a9149	Added update() methods on some widgets for update them without recreating ... Fixed some problems with update/status notifications, probably need some additional tunning	2018-05-07 13:17:43 +02:00
donoban	9633f6e9c6	Removed progress wait when updating template	2018-05-03 11:34:11 +02:00
Marta Marczykowska-Górecka	5cfa0bb9c0	Fix bug in Qube Manager ... Accidentaly, the fix significantly improves start time (at least on two of my machines). fixes QubesOS/qubes-issues#3760	2018-03-30 01:15:23 +02:00
Marek Marczykowski-Górecki	f74783af7e	Merge remote-tracking branch 'qubesos/pr/84' ... * qubesos/pr/84: Tiny fix for Qube Manager params	2018-03-28 18:02:16 +02:00
Marta Marczykowska-Górecka	674b80613d	Tiny fix for Qube Manager params ... Made Qube Manager params consistent with other manager tools (first Qt, then Qubes).	2018-03-28 17:43:57 +02:00
Marek Marczykowski-Górecki	d4324d4873	Merge remote-tracking branch 'qubesos/pr/83' ... * qubesos/pr/83: Fix for updates-available in qube-manager	2018-03-28 17:36:20 +02:00
Marek Marczykowski-Górecki	91fbc43b5e	Merge remote-tracking branch 'qubesos/pr/82' ... * qubesos/pr/82: Check if VM needs killing before murdering it	2018-03-28 16:42:55 +02:00
Marek Marczykowski-Górecki	68b6f2351c	Merge remote-tracking branch 'qubesos/pr/81' ... * qubesos/pr/81: Less horrible Qube Manager loading	2018-03-28 16:42:15 +02:00
Marta Marczykowska-Górecka	70d139e7f3	Fix for updates-available in qube-manager ... After fixing another bug, update status for a VM was not initialized correctly. fixes QubesOS/qubes-issues#3745	2018-03-26 18:21:46 +02:00
Marta Marczykowska-Górecka	20cabb5563	Check if VM needs killing before murdering it ... In some cases, when the user waited some time before force-killing a VM, it could be already dead. fixes QubesOS/qubes-issues#3730	2018-03-25 12:29:05 +02:00
Marek Marczykowski-Górecki	2d6b6488ea	Merge remote-tracking branch 'qubesos/pr/79' ... * qubesos/pr/79: Fixed GUI Restore tool bug	2018-03-20 01:26:44 +01:00
Marta Marczykowska-Górecka	3ca7520b0e	Less horrible Qube Manager loading ... The window should first display itself, and then get gradually filled with VMs (more user friendly, less annoying than waiting for something, anything to appear). Also fixed a dumb bug with double refreshing and a useless variable. fixes QubesOS/qubes-issues#3719	2018-03-19 22:40:50 +01:00
Marta Marczykowska-Górecka	7117892f4b	Fixed GUI Restore tool bug ... GUI Restore tool was unable to open file selection dialog in dom0. fixes QubesOS/qubes-issues#3701	2018-03-15 00:18:43 +01:00
Marta Marczykowska-Górecka	7ed386985d	Added default_dispvm to Global Settings ... Added "default dispvm" to Global Settings. references QubesOS/qubes-issues#3688	2018-03-14 22:21:33 +01:00
Marek Marczykowski-Górecki	e1aca0a393	Merge remote-tracking branch 'qubesos/pr/77' ... * qubesos/pr/77: Don't catch AttributeError for is_outdated() call anymore Call is_outdated() on volume object, not name	2018-03-14 21:36:29 +01:00
Marek Marczykowski-Górecki	feeedb5526	Merge remote-tracking branch 'qubesos/pr/76' ... * qubesos/pr/76: Fixed a bunch of useless asserts	2018-03-14 21:33:57 +01:00
Marek Marczykowski-Górecki	b0ebb76bf3	Merge remote-tracking branch 'qubesos/pr/75'	2018-03-14 21:33:01 +01:00
Rusty Bird	24dcb4802e	Don't catch AttributeError for is_outdated() call anymore	2018-03-14 00:07:22 +00:00
Rusty Bird	774b3bb2c9	Call is_outdated() on volume object, not name ... Note that this is still a no-op, because admin.vm.volume.Info does not transmit is_outdated, so the qubesadmin wrapper defaults it to False.	2018-03-14 00:07:21 +00:00
Marta Marczykowska-Górecka	fcaca57fc6	Fixed a bunch of useless asserts ... Replaced them with a more flexible behavior or removed if they were not actually necessary (and handled elsewhere). fixes QubesOS/qubes-issues#3623	2018-03-10 22:31:41 +01:00
Marta Marczykowska-Górecka	bce5c32c96	Added "Exit" option to Qube Manager ... fixes QubesOS/issues#3683	2018-03-10 20:04:57 +01:00
Marta Marczykowska-Górecka	91538f1aaf	Apply changes in global settings only when actual changes occurred ... Fixed apply methods to check if there is an actual need to apply changes.	2018-03-02 14:30:56 +01:00
Marta Marczykowska-Górecka	43520331f2	Fix pylint's critique	2018-03-02 01:04:02 +01:00
Marta Marczykowska-Górecka	94c0a45f86	Fixed minor error in previous fix	2018-03-02 00:43:43 +01:00
Marta Marczykowska-Górecka	b08ce9524f	Replaced single check vm updates checkbox ... Now there is a checkbox for the default for new VMs, and two buttons to either disable checking for updates in all VMs or enable it in all VMs.	2018-02-22 22:24:34 +01:00
Marta Marczykowska-Górecka	02117b1870	Restored check-dom0-updates functionality in Global Settings ... Currently it uses a workaround, manually creating a file in /var/lib/qubes/updates; once the appropriate attribute will start working it will be used instead.	2018-02-22 22:22:45 +01:00
Marta Marczykowska-Górecka	0700275586	De-uglify kernel selection in Global Settings ... Replaced kernel selection with utils.prepare_kernel; also added option to utils.prepare_choice to treat empty string as None (applicable to kernels).	2018-02-22 22:22:42 +01:00
Marta Marczykowska-Górecka	4882013a32	De-uglify default template in Global Settings ... Replaced old, manual vm list with a nicer, less disgusting utils.prepare_vm_choice approach.	2018-02-22 22:21:39 +01:00
Marta Marczykowska-Górecka	84d7e8bf9c	Allow setting default NetVM to None in Global Settings ... Replaced old, manual vm list with a nicer, less disgusting utils.prepare_vm_choice approach.	2018-02-22 22:21:39 +01:00
Marta Marczykowska-Górecka	29a56d9c88	Fixed error in setting Clockvm to None in Global Settings ... Replaced old, manual vm list with a nicer, less disgusting utils.prepare_vm_choice approach.	2018-02-22 22:21:39 +01:00
Marta Marczykowska-Górecka	c1e9074cb9	Fixed error in setting Updatevm to None in Global Settings ... Replaced old, manual vm list with a nicer, less disgusting utils.prepare_vm_choice approach.	2018-02-22 22:21:39 +01:00
Marek Marczykowski-Górecki	fb4870a16b	Merge remote-tracking branch 'qubesos/pr/72' ... * qubesos/pr/72: Added 'Apply' button to VM Settings	2018-02-22 18:15:23 +01:00
Marek Marczykowski-Górecki	fb8b19af81	Merge remote-tracking branch 'qubesos/pr/71' ... * qubesos/pr/71: Fixed bug 3594	2018-02-22 18:14:28 +01:00
Marek Marczykowski-Górecki	a141e40e9c	Merge remote-tracking branch 'qubesos/pr/70' ... * qubesos/pr/70: Allow restarting auto_cleanup=False DispVMs	2018-02-22 18:13:32 +01:00
Marta Marczykowska-Górecka	8218f5fde1	Added 'Apply' button to VM Settings ... Simple "Apply" button. fixes QubesOS/qubes-issues#3321	2018-02-20 20:32:00 +01:00
Marta Marczykowska-Górecka	dc0f8c0a9e	Fixed bug 3594 ... Incorrect targetVM display - dom0 was not included, and the code erroneously assumed that not only it is included, but also it's always the first in the dropdown. No more assumptions. fixes QubesOS/qubes-issues#3594	2018-02-20 19:22:57 +01:00
Rusty Bird	07866cbfc4	Allow restarting auto_cleanup=False DispVMs	2018-02-20 08:25:22 +00:00
Marta Marczykowska-Górecka	e95be8a8ed	Is this bug finally dead ... Yet another attempt at stomp this zombie monstrosity. fixes QubesOS/qubes-issues#3570	2018-02-13 20:26:55 +01:00
Marek Marczykowski-Górecki	b3699d27d5	Merge remote-tracking branch 'qubesos/pr/67' ... * qubesos/pr/67: Boot from device window fix	2018-02-13 05:06:06 +01:00
Marek Marczykowski-Górecki	09805396bb	Merge remote-tracking branch 'qubesos/pr/65' ... * qubesos/pr/65: Changes according to @marmarek's request Shutting down vm from qube manager bug Refreshing vm list in qube manager fixed Qube manager updates more sensibly	2018-02-13 05:05:24 +01:00
Marta Marczykowska-Górecka	8640fa7ace	Boot from device window fix ... The window wasn't closing properly.	2018-02-11 00:20:14 +01:00
Marta Marczykowska-Górecka	45959aef71	Changes according to @marmarek's request	2018-02-10 23:41:36 +01:00
Marek Marczykowski-Górecki	ec7c65de34	Merge remote-tracking branch 'qubesos/pr/64' ... * qubesos/pr/64: Bugfixed Fixed error in creating new VMs from GUI	2018-02-10 23:41:10 +01:00
Marek Marczykowski-Górecki	83936ba93e	Merge remote-tracking branch 'qubesos/pr/66' ... * qubesos/pr/66: Fixed incorrect default dispvm settings	2018-02-10 23:35:12 +01:00
Marta Marczykowska-Górecka	c1bb8ba2ad	Bugfixed ... According to @marmarek's request	2018-02-10 23:34:59 +01:00
Marek Marczykowski-Górecki	712e95617a	Merge remote-tracking branch 'qubesos/pr/63' ... * qubesos/pr/63: Fixed bug with template selection Fixed errors with virt mode choice	2018-02-10 23:28:39 +01:00
Marek Marczykowski-Górecki	1fe280538e	Merge remote-tracking branch 'qubesos/pr/61' ... * qubesos/pr/61: Once more to fix this pesky bug	2018-02-10 23:24:17 +01:00
Marta Marczykowska-Górecka	8da0d35110	Fixed incorrect default dispvm settings ... Fixed error in DispVM selection in VM settings fixes QubesOS/qubes-issues#3565	2018-02-10 22:54:00 +01:00
Marta Marczykowska-Górecka	5af2709029	Shutting down vm from qube manager bug ... Hopefully, finally fixes issue #3501. fixes QubesOS/qubes-issues#3501	2018-02-09 22:08:07 +01:00
Marta Marczykowska-Górecka	1d995de095	Refreshing vm list in qube manager fixed ... If a new VM was created via button in vm settings, the refresh button will now correctly display it.	2018-02-09 21:59:43 +01:00
Marta Marczykowska-Górecka	dac7a6f208	Qube manager updates more sensibly ... Many events now cause the Qube Manager to refresh better - just the appropriate row, for example.	2018-02-09 21:36:30 +01:00
Marta Marczykowska-Górecka	dc9f764baa	Fixed error in creating new VMs from GUI ... Virt mode was forcibly set to HVM. Now, the virt mode is left as default, unless a standalone VM with system installed from elsewhere is selected. fixes QubesOS/qubes-issues#3515	2018-02-06 15:47:00 +01:00
Marta Marczykowska-Górecka	0ec3c704dd	Fixed bug with template selection ... Template in VM settings was not displayed correctly. It should work now.	2018-02-06 15:38:20 +01:00
Marta Marczykowska-Górecka	2be8f8bcea	Fixed errors with virt mode choice ... Current virtualization mode wasn't displayed correctly. It should work now. fixes QubesOS/qubes-issues#3517	2018-02-06 15:31:17 +01:00
Marta Marczykowska-Górecka	81e5a92e66	Once more to fix this pesky bug ... fixes QubesOS/qubes-issues#3501	2018-01-30 17:11:28 +01:00
Marek Marczykowski-Górecki	b28bd6e797	Merge remote-tracking branch 'qubesos/pr/60' ... * qubesos/pr/60: Repaired manager icons Removed 'Seamless GUI' checkbox from VM settings Change default Qube Manager size Renamed 'VM' to 'qube' everywhere in manager	2018-01-29 23:55:07 +01:00
Marta Marczykowska-Górecka	71090b9e72	Change default Qube Manager size ... So that it will fit all VMs from a default install.	2018-01-28 20:38:40 +01:00
Marta Marczykowska-Górecka	3a60f9146a	Renamed 'VM' to 'qube' everywhere in manager ... At least I hope it's everywhere. Note: AppVM and NetVM nomenclature have been kept as before.	2018-01-28 20:26:29 +01:00
Marta Marczykowska-Górecka	cb1519b56c	Fixed error on VM shutdown in Qube Manager ... fixes QubesOS/qubes-issues#3501	2018-01-28 18:23:18 +01:00
Marta Marczykowska-Górecka	4ec36de20d	Changes as requested by @marmarek	2018-01-26 23:17:02 +01:00
Marta Marczykowska-Górecka	46fe3725d1	Refresh Qube Manager list after closing VM settings ... Now the Qube Manager refreshes VM list after VM settings are launched and closed.	2018-01-23 20:44:59 +01:00
Marta Marczykowska-Górecka	cd8a243f5c	Fixes to resizing in Qube Manager ... Change column resize mode to interactive and stretch last column, so there's no useless space on the right. Also minor fix to sorting last_timestamp column, for more readability and also to fix a rare bug.	2018-01-23 20:28:19 +01:00
Marek Marczykowski-Górecki	81413907bf	Merge remote-tracking branch 'qubesos/pr/55' ... * qubesos/pr/55: Fixed according to @marmarek request Fixed according to @marmarek request Added 'configure no strict reset for PCI devices' button Adding a button to list PCI devices and enable no-strict-reset Fixed some indents and whitespaces Fixed python2 in settings.py	2018-01-19 03:01:57 +01:00
Marta Marczykowska-Górecka	b158aeccbd	Fixed according to @marmarek request	2018-01-19 02:50:04 +01:00
Marta Marczykowska-Górecka	1b9737c1a7	Fixed according to @marmarek request	2018-01-19 01:48:46 +01:00
Marta Marczykowska-Górecka	03ba645009	Fixed according to @marmarek request	2018-01-19 01:24:11 +01:00
Marta Marczykowska-Górecka	f1964f0c5b	Merge branch 'master' into virt-mode-select-fixes	2018-01-19 00:36:38 +01:00
Marta Marczykowska-Górecka	2cffffdcff	Fixed error in qubesmanager utils ... Fix in app.labels caused an old workaround to malfunction. fixes QubesOS/qubes-issues#3475	2018-01-18 23:49:17 +01:00
Marta Marczykowska-Górecka	985f8fb56d	Fixed error in qube-manager ... Last backup timestamp was not correctly processed.	2018-01-18 23:42:34 +01:00
Marta Marczykowska-Górecka	484f724838	Fixes to make pylint stop complaining	2018-01-17 12:13:04 +01:00
Marta Marczykowska-Górecka	48c3bfa798	Merge branch 'master' into virt-mode-select-fixes	2018-01-16 20:04:16 +01:00
Marta Marczykowska-Górecka	1a5a1fa7ee	Minor fixes to virt_mode select pull request ... Changes: - added hints about "which virt mode should I use" - changed displayed virt modes to show modes in all caps closes #44	2018-01-16 19:56:45 +01:00
Marta Marczykowska-Górecka	801014f2e5	Added 'configure no strict reset for PCI devices' button ... The button is in 'devices' tab of VM settings; it allows the user to select which devices should have 'no-strict-reset' enabled and tells the user not to change this setting if there are no errors. fixes QubesOS/qubes-issues#3205	2018-01-13 00:25:48 +01:00
Marta Marczykowska-Górecka	f4fae54057	Adding a button to list PCI devices and enable no-strict-reset	2018-01-13 00:25:46 +01:00
Marta Marczykowska-Górecka	60143e6a91	Fixed some indents and whitespaces ... Fixed indents and whitespace that pylint was complaining about.	2018-01-13 00:25:02 +01:00
Marta Marczykowska-Górecka	ec3d6eb84a	Fixed python2 in settings.py ... settings.py was erroneously using python2. Replaced with python3.	2018-01-13 00:19:58 +01:00
Marek Marczykowski-Górecki	90f7f8474d	Merge remote-tracking branch 'qubesos/pr/54' ... * qubesos/pr/54: Fixed minor error in VM Settings	2018-01-12 04:39:31 +01:00
Marek Marczykowski-Górecki	57d723c61e	Merge remote-tracking branch 'qubesos/pr/53' ... * qubesos/pr/53: Renamed 'VM' to 'qube' in GUI Added warning that the VM is currently running Fixed missing import	2018-01-12 04:37:00 +01:00
Marta Marczykowska-Górecka	670c41e4ff	Fixed minor error in VM Settings ... When init page was 'firewall', the tool incorrectly displayed warnings about wrong firewall vm configuration, without actually checking if they should be displayed.	2018-01-12 04:30:47 +01:00
Marta Marczykowska-Górecka	b1dc2458f6	Code review changes ... As requested by @marmarek	2018-01-10 02:18:51 +01:00
Marta Marczykowska-Górecka	f86139d0d2	Renamed 'VM' to 'qube' in GUI ... For consistency with new terminology.	2018-01-08 20:09:56 +01:00
Marta Marczykowska-Górecka	45496f73de	Added warning that the VM is currently running ... Added warning that the VM is currently running. User still must shut it manually (by design).	2018-01-08 20:05:25 +01:00
Marta Marczykowska-Górecka	839696f6f9	Fixed missing import ... Fixed missing import in boot-from-cdrom tool. fixes QubesOS/qubes-issues#3421	2018-01-08 20:00:55 +01:00
Marta Marczykowska-Górecka	1cee3a5fe3	Fixed 'About' window ... Surprisingly, it has not been touched since 3.2. It should work now.	2018-01-08 04:22:54 +01:00
Marta Marczykowska-Górecka	e19793ea7a	Minor display fix ... Changed "size on disk" widget to display only two decimal places.	2018-01-08 04:22:54 +01:00
Marta Marczykowska-Górecka	899ca6d394	Pylint corrections ... Removed errors discovered by pylint, or told it to be quiet when needed.	2018-01-08 04:22:54 +01:00
Marta Marczykowska-Górecka	41b8e6a4fb	Replaced 'VM' with 'Qube' ... Renamed 'VM' to 'Qube' in the user interface for Qube Manager.	2018-01-08 04:22:54 +01:00
Marta Marczykowska-Górecka	8b5e2a8d66	Qube Manager in working order ... Everything that should work works. Further improvements that would be nice: - replace untidy multitude of QtGui Items with one generic type - restore Qubes Network functionality - add Boot From Device action (and easy way to install windows tool from there) fixes QubesOS/qubes-issues#2966 QubesOS/qubes-issues#2132	2018-01-08 04:22:35 +01:00
Marta Marczykowska-Górecka	d57e58ae4d	Further work on qubes manager	2018-01-06 23:05:33 +01:00
Marta Marczykowska-Górecka	443f48c648	Recreation of the old qubes manager in a leaner, cut-down form. First ... commit, WIP.	2018-01-06 23:03:19 +01:00
Marta Marczykowska-Górecka	bb8abff988	Suggested changes ... included changes as suggested by @marmarek.	2018-01-06 02:21:07 +01:00
Marta Marczykowska-Górecka	df31207028	Final tiny fix of unused import ... Threw out unused import of shutil.	2017-12-11 02:41:50 +01:00
Marta Marczykowska-Górecka	67a32b5748	Added 'compression' checkbox to backup GUI ... Added 'compress the backup' checkbox to the backup GUI. fixes QubesOS/qubes-issues#943	2017-12-11 02:37:50 +01:00
Marta Marczykowska-Górecka	7fd0c58303	Restored 'cancel' functionality ... Now user can actually cancel a backup/restore.	2017-12-11 02:28:15 +01:00
Marta Marczykowska-Górecka	14ebf9dc6d	Fixed opening file dialog at the end ... Now, when "open file dialog to unmount" option is enabled, a fie dialog actually opens.	2017-12-11 02:07:10 +01:00
Marta Marczykowska-Górecka	a4a58cc527	Fixed progress bars ... Partial fix - the progress bars now move, although they do not really indicate progress (just dance back and forth). Future fix would include making a tray icon to signal backup progress instead.	2017-12-11 01:32:26 +01:00
Marta Marczykowska-Górecka	78b4747e81	Second pylint pass ... Fixed errors pointed out by pylint on server.	2017-12-11 01:15:07 +01:00
Marta Marczykowska-Górecka	a1c6e72569	First pylint pass ... Fixed errors pointed out by pylint.	2017-12-11 00:56:27 +01:00
Marta Marczykowska-Górecka	4e2835531e	Usability fixes ... Added label to inform the user only running VMs are listed in backup GUI; made "ignore missing" label clearer.	2017-12-11 00:13:15 +01:00
Marta Marczykowska-Górecka	7848b6b2c3	Fixed inability to select which VMs to restore ... Fixed bug that caused all VMs to be restored, regardless of what the user selected.	2017-12-10 23:56:22 +01:00
Marta Marczykowska-Górecka	7bcde2158e	Added optional saving of default backup profile ... Added checkbox for saving default backup profile. Removed useless "should I encrypt" checkbox (yes, you have to encrypt).	2017-12-10 23:19:16 +01:00
Marta Marczykowska-Górecka	9d73ceb99d	Fixed imports ... Fixed import * and unused imports.	2017-12-10 22:11:07 +01:00
Marta Marczykowska-Górecka	7a4e4b35d5	Initial backup-and-restore GUI restoration ... Initial restoration: basic backup-and-restore works, but - progress bar in backup does not work - selecting only some VMs to restore does not work - various miscellaneous enhancements are not yet in place	2017-12-10 21:14:14 +01:00
Marek Marczykowski-Górecki	c403fc1e8f	Merge branch 'firewall_warnings' ... * firewall_warnings: Sort items in settingsdlg.ui / firewall tab Enabled Firewall config without a netvm	2017-11-21 02:42:27 +01:00
Marta Marczykowska-Górecka	5b19c825e3	Enabled Firewall config without a netvm ... Enabled Firewall tab even when there's no working netvm or the netvm doesn't support qubes-firewall. An appropriate warning label and message are shown in both cases. fixes QubesOS/qubes-issues#3290	2017-11-20 14:20:01 +01:00
Marta Marczykowska-Górecka	eeac042662	Fixed bug with firewall GUI settings ... Fixed bug that led to correct firewall configuration not being recognized by GUI VM Settings. fixes QubesOS/qubes-issues#3289	2017-11-17 19:12:06 +01:00
Marta Marczykowska-Górecka	5f1e4803fe	Applied corrections from @marmarek	2017-11-17 17:42:19 +01:00
Marta Marczykowska-Górecka	135060dfe7	Final corrections ... Errors that my local pylint ignored and travis' pylint didn't.	2017-11-14 15:44:43 +01:00
Marta Marczykowska-Górecka	8cfc93c70c	Misc errors part 2 ... Renamed variable from 'input' to 'input_string' and moved imports to a better place (that is, at the beginning of the module and not inside of a function).	2017-11-09 17:57:21 +01:00
Marta Marczykowska-Górecka	8b296fab0d	Disable too-many-attributes warning ... It's the settings window, it has a lot of attributes.	2017-11-09 17:41:10 +01:00
Marta Marczykowska-Górecka	95599dff9f	A bunch of misc errors ... Fixed a bunch of small errors: bad indents, superfluous parentheses, missing whitespace, superfluous statement.	2017-11-09 17:41:10 +01:00
Marta Marczykowska-Górecka	e543144aec	Too-few-public-methods warning ... Checked, are sensible, disabled pylint warnings.	2017-11-09 17:41:10 +01:00
Marta Marczykowska-Górecka	3d841cf14f	Checked too-many-returns error ... Checked both places with a 'too-many-return-statements' warning, both were sensible, marked them as such.	2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka	6670f59853	Fixed regex strings ... Fixed regex strings that were not marked as raw.	2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka	59a9b7da40	Redefined variable type ... Marked places where redefining variable type was actually sensible as such.	2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka	0115c931d2	Variables defined outside init ... Defined them inside init and added description.	2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka	ff4ee713b1	Removed unnecessary global variables ... Removed three variables set to global, which were all used only in their respective "main" function.	2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka	b7060e76b2	Fixed no-self-use error ... Turned methods into static methods when possible.	2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka	695303f16a	Fixed unused variables ... When possible removed, otherwise renamed to start with an underscore.	2017-11-09 16:26:05 +01:00
Marta Marczykowska-Górecka	3f7f5a9da3	Firewall GUI fix ... Fixed error when service would be left empty, but the settings window would nonetheless emit an error.	2017-11-09 16:19:14 +01:00
Marta Marczykowska-Górecka	b9e4f99fec	Fixed unusued arguments ... Places where the variable is used in a overriding method were marked for pylint to ignore them.	2017-11-09 16:19:12 +01:00
Marta Marczykowska-Górecka	04aa844a9d	Removed variable "anything_changed" ... It was assigned in 17 places and not used otherwise in any other place. It's highly likely it was useless.	2017-11-09 16:18:23 +01:00
Marta Marczykowska-Górecka	6e5d611f70	Fixed invalid names ... Fixed camel case, too long and too short variable and function names.	2017-11-09 16:18:16 +01:00
Marta Marczykowska-Górecka	d7fbacf0d7	Fixed broad exceptions ... Fixed broad exception errors: replacing them with more precise error catching where sensible and adding appropriate pylint skip comments where not.	2017-11-08 15:40:35 +01:00
Marta Marczykowska-Górecka	2b24abb8c8	Fixed trailing and bad whitespaces ... Fixed trailing and bad whitespaces	2017-11-06 23:55:58 +01:00
Marta Marczykowska-Górecka	91572eea2d	Fixed too-long lines ... Fixed lines over 80 characters.	2017-11-06 23:55:58 +01:00
Marta Marczykowska-Górecka	c252e9ec3c	Fixed wildcard imports ... Fixed wildcard imports and any further problems resulting from them.	2017-11-06 23:55:58 +01:00
Marta Marczykowska-Górecka	eaccc323fb	Fixed unused imports ... Fixed all unused imports errors.	2017-11-06 23:20:09 +01:00
Marta Marczykowska-Górecka	3009610a62	Fixed GPL license ... Replaced old, address-having, too-many-characters-in-a-line version with the new one with URL.	2017-11-06 21:06:30 +01:00
Marta Marczykowska-Górecka	41b602ec48	Initial setup ... Initialize .pylintrc, put ignore in used files' headers.	2017-11-06 20:36:09 +01:00
Marta Marczykowska-Górecka	ef86e33dee	Style fixes ... Changes requested by @marmarek	2017-11-06 19:45:36 +01:00
Marta Marczykowska-Górecka	b7e4e55d05	Added Clone VM button ... Button added on the basic tab of VM Settings. Also some refactoring to clean up the rename/clone/delete buttons.	2017-11-03 23:50:04 +01:00
Marta Marczykowska-Górecka	458968d37f	Added Remove VM button ... Button added on the basic tab of VM Settings. Button active only when VM is shutdown; furthermore, requires the user to enter full VM name to confirm.	2017-11-03 22:20:34 +01:00
Marek Marczykowski-Górecki	d165bd33b6	Merge remote-tracking branch 'qubesos/pr/45' ... * qubesos/pr/45: Firewall settings	2017-10-21 01:38:20 +02:00
Marek Marczykowski-Górecki	43576d786c	Fix setting include_in_balancing checkbox ... Generally vm.features values are strings, need to cast them to boot to use in such context. Additionally fix typo in feature name ('services' -> 'service'). Fixes QubesOS/qubes-issues#2947 Fixes QubesOS/qubes-issues#3104	2017-10-16 03:18:27 +02:00
Marek Marczykowski-Górecki	9ebd602407	One more place to use vm.klass instead of type(vm)	2017-10-16 03:10:19 +02:00
Marta Marczykowska-Górecka	dd990c04ac	Firewall settings ... Modified VM Settings - Firewall tab to be easier to use and saner.	2017-10-13 22:41:10 +02:00
HW42	ebc7426cab	Add handling for virt_mode including PVH mode	2017-10-12 17:06:17 +02:00
Marek Marczykowski-Górecki	0c5a2b1dcc	Fix resizing root volume ... Use "system storage" value from the window, not "private storage"... Reported by @0spinboson Fixes QubesOS/qubes-issues#3143	2017-10-08 16:57:08 +02:00
Marek Marczykowski-Górecki	058b813690	Merge branch 'klass-attr' ... * klass-attr: Fix setting kernel property use 'klass' property instead of actual VM object class	2017-10-08 16:55:33 +02:00
Marek Marczykowski-Górecki	4d3a992ac6	Fix setting kernel property ... Fixes QubesOS/qubes-issues#3145	2017-10-07 00:23:37 +02:00
Marek Marczykowski-Górecki	07162ba089	use 'klass' property instead of actual VM object class ... The later is going to be generic QubesVM class, to save admin.vm.List calls.	2017-10-07 00:22:41 +02:00
Marta Marczykowska-Górecka	75ddc62bed	Fixed issue#3113 - boot from cdrom ... Fixes missing cast to string in boot from cdrom tool. fixes QubesOS/qubes-issues#3113	2017-10-04 23:28:02 +02:00
Marek Marczykowski-Górecki	c2aad3ce20	Remove code referencing removed "extra drive" box	2017-09-14 02:34:10 +02:00
Marek Marczykowski-Górecki	54b45a91af	Merge remote-tracking branch 'qubesos/pr/41' ... * qubesos/pr/41: Create new VM	2017-09-14 00:28:39 +02:00
Marta Marczykowska-Górecka	79f82e4d23	Create new VM ... Create new VM window. Window slightly redesigned for more logical flow.	2017-09-14 00:20:15 +02:00
Marek Marczykowski-Górecki	3c906f9a5f	Merge remote-tracking branch 'qubesos/pr/40' ... * qubesos/pr/40: Added gui for booting VM from CDROM/block device. Remove obsolete sections from VM Settings: - drive image - paths	2017-09-13 23:50:53 +02:00
Marta Marczykowska-Górecka	2ac9b1d182	Added gui for booting VM from CDROM/block device. ... Available via command line (qubes-vm-boot-from-device) and from a button in VM Settings/Advanced.	2017-09-13 23:30:45 +02:00
Marta Marczykowska-Górecka	0e5feeac0d	Remove obsolete sections from VM Settings: ... - drive image - paths	2017-09-08 22:39:54 +02:00
Marta Marczykowska-Górecka	9c85dc34ec	Rename NetVM to Networking in vm-settings ... Renamed "NetVM" to "Networking" and to clear up any possible misunderstanding, renamed "none" to "(none)" in the appropriate dropdown. Fixes QubesOS/qubes-issues#1763	2017-09-05 00:51:25 +02:00
Marek Marczykowski-Górecki	da23873b47	settings: fix volume resize ... - use MiB instead of MB - do not allow root volume resize for template-based VMs - do not resize if nothing was changed (use int, not float)	2017-07-30 18:56:35 +02:00
Marek Marczykowski-Górecki	861d7c5413	settings: fix settings applications list ... Fix qvm-appmenus usage, do nothing when no change was made.	2017-07-30 18:55:32 +02:00
Marta Marczykowska-Górecka	693e1340ed	'rename VM' button in VM Settings ... rename VM button in VM settings: it asks for a new name, and then clones VM under the new name and deletes old one. Renaming VM closes VM settings window without saving any other changes. Changed max size of VM name field to 32 characters.	2017-07-29 13:28:53 +02:00
Marta Marczykowska-Górecka	2dda433fd3	'refresh available apps' button in VM Setting ... added a button in VM Settings, Applications tab to refresh the list of available apps	2017-07-29 13:28:53 +02:00
Marek Marczykowski-Górecki	9de507f95d	Change 'hvm' property to 'virt_mode' ... QubesOS/qubes-issues#2912	2017-07-18 04:24:32 +02:00
Marek Marczykowski-Górecki	402f1db80d	firewall: check for 'qubes-firewall' feature instead of being ProxyVM ... This enable better detection whether firewall settings will really be respected. Fixes QubesOS/qubes-issues#2003	2017-07-16 10:50:07 +02:00
Marek Marczykowski-Górecki	576299afea	settings: fix getting available appmenus list	2017-07-16 10:40:59 +02:00
Wojtek Porczyk	96fc9c192c	fixes from @marmarek's review	2017-07-14 02:19:24 +02:00
Wojtek Porczyk	1861ff386d	settings: devices	2017-07-12 15:12:44 +02:00
Wojtek Porczyk	c32391a030	settings: services	2017-07-12 15:12:44 +02:00
Wojtek Porczyk	e78ede26f1	adminapi storage	2017-07-12 15:12:43 +02:00
Wojtek Porczyk	092d38e09a	settings: misc removed	2017-07-12 15:12:43 +02:00
Wojtek Porczyk	cd2d3d7c0e	settings: firewall and network	2017-07-12 15:05:05 +02:00
Wojtek Porczyk	ac06eee39b	settings: dir_path, config_path	2017-07-12 15:05:05 +02:00
Wojtek Porczyk	cae10193e7	qubesmanager/settings: imports	2017-07-12 15:05:05 +02:00
Wojtek Porczyk	37d501c42b	rewrite firewall	2017-07-12 15:05:05 +02:00
Wojtek Porczyk	43f2f6b881	rewrite creating new qube	2017-07-12 15:05:05 +02:00
Wojtek Porczyk	eefa6c31c2	appmenus fix	2017-07-12 15:05:05 +02:00
Wojtek Porczyk	6462ae88b7	qubesmanager/utils	2017-07-12 15:05:05 +02:00
Wojtek Porczyk	ea28980717	settings: debug mode	2017-07-12 15:05:05 +02:00
Wojtek Porczyk	f6a5c02adb	qubesmanager/settings: make it work on qubesadmin, part 0	2017-07-12 15:04:55 +02:00
Wojtek Porczyk	2c3df7bd67	spring cleaning part 5: more python3 fixes	2017-07-12 14:54:14 +02:00
Wojtek Porczyk	f5d83d31dd	spring cleaning part 4 ... remove old imports	2017-07-12 14:54:13 +02:00
Wojtek Porczyk	64913fd968	spring cleaning part 3 ... some unnecessary leftovers	2017-07-12 14:54:12 +02:00
Wojtek Porczyk	a023fb708e	spring cleaning part 2 ... setup.py	2017-07-12 14:54:12 +02:00
Marta Marczykowska-Górecka	fb3dc6ecf7	update qubesmanager to compile under python3. ... note: qvm-net.py has changed location to a weird one.	2017-06-25 17:53:23 +02:00
Marta Marczykowska-Górecka	5daa35a301	update globalsettingsdlg for new API	2017-06-25 17:31:10 +02:00
Marek Marczykowski-Górecki	2a381227f2	Merge remote-tracking branch 'qubesos/pr/34' ... * qubesos/pr/34: Show size of current inter-VM clipboard in Ctrl-Shift-C notification message Show size of current inter-VM clipboard in Ctrl-Shift-C notification message	2017-05-31 12:59:21 +02:00
itinerarium	c2a340698e	Show size of current inter-VM clipboard in Ctrl-Shift-C notification message ... Fix copy/paste error QubesOS/qubes-issues#2825	2017-05-28 12:12:25 -04:00
itinerarium	9c284ebedb	Show size of current inter-VM clipboard in Ctrl-Shift-C notification message ... QubesOS/qubes-issues#2825	2017-05-28 11:49:34 -04:00
M. Vefa Bicakci	2ba6df43fc	Remove left-over debugging print-outs	2017-05-26 02:02:25 -04:00
M. Vefa Bicakci	a2d0b128b7	Make sure that new value of uses_default_kernel persists ... Prior to this commit, whenever the user selected the default kernel in a VM's "Advanced Settings" dialog in Qubes Manager, the "uses_default_kernel" flag would not be saved as expected. Instead of the intent to use the default kernel version for the VM in the future, the VM would be stuck with the specific kernel version and not any new future default kernel versions. This issue occurs because the "kernel" property setter for the QubesVm class resets the "uses_default_kernel" member variable to False, and Qubes Manager sets the "uses_default_kernel" property before setting the "kernel" property. Resolve this issue by making sure that the "uses_default_kernel" member variable of the VM in question is set after the "kernel" member variable.	2017-05-26 02:02:25 -04:00
M. Vefa Bicakci	d551bdc3fa	Do not abort VM restarts due to inconsistent info ... Prior to this commit, there have been occasional issues with the usage of the Qubes Manager's VM restart button where the restart procedure is interrupted due to an exception thrown after the VM in question is shut down. The exception has the following backtrace: ---- line: assert not vm.is_running() func: start_vm line no.: 1198 file: /usr/lib64/python2.7/site-packages/qubesmanager/main.py ---- line: self.caller.start_vm(vm) func: check_if_vm_has_shutdown line no.: 308 file: /usr/lib64/python2.7/site-packages/qubesmanager/main.py Upon investigation, the root cause of the issue appears to be inconsistent information provided by Xen regarding a recently-shut-down VM's start-up timestamp and its state (i.e., running or shut down). In some cases Xen would report that the VM is running whereas the start-up timestamp would be returned as None, due to unknown reasons. This inconsistency would then cause the code modified by this commit to call the Qubes Manager's "start_vm" method, which would attempt to assert that a VM is shut down, which would raise the aforementioned exception. This commit aims to resolve this issue by checking whether the VM has fully shut down according to Xen and by calling "start_vm" only if the VM has fully shut down. This commit also slightly refactors the affected code. Fixes: QubesOS/qubes-issues#2438	2017-05-13 14:30:37 -04:00