Commit Graph

256 Commits

Author SHA1 Message Date
Marek Marczykowski-Górecki
6f465fc674
Make pylint happy
- fix super-with-arguments
- fix various other issues
- review broad-except and ignore where appropriate
2020-08-23 03:16:19 +02:00
Marta Marczykowska-Górecka
ee5625b65c
Use the new QubesDaemonAccessError
Replaces the old, unified approach.
2020-08-11 01:08:48 +02:00
Marta Marczykowska-Górecka
8eb61b11ae
Fixed VM settings to be more tolerant of missing permissions
Settings unavailable due to permissions will be unavailable in the tool,
but the tool will start and attempt to show as much as possible.
2020-08-08 15:37:09 +02:00
Marta Marczykowska-Górecka
bdc11582f1
Changed Clone action in Qube Manager and VM settings to use the new Clone Qube dialog
fixes QubesOS/qubes-issues#5127
2020-07-30 22:30:58 +02:00
Marta Marczykowska-Górecka
61d15dd783
Fixed some minor defaults errors in VM settings 2020-07-14 22:53:16 +02:00
Marta Marczykowska-Górecka
77b42e7c5a
Final improvements and cleanup to list widgets handling in manager
Also removed old opaque prepare_choice functions and added
extensive docstrings.
2020-07-14 22:19:43 +02:00
Marta Marczykowska-Górecka
f0a8241e0d
Refactored VM Settings for less ugliness 2020-07-09 19:26:31 +02:00
Marta Marczykowska-Górecka
ab5e3dcfea
Improved Global Settings with more readable widget handling 2020-07-08 22:31:50 +02:00
Marta Marczykowska-Górecka
a41908f92f
Added gui daemon options to VM settings
Added allow-fullscreen and allow-utf8-titles as options to VM settings

references QubesOS/qubes-issues#2304
2020-07-07 21:47:13 +02:00
Marta Marczykowska-Górecka
37271db3d8
Fixed max volume size in VM settings
Now it can be anything up to pool size.

fixes QubesOS/qubes-issues#5890
2020-06-11 22:18:05 +02:00
Marta Marczykowska-Górecka
deb9b323f2
Applications tab in VM settings now reacts to template change and handles missing entries
On template change, qvm-appmenus is queried for changes in available apps.
If something is whitelisted and does not appear in the template, it is shown
in the list as "Application missing".

requires https://github.com/QubesOS/qubes-desktop-linux-common/pull/22
fixes QubesOS/qubes-issues5796
2020-05-11 17:36:53 +02:00
Marta Marczykowska-Górecka
b058db4ccf
Fixed incorrect memory checking in VM Settings
When a VM is not included in memory balancing, there is no point
(and it can be actively harmful via deception) in showing warnings
about init_mem and maxmem mismatch.

fixes QubesOS/qubes-issues#5306
2020-04-06 15:31:00 +02:00
Marta Marczykowska-Górecka
96e75b350a
Template should not be enabled for running VMs in VM Settings 2020-03-26 16:51:41 +01:00
Marta Marczykowska-Górecka
08d1435eea
Show correct template for DispVMs VM Settings
DispVMs should have a template listed from among vms with 'template_from_dispvm'
property, not from the normal available templates.

fixes QubesOS/qubes-issues#5746
2020-03-26 16:50:25 +01:00
Marta Marczykowska-Górecka
0534ec6d15
Fixed init memory warning being shown twice
Also fixed the init memory warning to only be shown for Linux qubes (it is
not necessary for other qubes)

fixes QubesOS/qubes-issues#5612
2020-01-30 21:46:18 +01:00
Marek Marczykowski-Górecki
20da3a5854
Merge remote-tracking branch 'origin/pr/224'
* origin/pr/224:
  Handle deleting in VM Settings without silent fails
2020-01-16 04:41:37 +01:00
Marek Marczykowski-Górecki
848277ae4b
Merge remote-tracking branch 'origin/pr/223'
* origin/pr/223:
  Fixed Apply behavior for VM Settings
2020-01-16 04:39:39 +01:00
Marta Marczykowska-Górecka
e17332d84c
Handle deleting in VM Settings without silent fails
Deleting qube will now show a Delete in Progress dialog box and
not exit QApplication before QThread finishes.

fixes QubesOS/qubes-issues#5515
2020-01-08 22:04:36 +01:00
Marta Marczykowska-Górecka
f4f76110f0
Fixed Apply behavior for VM Settings
VM Setting will now update (current) markers correctly after Apply.

fixes QubesOS/qubes-issues#5531
2020-01-08 21:20:27 +01:00
Marta Marczykowska-Górecka
4298de6564
Moved debug mode checkbox to advanced settings
It really had no place in Basic settings, and will free up space for future
settings.
2019-12-14 15:39:09 +01:00
Marta Marczykowska-Górecka
5f86660305
Added handling for supported services to VM settings
Slight change to layout of services tab, made it hopefully
less confusing. Dropdown will now list services supported by this
VM and its template, not just an assortment of hardcoded services.
2019-12-14 15:39:09 +01:00
Marta Marczykowska-Górecka
2a73bfbb4c
Fixed bug in VM Settings
Wrong variable name caused a crash on start
2019-11-28 15:44:54 +01:00
Marek Marczykowski-Górecki
283ed2540c
Merge remote-tracking branch 'origin/pr/210'
* origin/pr/210:
  Fixed translation for application names
  Added translation support to all untranslated qubesmanager files
  Re-enabled translation support for Qt5
2019-11-09 15:32:18 +01:00
Marta Marczykowska-Górecka
b4cb9303bc
Fixed translation for application names 2019-11-09 00:50:44 +01:00
Marta Marczykowska-Górecka
46952ebad2
Added translation support to all untranslated qubesmanager files
references QubesOS/qubes-issues#5410
2019-10-29 12:28:22 +01:00
Marta Marczykowska-Górecka
520cefa010
Fixed VM settings warning labels
No netvm warning will now show differently for VMs that don't provide
network and those that do.
2019-10-29 11:53:44 +01:00
hexagonrecursion
42affe0da6
Remove redundant popups 2019-10-27 10:22:41 +00:00
Marek Marczykowski-Górecki
fcec3d7464
Merge remote-tracking branch 'origin/pr/200'
* origin/pr/200:
  Pylint fixes
  Code deduplication and cleanup
  Removed unused line in GUI Backup
2019-09-30 03:51:44 +02:00
Saswat Padhi
4ee3c556c4
Show the previous VM name while renaming
Currently while renaming VMs, the default text is empty "". This change modifies this default text to the original name of the VM.
2019-09-26 18:29:31 -07:00
Marta Marczykowska-Górecka
32078242c9
Code deduplication and cleanup
Moved loop handling, exception handling and program
running methods of the gui tools to the utils file.

fixes QubesOS/qubes-issues#5342
2019-09-26 22:31:39 +02:00
Marek Marczykowski-Górecki
1e3c0bfcd8
Merge remote-tracking branch 'origin/pr/194'
* origin/pr/194:
  Fix arithmetic in init/max mem ratio correction
2019-08-28 15:52:22 +02:00
Marek Marczykowski-Górecki
990e4abbbf
Merge remote-tracking branch 'origin/pr/178'
* origin/pr/178:
  Update Qt version used in qubesmanager to Qt5
2019-08-28 15:19:26 +02:00
Aras Ergus
bbe14f524d
Fix arithmetic in init/max mem ratio correction
Qubes Manager seems to try to guarantee that 10*init_mem is at
least max_mem by automatically adjusting init_mem to max_mem/10 if
inappropriate values are set. However, this may not guarantee that
10*init_mem >= max_mem due to rounding errors. This change fixes
these edge cases by basically rounding up the result of division
by 10.
2019-08-17 15:42:36 +02:00
Marta Marczykowska-Górecka
d0b99ef438
Cleaned up QThreads usage in VM Settings
fixes QubesOS/qubes-issues#4949
2019-06-14 21:13:56 +02:00
Marek Marczykowski-Górecki
b2e6c1556a
Merge remote-tracking branch 'origin/pr/182'
* origin/pr/182:
  Added 'provides network' checkbox to VM settings
2019-06-10 03:48:13 +02:00
Marta Marczykowska-Górecka
1f9b462bd3
Added 'provides network' checkbox to VM settings
A simple checkbox in the 'Advanced' tab. Does not allow disabling
'provides_network' if the VM is in use as NetVM; instead, a tooltip
informs the user which VMs use it.

fixes QubesOS/qubes-issues#5079
2019-06-07 20:13:24 +02:00
Marta Marczykowska-Górecka
e79724f9db
Update Qt version used in qubesmanager to Qt5
Fixed dependencies, places where obsolete functions stopped working,
code fragments that started throwing warnings and an .ui file that
stopped being readable after the update.
2019-05-30 21:33:49 +02:00
Marta Marczykowska-Górecka
7e17d23003
Added Virtual DNS display to VM settings
fixes QubesOS/qubes-issues#5050
2019-05-29 22:24:24 +02:00
Marta Marczykowska-Górecka
6b6621abfc
Fixed error in VM settings
fixes QubesOS/qubes-issues#4951
2019-04-05 21:35:46 +02:00
Marek Marczykowski-Górecki
0cdbda5df9
Merge remote-tracking branch 'origin/pr/168'
* origin/pr/168:
  Fixed device handling in VM settings widget
2019-04-04 01:27:08 +02:00
Marta Marczykowska-Górecka
077bcb3a8e
Fixed device handling in VM settings widget
PCI devices are now handled as DeviceInfo objects, not (string,name) tuples;
furthermore, a device that no longer exists in the system can be
correctly removed via VM settings window (it is displayed as Unknown
device).

fixes QubesOS/qubes-issues#2789
2019-04-03 20:47:09 +02:00
Marek Marczykowski-Górecki
8318db9b4e
Merge remote-tracking branch 'origin/pr/169'
* origin/pr/169:
  Fixed device list behavior for a running VM in VM settings
2019-04-03 16:43:37 +02:00
Marta Marczykowska-Górecka
6cf0e83b1d
Fixed device list behavior for a running VM in VM settings
PCI devices will now correctly be unmodifiable if the VM is running.

fixes QubesOS/qubes-issues#4933
2019-04-02 22:16:55 +02:00
donoban
34adc75752
Moved busy_cursor() inside save_changes() 2019-03-31 20:04:04 +02:00
donoban
c85d6e4e8b
Removed unneded calls to Override/Restore cursor 2019-03-31 20:01:38 +02:00
donoban
16f2997222
Removed duplicated call to save_changes() 2019-03-31 19:59:55 +02:00
donoban
1fbf6c9a59
Removed unneeded Cursor override/restore 2019-03-31 19:58:52 +02:00
donoban
8e383e3022
Added busy_cursor()
fix https://github.com/QubesOS/qubes-issues/issues/4744
2019-03-31 19:56:01 +02:00
donoban
8816a764ee
Merge remote-tracking branch 'upstream/master' 2019-03-17 17:09:13 +01:00
Marta Marczykowska-Górecka
1c06d241f0
Fix bug with fixed bug in VM Settings
fixes QubesOS/qubes-issues#4866
2019-03-11 22:02:32 +01:00