Qubes/manager
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1,239 Commits 1 Branch 0 Tags 4.4 MiB
f6c8103f46
Commit Graph

904 Commits

Author SHA1 Message Date
donoban
287fc441f3
Catch possible KeyError when starting dispVM 2018-11-18 20:23:26 +01:00
donoban
935a6ca6c7
Fix authorship and python version 2018-11-18 20:22:27 +01:00
donoban
a39f3a64d0
Create backup_window on the stack 
Otherwise it can casue an error:
RuntimeError: wrapped C/C++ object of type QProgressBar has been deleted
at line 1277
of file /usr/lib/python3.5/site-packages/qubesmanager/qube_manager.py.

I don't know how to avoid it.
 2018-11-18 20:14:57 +01:00
Marek Marczykowski-Górecki
5edb1fdc6a
Merge remote-tracking branch 'origin/pr/134' 
* origin/pr/134:
  Fix error in qube manager
 2018-11-16 16:53:38 +01:00
Marek Marczykowski-Górecki
f93feb82ce
Merge remote-tracking branch 'origin/pr/133' 
* origin/pr/133:
  Added GUI for toggling of seamless mode for windows
 2018-11-16 16:52:10 +01:00
donoban
cbc5d364bf
Removed sigchld_handler old code 2018-11-04 18:19:16 +01:00
Marta Marczykowska-Górecka
8098466a07
Fix error in qube manager 
In some cases (when a VM quickly appears and disappears)
the events were handled in a wrong order.

fixes QubesOS/qubes-issues#4414
 2018-10-29 23:00:59 +01:00
donoban
5c8f19b598
Fix pylint 2018-10-27 13:21:33 +02:00
donoban
c42203098f
Do not terminate the thread 
self.back_restore.canceled will do the abort
 2018-10-27 13:00:19 +02:00
donoban
988b7a6479
Fix error/success message on dialog 2018-10-27 12:58:58 +02:00
donoban
6045f451c6
Fix opening settings/boot dialog after VM creation 2018-10-25 09:45:12 +02:00
donoban
7f572b5c81
Add pylint disable too-few-methods 2018-10-24 11:27:47 +02:00
donoban
fd1e5d740a
Fix travis errors 2018-10-24 10:58:36 +02:00
donoban
042ff808b3
Removed unused import 2018-10-24 10:14:48 +02:00
donoban
971ec085ee
Workaround for backup dialog modeless behaviour 
Since now it's modeless, user could have already it opened
but we have to destroy it and recreate when closed for vm list
being refreshed (at least for now)
 2018-10-24 10:05:43 +02:00
donoban
531b9daad2
Signal rewrite to new style 
old is not supported in pyqt5
 2018-10-24 09:46:16 +02:00
donoban
461cb7ae8c
Don't close main about dialog when close some child dialog 2018-10-24 09:45:29 +02:00
donoban
23e9ae8d33
Remove loop since we have vm name 2018-10-24 00:03:17 +02:00
Marta Marczykowska-Górecka
65b50c0f3b
Added GUI for toggling of seamless mode for windows 
Added two buttons to enable/disable seamless mode
for windows qubes.

references QubesOS/qubes-issues#3585
references QubesOS/qubes-issues#4342
 2018-10-23 22:51:28 +02:00
donoban
e124d83edc
Removed processEvents() calls 2018-10-23 00:07:55 +02:00
donoban
9102d200bd
restart wizzard when wrong password or backup corrupted 
fix: https://github.com/QubesOS/qubes-issues/issues/1589
 2018-10-22 23:47:51 +02:00
donoban
0e951dc156
Deleted unused method show_error() 
clear_threads() handles messages now
 2018-10-22 20:03:20 +02:00
donoban
edb13aec17
Thread.error renamed to Thread.msg 
Since it could be used for both error or sucess
messages, I think msg is a better name
 2018-10-22 20:00:37 +02:00
donoban
60af90ec5f
Adding # pylint: disable=too-few-public-methods 2018-10-22 10:14:26 +02:00
donoban
4aea47c9f7
... 2018-10-21 22:52:52 +02:00
donoban
df15c4e3ae
Fix pylint warnings and errors 2018-10-21 22:38:41 +02:00
donoban
a7537a323a
Wops 
I did not notice on my pylint because it complains about all imports
 2018-10-21 00:16:23 +02:00
donoban
c46b38ab42
Travis3 2018-10-21 00:06:37 +02:00
donoban
f93908f5b7
Fix travis build2 2018-10-20 23:23:06 +02:00
donoban
831769d2dd
Fix travis build 2018-10-20 23:01:35 +02:00
donoban
38051ad243
Fixes in ProgressDialogs and settings window close 2018-10-20 22:09:39 +02:00
donoban
2347f75633
Clear SearchBox with ESC key 2018-10-20 21:54:25 +02:00
donoban
ad1bcc55b9
Deleted unneded method _clone_vm() 2018-10-20 21:25:13 +02:00
donoban
11cc8b7a67
Remove debug print 2018-10-20 19:20:39 +02:00
donoban
29ca4eb3a8
Migration from python threads and to QThread obj 
Simple design and better performance, just start() thread and finished
call back will show any error or msg, stop progress dialog and do cleanup.

Full remove of QT process_events() calls.
 2018-10-20 18:34:15 +02:00
donoban
35cdf5e1e5
Modeless backup window 
Let the main window work while doing backups
 2018-10-20 16:50:45 +02:00
donoban
759dc5412c
Pylint ident warnings 2018-10-20 16:49:50 +02:00
donoban
76b6de9d00
removed subprocess.check_call() 
This way modal works better (in KDE the main window goes gray).
 2018-10-20 16:43:15 +02:00
donoban
612cfc15d6
Loading Qube Manager progress using setValue() 
This is the recommended QT way for updating the progress bar.

setMininumDuration() sets the time when the progress dialog will appear,
if it finishes before it won't be shown. Qt default is 4 seconds, maybe
pretty high for this case.
 2018-10-20 16:33:25 +02:00
donoban
228aaed2f4
Removed progress.setWindowFlags() call 
I am not sure what this wants, but it seems that doesn't affect
xfce but on kde does the progress bar appear randomly in the screen

without it on both cases it appears at center of screen
 2018-10-20 16:28:19 +02:00
Marta Marczykowska-Górecka
77cf9bf1d2
Fixed error in qube manager of change of global settings 
Changing global properties fired an event that crashed qube
manager.

fixes QubesOS/qubes-issues#4385
 2018-10-19 20:06:30 +02:00
donoban
af8bc69314
Revert "Deleted unneeded thread_monitor" 
This reverts commit fea560b5cd.
 2018-10-18 15:53:35 +02:00
donoban
fea560b5cd
Deleted unneeded thread_monitor 2018-10-18 14:13:20 +02:00
donoban
b45f318a3a
Just moved method to better place 2018-10-18 14:13:06 +02:00
donoban
afcdba3029
Replaced python threading with QThreads 2018-10-18 14:11:25 +02:00
Marek Marczykowski-Górecki
70adf9cca9
Merge remote-tracking branch 'origin/pr/127' 
* origin/pr/127:
  Changed blank kernelopts in VM settings from [] to -
  Fixed kernelopts in VM settings
 2018-09-29 13:53:50 +02:00
Marta Marczykowska-Górecka
4ff111eb81
Changed blank kernelopts in VM settings from [] to - 
as requested by @marmarek
 2018-09-27 21:34:56 +02:00
Marta Marczykowska-Górecka
bc15ef91ec
Fixed kernelopts in VM settings 
For some reason, they were not being displayed at all. Now fixed.

fixes QubesOS/qubes-issues#4188
 2018-09-21 14:09:07 +02:00
Marta Marczykowska-Górecka
f618716548
Fix error on refresh when a VM has vanished 
Fixes error that can occur when VM-removed and VM-changed
events fire too closely together.

fixes QubesOS/qubes-issues#4317
 2018-09-21 12:46:49 +02:00
Marek Marczykowski-Górecki
3b4e3dd5d0
Merge remote-tracking branch 'origin/pr/89' 
* origin/pr/89:
  Changes as requested by @marmarek
  Added instructions for tests
  Initials tests for qube manager
  Backup tests
  Tests for Backup
  Numbered tests for Global Settings
  Removed unused import from global settings test
  Tests for global settings
 2018-09-17 00:03:56 +02:00
Marta Marczykowska-Górecka
e18058039f
Changes as requested by @marmarek 2018-09-16 23:33:17 +02:00
Marta Marczykowska-Górecka
f99df0d577
Added instructions for tests 2018-09-16 17:48:54 +02:00
Marta Marczykowska-Górecka
b0c7aed800
Initials tests for qube manager 2018-09-16 17:48:54 +02:00
Marta Marczykowska-Górecka
a69c061b49
Backup tests 2018-09-16 17:48:54 +02:00
Marta Marczykowska-Górecka
f6bda2e9f6
Tests for Backup 
Initial tests.
 2018-09-16 17:48:54 +02:00
Marta Marczykowska-Górecka
fc6c886543
Numbered tests for Global Settings 2018-09-16 17:48:54 +02:00
Marta Marczykowska-Górecka
44163be96d
Removed unused import from global settings test 2018-09-16 17:48:54 +02:00
Marta Marczykowska-Górecka
f5d94c2bf7
Tests for global settings 
Unit tests for global settings window; based on QtTest
 2018-09-16 17:48:54 +02:00
Marta Marczykowska-Górecka
cbf2e2154d
Fixed a small bug with Qube Manager status refresh 
On change of template Vm status, qube Manager errored
out. It no logner does that.
 2018-09-14 18:01:20 +02:00
Marek Marczykowski-Górecki
8d99fdd11b
Remove all dbus references 
Including package dependencies
 2018-09-12 16:32:37 +02:00
Marta Marczykowska-Górecka
3ad70484e6
Corrections as requested by @marmarek 2018-09-12 16:23:14 +02:00
Marta Marczykowska-Górecka
a761875b60
Pylint fixes 2018-09-10 18:04:45 +02:00
Marta Marczykowska-Górecka
4fc295e6a7
Added AdminAPI events to Qube Manager 
rewritten parts of Qube Manager to use AdminAPI events (with quamash
to combine PyQt with asyncio).

hopefully fixes QubesOS/qubes-issues#4116
hopefully fixes QubesOS/qubes-issues#4258
hopefully fixes QubesOS/qubes-issues#4244
obsoletes/fixes QubesOS/qubes-issues#4190
hopefully fixes QubesOS/qubes-issues#3675
 2018-09-10 17:48:14 +02:00
Marta Marczykowska-Górecka
20ee51f3d1
Fixed error with asynchronous handling of VM remove and VM halting 
It will hopefully fix QubesOS/qubes-issues#4163 .

references QubesOS/qubes-issues#4163
 2018-08-06 21:53:09 +02:00
Marek Marczykowski-Górecki
146ce683f7
Merge remote-tracking branch 'qubesos/pr/122' 
* qubesos/pr/122:
  And also fixed problem with setting default template to None
  Fixed problem with setting default_dispvm to None in Global Settings
 2018-07-24 01:39:33 +02:00
Marta Marczykowska-Górecka
a4c63cc939
And also fixed problem with setting default template to None 
The bug was the same.
 2018-07-22 23:57:50 +02:00
Marta Marczykowska-Górecka
6377983f9a
Fixed problem with setting default_dispvm to None in Global Settings 
fixes QubesOS/qubes-issues#4114
 2018-07-22 23:55:09 +02:00
Marta Marczykowska-Górecka
7b29a044d6
Fixed column widths in Qube Manager 
Columns were resizing incorrectly (with too large minimums).

fixes QubesOS/qubes-issues#4002
 2018-07-20 23:14:06 +02:00
Marta Marczykowska-Górecka
5e52b16fd3
Minor changes as requested 
Minor changes as requested by @marmarek
 2018-07-20 17:48:39 +02:00
Marta Marczykowska-Górecka
027abd8ac3
Pylint corrections 
Pylint 2.0 was complaining. Cosmetic fixes to make it stop.
 2018-07-20 00:25:27 +02:00
Christopher Laprise
b2fdbb950a
Handling VM dependencies in GUI tools 
Added the following reactions ot VM dependencies in GUI tools:
- Qube Manager will inform the user why they cannot delete a VM (which
properties of which VMS [or global] are using the VM)
- Settings window will try to intelligently rename VMs (change
properties to the new name, if possible, and inform the user what went
wrong if not)
- Settings window will inform the user why they cannot delete a VM
Also, renaming VM from Settings launched from Qube Manager will
refresh the VM list through a horrible hack, to be replaced by a neater
Admin API solution in some near future.

depends on ca848ca7bd

fixes QubesOS/qubes-issues#3992
fixes QubesOS/qubes-issues#3993
fixes QubesOS/qubes-issues#3892
fixes QubesOS/qubes-issues#3499
 2018-07-20 00:03:37 +02:00
Marta Marczykowska-Górecka
d46bf2aa8e
Improved communication on Remove VM in Qube Manager 
When a user tries to remove a VM that's used by other VMs
or Global Settings from Qube Manager, they get information
about where the VM is used.

Depends on https://github.com/QubesOS/qubes-core-admin-client/pull/73
 2018-07-18 23:51:37 +02:00
Marek Marczykowski-Górecki
b8c1ec8dac
Merge remote-tracking branch 'qubesos/pr/119' 
* qubesos/pr/119:
  Make Qube Manager remember its size from last time
 2018-07-17 15:57:59 +02:00
Marek Marczykowski-Górecki
9bb6a8cc94
Merge remote-tracking branch 'qubesos/pr/118' 
* qubesos/pr/118:
  Fixed incorrect kernel display in VM settings
 2018-07-17 15:56:09 +02:00
Marta Marczykowska-Górecka
e5dee2d70c
Make Qube Manager remember its size from last time 
Qube Manager will now remember its size from last time it was run, and
also it will no longer force itself to appear at top left corner of
the screen.

fixes QubesOS/qubes-issues#4049
 2018-07-16 18:47:07 +02:00
Marta Marczykowska-Górecka
af5aa233bb
Fixed incorrect kernel display in VM settings 
Kernel set to 'None' was incorrectly displayed as 'default'.

fixes QubesOS/qubes-issues#4043
 2018-07-16 17:35:35 +02:00
Marek Marczykowski-Górecki
18d45e53c6
Merge remote-tracking branch 'qubesos/pr/115' 
* qubesos/pr/115:
  Make 'NetVm' column in Qube Manager clearer with regars to defaults
 2018-07-16 14:15:12 +02:00
Marta Marczykowska-Górecka
7fb41f5cd6
Make 'NetVm' column in Qube Manager clearer with regars to defaults 
When a VM has netvm set to 'default', now Qube Manager will display
'(default)' in front of the netvm's name.

references QubesOS/qubes-issues#3567
 2018-07-16 14:07:27 +02:00
Marek Marczykowski-Górecki
f62aeb51d6
Merge remote-tracking branch 'qubesos/pr/116' 
* qubesos/pr/116:
  Add a list of Suggested Services to VM settings
 2018-07-16 13:52:47 +02:00
Marta Marczykowska-Górecka
6f4870bc8d
Changes to for pylint 2.0 
Fixes to make pylint 2.0 stop complaining.
 2018-07-16 02:17:48 +02:00
Marta Marczykowska-Górecka
63a202f3bd
Add a list of Suggested Services to VM settings 
Added a list of suggested services to the Services tab in VM Settings.
The list is drawn from man qvm-services (manually, not automatically).

fixes QubesOS/qubes-issues#3891
 2018-07-16 01:33:20 +02:00
Marta Marczykowska-Górecka
3f0af4498c
Fixed VM name validation in GUI tools (Create VM, Settings, Manager) 
VM name validation in various places in Manager did not allow a
perfectly legal '_' character.

references QubesOS/qubes-issues#2422
 2018-07-13 21:05:00 +02:00
Marek Marczykowski-Górecki
0a44c931da
Merge remote-tracking branch 'qubesos/pr/109' 
* qubesos/pr/109:
  Pylint whitespace fix
  Fixed Backup GUI size
  Add option to turn off computer after backup to Backup GUI
 2018-07-12 23:47:35 +02:00
Marek Marczykowski-Górecki
0c103e08b7
Merge remote-tracking branch 'qubesos/pr/106' 
* qubesos/pr/106:
  Offset context menu in Manager to avoid accidental clicks
 2018-07-12 23:42:55 +02:00
Marek Marczykowski-Górecki
5e4ac80ed2
Merge remote-tracking branch 'qubesos/pr/105' 
* qubesos/pr/105:
  Remove templates from listing in UpdateVM and ClockVm in Global Settings
 2018-07-12 23:41:47 +02:00
Marek Marczykowski-Górecki
bd7d3e576a
Merge remote-tracking branch 'qubesos/pr/103' 
* qubesos/pr/103:
  Fixed identation and other problems on merge
  Fix minor performance bug
  Removed unneeded manual sort
  Avoid lag on loading dialog
  Removed unneeded try/except
  Protect update() from accesing deleted domains
  Sort performance boost
 2018-07-12 23:40:15 +02:00
Marta Marczykowska-Górecka
9d16bec870
Pylint whitespace fix 
Removed superfluous whitespace.
 2018-07-12 23:31:30 +02:00
Marek Marczykowski-Górecki
635171c4f4
Merge remote-tracking branch 'qubesos/pr/100' 
* qubesos/pr/100:
  Modified Qube Manager menu for dom0
 2018-07-12 23:27:53 +02:00
Marta Marczykowska-Górecka
80b3a82963
Add option to turn off computer after backup to Backup GUI 
A simple checkbox to turn off the computer after backup finishes
successfully. It is off by default and must be switched on every time
(unexpected system shutdowns are a huge pain, much more problematic
than forgetting to shut down can be).

fixes QubesOS/qubes-issues#2039
 2018-07-12 22:47:02 +02:00
Marta Marczykowska-Górecka
5bdca303b1
Offset context menu in Manager to avoid accidental clicks 
Small fix to Qubes Manager to open the context menu slightly to the
right of the mouse to avoid accidental clicks. Originally created by
@unman , ported to 4.0 and including changes to context menu from
pull request#100.

fixes QubesOS/qubes-issues#1911
 2018-07-12 21:47:01 +02:00
Marta Marczykowska-Górecka
efa2b2d858
Remove templates from listing in UpdateVM and ClockVm in Global Settings 
A user should not be able to set a TemplateVM as an UpdateVM or ClockVM
in Global Settings.

fixes QubesOS/qubes-issues#1831
 2018-07-12 21:22:15 +02:00
Marta Marczykowska-Górecka
2f2217060e
Modified Qube Manager menu for dom0 
Instead of generic menu with almost everything grayed-out, now
context menu for dom0 has only Global Settings, Logs and update.

references QubesOS/qubes-issues#1382
fixes QubesOS/qubes-issues#1165
 2018-07-12 15:38:27 +02:00
donoban
d886983c02
Fixed identation and other problems on merge 2018-07-12 02:00:17 +02:00
donoban
8096a50f7f
Merge remote-tracking branch 'upstream/master' 
# Conflicts:
#	qubesmanager/table_widgets.py
 2018-07-12 01:42:36 +02:00
donoban
5ddd029d34
Fix minor performance bug 2018-07-12 01:26:34 +02:00
Marek Marczykowski-Górecki
b0e275bb3e
Merge remote-tracking branch 'qubesos/pr/101' 
* qubesos/pr/101:
  Removed 'close window' button in progress dialogs in Qube Manager
 2018-07-12 01:23:45 +02:00
donoban
1d80837cd0
Removed unneeded manual sort 
Same its called later during init process
 2018-07-12 01:22:28 +02:00
donoban
14f58fe8c1
Avoid lag on loading dialog 2018-07-12 01:21:04 +02:00
donoban
632f23c298
Removed unneeded try/except 2018-07-12 01:19:20 +02:00
donoban
bd919e44c1
Protect update() from accesing deleted domains 2018-07-12 01:17:48 +02:00