manager/qubesmanager/appmenu_select.py
Marta Marczykowska-Górecka deb9b323f2
Applications tab in VM settings now reacts to template change and handles missing entries
On template change, qvm-appmenus is queried for changes in available apps.
If something is whitelisted and does not appear in the template, it is shown
in the list as "Application missing".

requires https://github.com/QubesOS/qubes-desktop-linux-common/pull/22
fixes QubesOS/qubes-issues5796
2020-05-11 17:36:53 +02:00

121 lines
4.4 KiB
Python
Executable File

#!/usr/bin/python2
#
# The Qubes OS Project, http://www.qubes-os.org
#
# Copyright (C) 2011 Marek Marczykowski <marmarek@mimuw.edu.pl>
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public License along
# with this program; if not, see <http://www.gnu.org/licenses/>.
#
#
import subprocess
from PyQt5 import QtWidgets, QtCore # pylint: disable=import-error
# TODO description in tooltip
# TODO icon
# pylint: disable=too-few-public-methods
class AppListWidgetItem(QtWidgets.QListWidgetItem):
def __init__(self, name, ident, tooltip=None, parent=None):
super(AppListWidgetItem, self).__init__(name, parent)
if tooltip:
self.setToolTip(tooltip)
self.ident = ident
@classmethod
def from_line(cls, line):
ident, name, comment = line.split('|', maxsplit=3)
return cls(name=name, ident=ident, tooltip=comment)
@classmethod
def from_ident(cls, ident):
name = 'Application missing in template! ({})'.format(ident)
comment = 'The listed application was available at some point to ' \
'this qube, but not any more. The most likely cause is ' \
'template change. Install the application in the template ' \
'if you want to restore it.'
return cls(name=name, ident=ident, tooltip=comment)
class AppmenuSelectManager:
def __init__(self, vm, apps_multiselect):
self.vm = vm
self.app_list = apps_multiselect # this is a multiselect wiget
self.whitelisted = None
self.has_missing = False
self.fill_apps_list(template=None)
def fill_apps_list(self, template=None):
self.whitelisted = [line for line in subprocess.check_output(
['qvm-appmenus', '--get-whitelist', self.vm.name]
).decode().strip().split('\n') if line]
currently_selected = [
self.app_list.selected_list.item(i).ident
for i in range(self.app_list.selected_list.count())]
whitelist = set(self.whitelisted + currently_selected)
# Check if appmenu entry is really installed
# whitelisted = [a for a in whitelisted
# if os.path.exists('%s/apps/%s-%s' %
# (self.vm.dir_path, self.vm.name, a))]
self.app_list.clear()
command = ['qvm-appmenus', '--get-available',
'--i-understand-format-is-unstable', '--file-field',
'Comment']
if template:
command.extend(['--template', template.name])
command.append(self.vm.name)
available_appmenus = [
AppListWidgetItem.from_line(line)
for line in subprocess.check_output(command).decode().splitlines()]
for app in available_appmenus:
if app.ident in whitelist:
self.app_list.selected_list.addItem(app)
whitelist.remove(app.ident)
else:
self.app_list.available_list.addItem(app)
self.has_missing = bool(whitelist)
for app in whitelist:
item = AppListWidgetItem.from_ident(app)
self.app_list.selected_list.addItem(item)
self.app_list.available_list.sortItems()
self.app_list.selected_list.sortItems()
def save_appmenu_select_changes(self):
new_whitelisted = [self.app_list.selected_list.item(i).ident
for i in range(self.app_list.selected_list.count())]
if set(new_whitelisted) == set(self.whitelisted):
return False
p = subprocess.Popen([
'qvm-appmenus', '--set-whitelist', '-', '--update', self.vm.name],
stdin=subprocess.PIPE)
p.communicate('\n'.join(new_whitelisted).encode())
if p.returncode != 0:
exception_text = QtCore.QCoreApplication.translate(
"Command {command} failed", "exception").format(
command='qvm-appmenus --set-whitelist')
raise RuntimeError(exception_text)
return True