Browse Source

firewall: fix Firewall.clone()

New rule require action to be defined, even if will be overwritten a
moment later.
Marek Marczykowski-Górecki 6 years ago
parent
commit
0cd25b5350
1 changed files with 3 additions and 1 deletions
  1. 3 1
      qubes/firewall.py

+ 3 - 1
qubes/firewall.py

@@ -479,7 +479,9 @@ class Firewall(object):
         '''
         rules = []
         for rule in other.rules:
-            new_rule = Rule()
+            # Rule constructor require some action, will be overwritten by
+            # clone_properties below
+            new_rule = Rule(action='drop')
             new_rule.clone_properties(rule)
             rules.append(new_rule)
         self.rules = rules