Qubes/core-admin
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tests: fix firewall test - use the IP, not the ping command...

Browse Source
This commit is contained in:
Marek Marczykowski-Górecki 2015-03-30 22:33:08 +02:00
parent d69b03e5e0
commit b563cf290e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/network.py
View File

@ -193,7 +193,7 @@ class VmNetworkingMixin(qubes.tests.SystemTestsMixin):
"Ping by name from ProxyVM failed") "Ping by name from ProxyVM failed")
self.assertNotEqual(self.run_cmd(self.testvm1, self.ping_ip), 0, self.assertNotEqual(self.run_cmd(self.testvm1, self.ping_ip), 0,
"Ping by IP should be blocked") "Ping by IP should be blocked")
nc_cmd = "nc -w 1 --recv-only 192.168.123.45 1234" nc_cmd = "nc -w 1 --recv-only {} 1234".format(self.test_ip)
self.assertNotEqual(self.run_cmd(self.testvm1, nc_cmd), 0, self.assertNotEqual(self.run_cmd(self.testvm1, nc_cmd), 0,
"TCP connection should be blocked") "TCP connection should be blocked")
@ -233,7 +233,7 @@ class VmNetworkingMixin(qubes.tests.SystemTestsMixin):
'allow': False, 'allow': False,
'allowDns': True, 'allowDns': True,
'allowIcmp': True, 'allowIcmp': True,
'rules': [{'address': self.ping_ip, 'rules': [{'address': self.test_ip,
'netmask': 32, 'netmask': 32,
'proto': 'tcp', 'proto': 'tcp',
'portBegin': 1234 'portBegin': 1234
@ -250,7 +250,7 @@ class VmNetworkingMixin(qubes.tests.SystemTestsMixin):
'allow': True, 'allow': True,
'allowDns': True, 'allowDns': True,
'allowIcmp': True, 'allowIcmp': True,
'rules': [{'address': self.ping_ip, 'rules': [{'address': self.test_ip,
'netmask': 32, 'netmask': 32,
'proto': 'tcp', 'proto': 'tcp',
'portBegin': 1234 'portBegin': 1234